From: Andrew Lunn <andrew@lunn.ch>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: wangruikang@iscas.ac.cn, andrew+netdev@lunn.ch,
davem@davemloft.net, dlan@gentoo.org, edumazet@google.com,
kuba@kernel.org, linux-kernel@vger.kernel.org,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
pabeni@redhat.com, spacemit@lists.linux.dev
Subject: Re: [PATCH 1/1] net: spacemit: Check netif_carrier_ok when reading stats
Date: Mon, 19 Jan 2026 16:09:13 +0100 [thread overview]
Message-ID: <48757af2-bbea-4185-8cc9-2ef51dbc8373@lunn.ch> (raw)
In-Reply-To: <20260119141620.1318102-1-amadeus@jmu.edu.cn>
> root@OpenWrt:~# ethtool -S eth1
> [ 71.725539] k1_emac cac81000.ethernet eth1: Read stat timeout
> NIC statistics:
> rx_drp_fifo_full_pkts: 0
> rx_truncate_fifo_full_pkts: 0
>
> I just discovered that adding "motorcomm,auto-sleep-disabled" to disable
> the sleep mode of the MotorComm PHY prevents the problem from occurring.
This suggests that when the PHY stops the reference clock, the MAC
hardware stops working. It needs that clock to access
statistics. Keeping the clock ticking will increase power usage a
little.
I wounder if anything else stops working? There are some MACs whos DMA
engine stop working without the reference clock. That can cause
problems during both probe and remove, or open and close.
So it would be nice to have a better understanding of this. If this
turns out to be true, maybe a comment by this poll_read_timeout()
indicating if it does timeout, the PHY might be the problem.
Andrew
next prev parent reply other threads:[~2026-01-19 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-18 10:00 Chukun Pan
2026-01-18 16:19 ` Andrew Lunn
2026-01-19 3:54 ` Vivian Wang
2026-01-19 14:16 ` Chukun Pan
2026-01-19 15:09 ` Andrew Lunn [this message]
2026-01-20 4:16 ` Vivian Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48757af2-bbea-4185-8cc9-2ef51dbc8373@lunn.ch \
--to=andrew@lunn.ch \
--cc=amadeus@jmu.edu.cn \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=dlan@gentoo.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=spacemit@lists.linux.dev \
--cc=wangruikang@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®