From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>,
"Roman Kagan" <rkagan@virtuozzo.com>,
"Denis Plotnikov" <dplotnikov@virtuozzo.com>,
den@virtuozzo.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: x86: avoid redundant REQ_EVENT
Date: Thu, 15 Dec 2016 15:32:45 +0100 [thread overview]
Message-ID: <4876bc4a-b72a-897e-84a7-c34c3f934705@redhat.com> (raw)
In-Reply-To: <20161215143054.GC6667@potion>
On 15/12/2016 15:30, Radim Krčmář wrote:
>
> One useless round of KVM_REQ_EVENT is not going change nested
> performance by much and it is not the only thing we could improve wrt.
> TPR ... I would just leave it for now and take care of it when we
> * don't to update PPR at all with APICv -- it is already correct
> * drop the KVM_REQ_EVENT with flex priority, because lower TPR cannot
> unmask an interrupt
I agree. I still don't like the patch very much, because I feel like an
explicit state machine ("can KVM_REQ_EVENT do anything?") would be more
maintainable. But if I don't come up with anything we'll go with this
patch.
Paolo
next prev parent reply other threads:[~2016-12-15 14:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 10:59 Denis Plotnikov
2016-12-14 21:36 ` Radim Krčmář
2016-12-14 22:29 ` Paolo Bonzini
[not found] ` <20161215071840.GB7704@rkaganb.sw.ru>
2016-12-15 14:30 ` Radim Krčmář
2016-12-15 14:32 ` Paolo Bonzini [this message]
2016-12-15 14:56 ` Roman Kagan
2016-12-18 21:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4876bc4a-b72a-897e-84a7-c34c3f934705@redhat.com \
--to=pbonzini@redhat.com \
--cc=den@virtuozzo.com \
--cc=dplotnikov@virtuozzo.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rkagan@virtuozzo.com \
--cc=rkrcmar@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®