From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E72A2D5924 for ; Tue, 24 Feb 2026 06:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771913891; cv=none; b=DxfXTtFy60/Jdj4uAeduFH2kpseVP+A2Xfyt2g3K5QaepYpv31gY7/SYnlVRn10cHstHdQ05t9ouwAWbDczI9QZhJxTZFMQgci9ozWuuoAik4Dhx4QsKIXGw68NWn84F4Pl/sLFYc4XjSyj++n8ZNMnr5FxPA021AINQgJpG6x8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771913891; c=relaxed/simple; bh=55ftLdvyOLNET2JD8Cx2U7172SmE3PQBBQsKretftwc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ApxZ+fVOaJibZfbgv+QrxPyUdZYkeFPZQFW5koel5hFyDKlD3rR4iwgaFFkTV6dzxdTn6kGLoVM7jW8gI2C7tPKHKbV/hCHFXVUTC4JipYp7ALQneHsJGKeXRVB6Y1tU6k4+y43b7US0nThhP0koJtJsyejYPRCoGktCp8Uk2Og= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SJM0S5xl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jTeGx+1O; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SJM0S5xl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jTeGx+1O" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61O4LnUu2570222 for ; Tue, 24 Feb 2026 06:18:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= JIF3RzhViYYlwxx+OD/unsWmeMnNrO6XtaAytnKLG5w=; b=SJM0S5xliId38m0K yEeHtH36NYE+SuY/Jiivi5rbioKb+jvioZ0KTCFwPBsbt9TixdCi+zbsJiwsQUZT 0gh8VH+1WUfX1G8tCK8yzM9LRRkBRXzYAVhncJEw/2wQCsdTcQeSydM/3ZJgT5c9 dFZtguSyMcGmuv0OriC68j58AdtPaBW7girwYib3Vdsv8McKNnp3SaNuRjWQDFU+ TeGs2DHWyoxECcnALatSSaqQkf8tyzUiFqFOaTt9XCWz9NiyNabV8yjowfjZ+2U0 y4WJ+01NZTMcNnFnAT12oWjlGRpca/6rQBoBnLNqv0TmLFTLiyWe8Hf1L9jUHg2B 87zx+w== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cgn8y34ju-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 24 Feb 2026 06:18:07 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35678f99c6eso3582957a91.1 for ; Mon, 23 Feb 2026 22:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1771913887; x=1772518687; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=JIF3RzhViYYlwxx+OD/unsWmeMnNrO6XtaAytnKLG5w=; b=jTeGx+1OOb9eQnXAWNJAtlrQ6ePfASVtxcTx6IoLsMV8C6SM9NiwHvT11jHOBgzxwe pnn+mlu5C4Co8xTjKvvXYe26/Qjeg2lmY0zZAvfFFBSDJtWPUGHYyr92RqYecGFmD4YB v/ptkmeS9meuTE45Dz8WIOUlf8dFjY78aTrNKASuTxjH8CprmhqRpCYCwHNMXIJA2Yzc rCxEavu7r/iz0YUUYOwzqxiT0VbC3JdcK6FTsLMsV4Ja14//BpGIuQI/swEPfvlw22qO 0e7pntsqSXDQscISWd0VE9iwC7lHFTxdc7ZguA5bC9Mo0Mt5+th0w8qCXu/9uh2YUdRG SWPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771913887; x=1772518687; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JIF3RzhViYYlwxx+OD/unsWmeMnNrO6XtaAytnKLG5w=; b=oGGA3XE7bp8lv3/W2aZln4vjzdGpTCzhyXCY6oP2kita4LSMgAOf5DYa63P3rh3rQs gSi0rhRjgP/ysUE3cXCjdhPMit69a5GG7TZC6y2wCo5ms+ammGfqw/+xuUtGcwMHrrVa 9S6Ca7ypM7CUuQGyYGu/U5QVCcw7inAc/fTUoPqZACuznEkYmgrw4WwvcGbZLqTzPFH/ LdUOlhWWHHUa/OpXncLsWLulp+/v2zd08t8+rRGTJ62wjdoX8ZjXs3r2Bbix8pJvHMa+ 6A9biyRduHX59MtTcVH9wTF9yvcYtDLgpWgA2y6tDZsuN35hwwBo/HKeR6GlS20EusXQ +Khg== X-Forwarded-Encrypted: i=1; AJvYcCUdHUq036zcHVq85S3bJtjkInMmlcVjPbLE7tJvXsueILflOFa0wDtlBnImaB2/VNDw+5ntvNJW/SY3hrI=@vger.kernel.org X-Gm-Message-State: AOJu0YyMxpk/FZC0H0S2UoVh/HIHkTFmnM29sWnwP9FlPIuOd0vu33xO rLhp3gIeYD/xifbQQKAVwu/84vlY9EXt7XGgaFDyJQU2HT5CLnZvJkqKvS7DYkWeBC+dvfSFhRa L2lBmcssOpyjwTz609Ff6ihBqA/TEO/JaztY3b6HcfYdlAm1x8fnEXHEcGDtXjWvnq14= X-Gm-Gg: ATEYQzyAjF2dIIUL9yqJ93nB4SHDroJnGkQ0YUiD0bQKBfNDH/Om9Ri3h4S5N2sycnM LwzlwxJPAPy46IAaiw0YjeS8iyLo488eVA/YSPlqZcxuH9m8i2Y8VJpkdZlH4KJEnmN6KMoWnOC TnkSNaW7bF2ye1LEpkC4k3olSQ7tvFBSeF8UOnEfEDYolpdu6nBj8p97xJFAhywWY/02QflkTn+ 2ziAUpfT1Tw6EtlllgiDLikXUQ7KyuTnnlmSpDXjPcZflvQi9FxkcS7cGrnZg1mXD/Te+xqkTh1 16qoiI7w51cWi9+ETxWNrciqFL78wUrals6bPmZyCPVBdpkvwDwoYz1kru6FwD1UcnYWDfBbcNR y7/WNRscnzSX6H4xsA8buOJGAP0Mw1YJJvy5CIETTGjU+1CqwY2l1Zpuqu0x/LsLEff39nsX1nO DZ3USpPZUD0dm1qOKJ0IV09BQl5dN5FOfd0wWFr5I= X-Received: by 2002:a17:90b:2e0f:b0:356:3ba2:1233 with SMTP id 98e67ed59e1d1-358ae8b3dafmr8115458a91.22.1771913886839; Mon, 23 Feb 2026 22:18:06 -0800 (PST) X-Received: by 2002:a17:90b:2e0f:b0:356:3ba2:1233 with SMTP id 98e67ed59e1d1-358ae8b3dafmr8115432a91.22.1771913886336; Mon, 23 Feb 2026 22:18:06 -0800 (PST) Received: from [10.190.200.237] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-358af5f8b1bsm8333890a91.0.2026.02.23.22.18.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 22:18:05 -0800 (PST) Message-ID: <48778fa8-b485-4c79-be1a-c70836f65f0b@oss.qualcomm.com> Date: Tue, 24 Feb 2026 11:48:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 5/5] arm64: dts: qcom: glymur-crd: Enable ADSP and CDSP To: Dmitry Baryshkov Cc: Konrad Dybcio , robh@kernel.org, srini@kernel.org, amahesh@qti.qualcomm.com, krzk+dt@kernel.org, conor+dt@kernel.org, andersson@kernel.org, konradybcio@kernel.org, mathieu.poirier@linaro.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org References: <20260129001358.770053-1-sibi.sankar@oss.qualcomm.com> <20260129001358.770053-6-sibi.sankar@oss.qualcomm.com> <24973bc9-a082-42ec-89f4-12758ddca136@oss.qualcomm.com> <8d96ebc8-67e2-424d-adbc-0948dd3641a0@oss.qualcomm.com> Content-Language: en-US From: Sibi Sankar In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjI0MDA1MSBTYWx0ZWRfX+N+OokmDEd+t 0bU7s7cseKLwVl9MNELrc9m2t4u3bAaijeHD3D60QPGGjEBGdj8nCBaSEKnNdFskGwQpaD76edl 5xZZMsw6+Uk7dsuoiEAxA1Nvu+YlJnrqt/ptpHoclfSDEQ84GYfdmBH2PSTm6bFZiXj8Mrd+csg zTEgsbFsW/BAU6PVpc90oTEJ2GAiwU8Bd/4cOdDdMVz4CXhmLkOrJBElCKJSgIz7DIZgDSmOHti BTg0hG+XUeMHItrOvrU+orfHxZteAWAKtGITXFxoelmQyzoXZW+DLq7vPabrXoa1+StKu4F0qCT OAniNZhPvzauO7VqO+CV9Y1/U5AKVUl/fZhOnKwTEZ+dy/7KHbWAa654ejQLchaPa94CxBQEOz5 7MSuEizQFyzrE7c4upVXJfL4Y/sNyaLEhZTlnOgd/kCtlJIDHowPI0Z501dizYBr6tt6l5VVeXX 4pSKvoJYyXZBF46FDmw== X-Authority-Analysis: v=2.4 cv=edYwvrEH c=1 sm=1 tr=0 ts=699d42a0 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=ePpz_JlwkyPc9ubz9f4A:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-GUID: Za9_ceUSXHjnWGQVCi49FqWlt-Dtgvxb X-Proofpoint-ORIG-GUID: Za9_ceUSXHjnWGQVCi49FqWlt-Dtgvxb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-23_06,2026-02-23_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 impostorscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2602240051 On 2/23/2026 10:44 PM, Dmitry Baryshkov wrote: > On Mon, 23 Feb 2026 at 11:09, Sibi Sankar wrote: >> >> On 2/3/2026 6:09 PM, Dmitry Baryshkov wrote: >>> On Mon, Feb 02, 2026 at 11:16:19AM +0100, Konrad Dybcio wrote: >>>> On 1/31/26 8:54 AM, Dmitry Baryshkov wrote: >>>>> On Fri, Jan 30, 2026 at 10:55:24AM +0100, Konrad Dybcio wrote: >>>>>> On 1/29/26 1:13 AM, Sibi Sankar wrote: >>>>>>> Enable ADSP and CDSP on Glymur CRD board. >>>>>>> >>>>>>> Signed-off-by: Sibi Sankar >>>>>>> --- >>>>>>> arch/arm64/boot/dts/qcom/glymur-crd.dts | 14 ++++++++++++++ >>>>>>> 1 file changed, 14 insertions(+) >>>>>>> >>>>>>> diff --git a/arch/arm64/boot/dts/qcom/glymur-crd.dts b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>> index 0899214465ac..0eed4faa8b07 100644 >>>>>>> --- a/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>> +++ b/arch/arm64/boot/dts/qcom/glymur-crd.dts >>>>>>> @@ -487,6 +487,20 @@ &pon_resin { >>>>>>> status = "okay"; >>>>>>> }; >>>>>>> >>>>>>> +&remoteproc_adsp { >>>>>>> + firmware-name = "qcom/glymur/adsp.mbn", >>>>>>> + "qcom/glymur/adsp_dtb.mbn"; >>>>>>> + >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>>> + >>>>>>> +&remoteproc_cdsp { >>>>>>> + firmware-name = "qcom/glymur/cdsp.mbn", >>>>>>> + "qcom/glymur/cdsp_dtb.mbn"; >>>>>>> + >>>>>>> + status = "okay"; >>>>>>> +}; >>>>>> Please make sure it gets to L-F (only Kaanapali is there right now) >>>>>> >>>>>> Reviewed-by: Konrad Dybcio >>>>> Hmm, looking at x1e80100-crd which references qcom/x1e80100/adsp.mbn, >>>>> but the firmware in linux-firmware is (now) targeting IoT devices, >>>>> should we use WoA-like names for firmware on Glymur CRD instead >>>>> (qcadsp-something.mbn). It would match what was done for the SC8280XP >>>>> CRD. >>>> I think it's simply time to stop pretending the firmware is generic >>>> (some fw simply isn't and some fw may come from different/incompatible >>>> branchpoints) and include a board name in the path >>> Well... CDSP is usually generic, except for WP vs non-WP. >> Hey Dmitry/Konrad, >> >> Thanks for taking time to review the series :) >> >> The ADSP/CDSP firmware that got upstreamed to linux-firmware got their >> functionality tested on Glymur WP CRD devices. Given that the firmware >> has already landed, can I continue to use the same name as the patch and >> have a different name for other boards if something specific has to be >> pushed >> for IOT? > Thank you for a prompt reaction, it took just 20 days. During that > time we could have fixed WP firmware filenames, but... linux-firmware Hey Dmitry, I'm really sorry that this happened this way :( but I was out on vacation the past three weeks getting married. A quick review comment on the firmware pull request for naming change request would also sufficed in the interim. Also to address some of your concerns there aren't any plans to push an iot specific ADSP/CDSP firmware for Glymur reference devices. Also, this series already warrants a re-post so I can still accommodate your naming requests with corresponding updates to linux-firmware. -Sibi > got released just two days ago, so we can't fix that anymore. Now we > don't have any other option than to use a non-standard name for IoT > firmware when it comes later. > >> -Sibi >> >