From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B09D2D6E44 for ; Wed, 13 May 2026 18:26:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696761; cv=none; b=oBadgloI4U5665PrHs9osAzo1IIZGKKcJ2fmO+y4WFFWJAwxVOjtWGTk2O0FdfyICcC0EPt8JsBW/JH//GMJWkFkPHyoPsFh85uRx6r5D01TXYai89Ivf7zsuDdxMaUvXlhh7gBOsvdZ+JpJvjnZ8TwZE8iNWxb3dms8k3wR/oI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778696761; c=relaxed/simple; bh=7rnvyRlJhuUqIb2oFq7ELJ1mpCOYsn/9XpIh0Ol9Ujc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kA4iFYGYVZbA/rmN9kdZDVsOGI3AN6rtx3xbaPl5ku+ZeeXie683uHXTk2NfDwqlldywKehiQydDpW66jxNdXssG6QXSUQ1XYxFjAToBHehcS3lJXYhjOTptoeSCV9oSV/sLQ6bCm+NHpXQaJiOK0OTWG1Mt1guCCBJZO7DfgxI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=HW+HhnP+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=LdT7ZP0d; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="HW+HhnP+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="LdT7ZP0d" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64DH4CXw3430137 for ; Wed, 13 May 2026 18:25:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tzZbszvrmLucZ4gFsiU1bkMESXXLy06AymspFyubZyA=; b=HW+HhnP+KdOA4P9A cabJOyD2Jle8/bcceY1r8HZ9My1jMTRsWiOyCn9QUzkUs9Z4ZD0IVyy/VtLT1Bwg 20HshiV5Qtc0Kl38U3KRxmVNwU5PaiyXmzhqFn6KJ/oSwyYXLbV7XXWNulWQG0aL k2iYWzNYDnwwVeskrKZdT7OV7A9e5ssWhZ6/Dpcln6T1Cycnjm/UO1nMPIIUwEK8 ZtBtg9CS2x7QVTM/v2q8PjBcE7IVA6HJnUQBwauHNfrLby+5MFw4tjrTA9pSf57e kyNfhy24FVUkXRZBi0TZWGZR/ZSBh75+Bt0tYINTSv2aswqWwr+rp+ZHKbqjxBOK qBK14g== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e4qmchuum-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 13 May 2026 18:25:59 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2bc763c7256so102527865ad.3 for ; Wed, 13 May 2026 11:25:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778696758; x=1779301558; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=tzZbszvrmLucZ4gFsiU1bkMESXXLy06AymspFyubZyA=; b=LdT7ZP0dF0fQZdxILWKE8zverskU78fbZ4exmoU4QT+OboPErrr97U6oxEbNHp+uVG Nk1rYvshPOANDd3oN26u5lb9hfNZTo6dctZp+GDgQsmHNUsiXD1CSZjzoeSux83x6m1K goVI1sJ1OTXhlLysNtN/Ye9Iaw4SYduwzWxJOfOjmOqgxjx7oxg9J0qLnHLQnVjI6BNZ Yk0pCkKH2+F/0gtcqSipM2HAdB+nTWtwXDFHr3TogoZaZDGjoEGCk8VmJxMRnDWTIfda iseJ5Th1evEFV5Y5rr0bRFE67CDZEQeTl9ii6vMwvYRVH/vjnl/OCoBal+IZtn6rC2M7 N8yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778696758; x=1779301558; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tzZbszvrmLucZ4gFsiU1bkMESXXLy06AymspFyubZyA=; b=KptsNQZURVv96AYrIf0/kOeKeS2hvwtRTxXaqB80BkSYPE6i/Mg5iVqX2Ly1j2zXS9 cddSM6wnguAq3HvUH5hoFr2XdGRpi0QxDpZNPVho3/xB/cSasp9wdpmz2UIPI6mEEHiy R1fm3/0l9dwmrjVHrB4R/n88ZtP9IlAeSnErX0dQDb9tFvkQieEFk9dVrNaxtc901ge2 w26vGZ27RMS/ysEOgxXdm5KOoZvVzZjwHCZawTEynpJOMGTcPTTfn3MB0Z1md+OwDHRs uTMzxyCdOZgJ6HNT/akvZIQJfaZI8OwW0RxXkYI54BghAJBwXNXrxsVfRfdrcpnw4DG+ yrPQ== X-Forwarded-Encrypted: i=1; AFNElJ9cwBdnHK2fcexdnT7LL6EdSUn4/60wDr0Y3N+GM5azzjgjzTkSiJCpZMOer2c3tukbwwupPqhHda4F6BU=@vger.kernel.org X-Gm-Message-State: AOJu0YxmlB8jHaD9GjymJ86SXkidD82i5k+2aEhegG0PTEV2TJJ2WKqz PQwYsV9Zojg2eVvbtkD9iR05vlsn0J+mGyS5QLDzH1aHir6KkZC7y00OKihsCZS1gMGsMoORA39 iN88iJN+uhmsVFc1eHeg9AUMR0WKss60sbm6Os8eOvUuZIqVWUi9Xd7f4+1FHx6Dyw1g= X-Gm-Gg: Acq92OEa9jhq6gQvu5l5zPh5uVtDFBXvLhwS89eoN/Ss3w7t/ncJ8KPgpL5YjuBjrlZ 3lNjhaXEMb2130PKe2VSP1fEzZ49mdV/YaYDRxCU9TGRF8+7yeSU8fr4GjpKdBZtbPmdTNNnQ8Q hdAaNL2QQ3bG7dlCleileV1OZ20JDsWkan6Vsq4xWvuUp/HUu2Ue2swrjzJfP2WCZAcY40ayWCr fVp3fblEBhZufIsfLrPC19EdPBv1Sl46ieZhvVgMPNab+6RWnlNpfepbW0XKbuKNl0zJpy1Kaq+ DbTn+Z2YNeEpoLByR3b6AMH0gmfwtx2dOZ07/Pe6w8TjV+OwUYiGtoBAjwjwDXifBRmaXKV6nrM MJu/1Jxb7lCVRwbuT5vmWdoTTQbCSAonuRb13E9Hs5RfG6MF6rh0Pavmg X-Received: by 2002:a17:902:ef11:b0:2bd:2051:13ed with SMTP id d9443c01a7336-2bd276f2e1dmr51757795ad.23.1778696758408; Wed, 13 May 2026 11:25:58 -0700 (PDT) X-Received: by 2002:a17:902:ef11:b0:2bd:2051:13ed with SMTP id d9443c01a7336-2bd276f2e1dmr51757375ad.23.1778696757877; Wed, 13 May 2026 11:25:57 -0700 (PDT) Received: from [192.168.0.172] ([49.205.255.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d27083sm186116005ad.13.2026.05.13.11.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 May 2026 11:25:57 -0700 (PDT) Message-ID: <487a1bd7-3ce2-4a78-be18-f3d3469e1b93@oss.qualcomm.com> Date: Wed, 13 May 2026 23:55:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/6] media: qcom: iris: add helpers for 8bit and 10bit formats To: Neil Armstrong , Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-topic-sm8x50-iris-10bit-decoding-v3-0-7fc049b93042@linaro.org> <20260511-topic-sm8x50-iris-10bit-decoding-v3-1-7fc049b93042@linaro.org> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260511-topic-sm8x50-iris-10bit-decoding-v3-1-7fc049b93042@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 6sLHPKqvMTjsmVhqP83BFpBUbZf-flDb X-Authority-Analysis: v=2.4 cv=Hu5G3UTS c=1 sm=1 tr=0 ts=6a04c237 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=6GFGFuPpdQFN+sW0UwB+2Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=1v4LsqrUVehaW6lpU9YA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTEzMDE4MyBTYWx0ZWRfXzrbjVm/umuqi MUKb/oGH9GjZiKfor2A8UdxJWJtD1JE/ZpB1aefo58j9B3qrxUQE93lednlsvUaUMbIjdy13Ttm +10Z2JC225QMB8RJ/AlxQCQuFCBCb+wcNxG1vpxv9laASuCRUX3G4zAO6om8YUs39JM+n1pdUSV stt221KyCwQfWDiHXlS/TEsDyT/s4gY50Yh2O54V7BZm1Wy7ROtjFp5YL3j4e/BZGlNIc3HIMqd nQQ4O0MwhmRXj1CLZWDowMf4sIl0M8qlEJAFW3X5AhK89r/EkR1LWdML6VrKDIQCMnT/oIbYsu+ lzgCp6MRyRAdS8VCSv1ToqXW3dOhjbHpfRqYTv0AF1hfWzb5DNbmtMtp46pBAmlLLseTVlkXeHR C4Z43A/bc5DQ6ctfpAEd1/jeV1jEQMhYAX+6rrCzwipHB/eqwb3NX8p711NXso7EFCQ3bBVWtMp QavRQIHaFvZk+URpTHw== X-Proofpoint-ORIG-GUID: 6sLHPKqvMTjsmVhqP83BFpBUbZf-flDb X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-13_02,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 impostorscore=0 priorityscore=1501 spamscore=0 clxscore=1015 bulkscore=0 suspectscore=0 adultscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605050000 definitions=main-2605130183 On 5/11/2026 2:50 PM, Neil Armstrong wrote: > To simplify code checking for pixel formats, add helpers to > check for 8bit and 10bit formats. > > Reviewed-by: Dikshita Agarwal > Signed-off-by: Neil Armstrong > --- > drivers/media/platform/qcom/iris/iris_utils.c | 12 ++++++++++++ > drivers/media/platform/qcom/iris/iris_utils.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/media/platform/qcom/iris/iris_utils.c b/drivers/media/platform/qcom/iris/iris_utils.c > index cfc5b576ec56..bdedd6bfa87a 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.c > +++ b/drivers/media/platform/qcom/iris/iris_utils.c > @@ -38,6 +38,18 @@ bool iris_split_mode_enabled(struct iris_inst *inst) > inst->fmt_dst->fmt.pix_mp.pixelformat == V4L2_PIX_FMT_QC08C; > } > > +bool iris_fmt_is_8bit(__u32 pixelformat) u32 please, to maintain consistency with other > +{ > + return pixelformat == V4L2_PIX_FMT_NV12 || > + pixelformat == V4L2_PIX_FMT_QC08C; > +} > + > +bool iris_fmt_is_10bit(__u32 pixelformat) same > +{ > + return pixelformat == V4L2_PIX_FMT_P010 || > + pixelformat == V4L2_PIX_FMT_QC10C; > +} > + > void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > enum vb2_buffer_state state) > { > diff --git a/drivers/media/platform/qcom/iris/iris_utils.h b/drivers/media/platform/qcom/iris/iris_utils.h > index b5705d156431..35337c5da005 100644 > --- a/drivers/media/platform/qcom/iris/iris_utils.h > +++ b/drivers/media/platform/qcom/iris/iris_utils.h > @@ -45,6 +45,8 @@ bool iris_res_is_less_than(u32 width, u32 height, > u32 ref_width, u32 ref_height); > int iris_get_mbpf(struct iris_inst *inst); > bool iris_split_mode_enabled(struct iris_inst *inst); > +bool iris_fmt_is_8bit(__u32 pixelformat); > +bool iris_fmt_is_10bit(__u32 pixelformat); > struct iris_inst *iris_get_instance(struct iris_core *core, u32 session_id); > void iris_helper_buffers_done(struct iris_inst *inst, unsigned int type, > enum vb2_buffer_state state); > Regards, Vikash