From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D00EC7619A for ; Tue, 21 Mar 2023 15:09:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231594AbjCUPJF (ORCPT ); Tue, 21 Mar 2023 11:09:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231210AbjCUPJA (ORCPT ); Tue, 21 Mar 2023 11:09:00 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0391D50983; Tue, 21 Mar 2023 08:08:36 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A7077B817BB; Tue, 21 Mar 2023 15:08:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 53884C433EF; Tue, 21 Mar 2023 15:08:32 +0000 (UTC) Message-ID: <487b75ea-aecd-5fdc-c2a2-5f5080f8647e@xs4all.nl> Date: Tue, 21 Mar 2023 16:08:30 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] media: av7110: put spaces around operators Content-Language: en-US To: Daniel Watson , Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org References: From: Hans Verkuil In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Daniel, On 21/03/2023 07:45, Daniel Watson wrote: > put spaces around '=' and '<=' to match style from checkpatch > > Signed-off-by: Daniel Watson > --- > drivers/staging/media/av7110/av7110_hw.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/media/av7110/av7110_hw.h b/drivers/staging/media/av7110/av7110_hw.h > index 6380d8950c695..3274146c401f1 100644 > --- a/drivers/staging/media/av7110/av7110_hw.h > +++ b/drivers/staging/media/av7110/av7110_hw.h > @@ -402,8 +402,8 @@ static inline u32 irdebi(struct av7110 *av7110, u32 config, int addr, u32 val, u > { > u32 res; > > - res=av7110_debiread(av7110, config, addr, count); > - if (count<=4) > + res = av7110_debiread(av7110, config, addr, count); > + if (count <= 4) > memcpy(av7110->debi_virt, (char *) &res, count); > return res; > } > @@ -424,7 +424,7 @@ static inline u32 rdebi(struct av7110 *av7110, u32 config, int addr, u32 val, un > u32 res; > > spin_lock_irqsave(&av7110->debilock, flags); > - res=av7110_debiread(av7110, config, addr, count); > + res = av7110_debiread(av7110, config, addr, count); > spin_unlock_irqrestore(&av7110->debilock, flags); > return res; > } I'm not sure what the point it of these two fixes since this driver is full of such things. In any case, I'm rejecting this. Just leave this driver alone, it's not worth the effort. If you are doing this as part of some mentorship program, then skip the drivers/staging/media directory, it's not suitable for that. Regards, Hans