From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9E1DC07EBF for ; Fri, 18 Jan 2019 18:11:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9D36220823 for ; Fri, 18 Jan 2019 18:11:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728802AbfARSLD (ORCPT ); Fri, 18 Jan 2019 13:11:03 -0500 Received: from mail-sh.amlogic.com ([58.32.228.43]:50579 "EHLO mail-sh.amlogic.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728274AbfARSLD (ORCPT ); Fri, 18 Jan 2019 13:11:03 -0500 Received: from [192.168.0.111] (223.166.104.240) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1591.10; Sat, 19 Jan 2019 02:11:45 +0800 From: Jianxin Pan Subject: Re: [PATCH v9 0/2] mtd: rawnand: meson: add Amlogic NAND driver support To: Miquel Raynal CC: Boris Brezillon , , David Woodhouse , Brian Norris , Marek Vasut , Richard Weinberger , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Carlo Caione , Kevin Hilman , Rob Herring , Liang Yang , Jian Hu , Hanjie Lin , Victor Wan , , , , References: <1547566684-57472-1-git-send-email-jianxin.pan@amlogic.com> <20190115175232.3d82d4a9@xps13> Message-ID: <487cf528-fe4a-ec9c-754a-9e9188f16495@amlogic.com> Date: Sat, 19 Jan 2019 02:11:38 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: <20190115175232.3d82d4a9@xps13> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [223.166.104.240] X-ClientProxiedBy: mail-sh2.amlogic.com (10.18.11.6) To mail-sh.amlogic.com (10.18.11.5) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Miquel, On 2019/1/16 0:52, Miquel Raynal wrote: > Hi Jianxin, > > Jianxin Pan wrote on Tue, 15 Jan 2019 > 23:38:02 +0800: > >> These two patches try to add initial NAND driver support for Amlogic Meson >> SoCs, current it has been tested on GXL(p212) and AXG(s400) platform. >> >> Changes since V8 at [9] >> - fix build failre at object_is_on_stack >> - update Kconfig as Martin's suggested > > Thanks for this last version, looks good to me. Could you please send a > patch to add a MAINTAINERS entry? > OK. > Also, can we face any deadly failure if someone compiles this driver > without the MMC clock driver updated? > Without the MMC clock driver 1) This driver can be built successfully. 2) The probe will fail when get clocks defined in MMC clock driver. > Thanks, > Miquèl > > . >