From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Arnd Bergmann <arnd@kernel.org>,
Marcel Holtmann <marcel@holtmann.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Chris Lu <chris.lu@mediatek.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Sean Wang <sean.wang@mediatek.com>,
Jing Cai <jing.cai@mediatek.com>, Takashi Iwai <tiwai@suse.de>,
Peter Tsao <peter.tsao@mediatek.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH 2/2] Bluetooth: btmtk: remove #ifdef around declarations
Date: Mon, 22 Jul 2024 13:05:49 +0200 [thread overview]
Message-ID: <487dda47-ee5e-4835-ba63-05c0ce7ac6fc@collabora.com> (raw)
In-Reply-To: <20240722092735.1109925-2-arnd@kernel.org>
Il 22/07/24 11:27, Arnd Bergmann ha scritto:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The caller of these functions in btusb.c is guarded with an
> if(IS_ENABLED()) style check, so dead code is left out, but the
> declarations are still needed at compile time:
>
> drivers/bluetooth/btusb.c: In function 'btusb_mtk_reset':
> drivers/bluetooth/btusb.c:2705:15: error: implicit declaration of function 'btmtk_usb_subsys_reset' [-Wimplicit-function-declaration]
> 2705 | err = btmtk_usb_subsys_reset(hdev, btmtk_data->dev_id);
> | ^~~~~~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c: In function 'btusb_send_frame_mtk':
> drivers/bluetooth/btusb.c:2720:23: error: implicit declaration of function 'alloc_mtk_intr_urb' [-Wimplicit-function-declaration]
> 2720 | urb = alloc_mtk_intr_urb(hdev, skb, btusb_tx_complete);
> | ^~~~~~~~~~~~~~~~~~
> drivers/bluetooth/btusb.c:2720:21: error: assignment to 'struct urb *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
> 2720 | urb = alloc_mtk_intr_urb(hdev, skb, btusb_tx_complete);
> | ^
>
> Fixes: 52828ea60dfd ("Bluetooth: btmtk: Fix btmtk.c undefined reference build error")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
next prev parent reply other threads:[~2024-07-22 11:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-22 9:27 [PATCH 1/2] Bluetooth: btmtk: Fix btmtk.c undefined reference build error harder Arnd Bergmann
2024-07-22 9:27 ` [PATCH 2/2] Bluetooth: btmtk: remove #ifdef around declarations Arnd Bergmann
2024-07-22 11:05 ` AngeloGioacchino Del Regno [this message]
2024-07-22 15:46 ` [PATCH 1/2] Bluetooth: btmtk: Fix btmtk.c undefined reference build error harder patchwork-bot+bluetooth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=487dda47-ee5e-4835-ba63-05c0ce7ac6fc@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=chris.lu@mediatek.com \
--cc=jing.cai@mediatek.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=matthias.bgg@gmail.com \
--cc=peter.tsao@mediatek.com \
--cc=sean.wang@mediatek.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®