From: "Jan Beulich" <jbeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: reduce force_mwait visibility
Date: Fri, 18 Jul 2008 13:45:20 +0100 [thread overview]
Message-ID: <4880AC80.76E4.0078.0@novell.com> (raw)
It's not used anywhere outside its single referencing file.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/cpu/amd.c | 2 --
arch/x86/kernel/process.c | 2 ++
include/asm-x86/processor.h | 2 --
3 files changed, 2 insertions(+), 4 deletions(-)
--- linux-2.6.26/arch/x86/kernel/cpu/amd.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/arch/x86/kernel/cpu/amd.c 2008-07-15 14:54:53.000000000 +0200
@@ -61,8 +61,6 @@ static __cpuinit int amd_apic_timer_brok
}
#endif
-int force_mwait __cpuinitdata;
-
static void __cpuinit early_init_amd(struct cpuinfo_x86 *c)
{
if (cpuid_eax(0x80000000) >= 0x80000007) {
--- linux-2.6.26/arch/x86/kernel/process.c 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/arch/x86/kernel/process.c 2008-07-15 14:54:53.000000000 +0200
@@ -122,6 +122,8 @@ static void poll_idle(void)
*
* idle=mwait overrides this decision and forces the usage of mwait.
*/
+static int __cpuinitdata force_mwait;
+
static int __cpuinit mwait_usable(const struct cpuinfo_x86 *c)
{
if (force_mwait)
--- linux-2.6.26/include/asm-x86/processor.h 2008-07-13 23:51:29.000000000 +0200
+++ 2.6.26-x86-force-mwait-cleanup/include/asm-x86/processor.h 2008-07-15 14:54:53.000000000 +0200
@@ -727,8 +727,6 @@ static inline void __sti_mwait(unsigned
extern void mwait_idle_with_hints(unsigned long eax, unsigned long ecx);
-extern int force_mwait;
-
extern void select_idle_routine(const struct cpuinfo_x86 *c);
extern unsigned long boot_option_idle_override;
next reply other threads:[~2008-07-18 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 12:45 Jan Beulich [this message]
2008-07-18 22:55 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4880AC80.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome