From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759191AbbJ3XiA (ORCPT ); Fri, 30 Oct 2015 19:38:00 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:50788 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750834AbbJ3Xh6 (ORCPT ); Fri, 30 Oct 2015 19:37:58 -0400 From: Arnd Bergmann To: y2038@lists.linaro.org Cc: Tina Ruchandani , Johannes Thumshirn , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, Linux Kernel List Subject: Re: [Y2038] [RESEND PATCH v3] scsi: stex: Remove use of struct timeval Date: Sat, 31 Oct 2015 00:37:51 +0100 Message-ID: <4881842.skchM6NLXo@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <20151030083040.GA31741@tina-laptop> <1446195000.16404.55.camel@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:UNTLZtPp27KH3Z9KhiWfyl3JNaJihSQ7mAixRYocHbq28mvCoco JmQIx7hK6W6deK3AZBSIYrhSqZW/3Prv85vKJdSMeP8qvjPiWwDvmi/lCWOrFakxtrxiFPR BWzvdvpHBqnuzuKqcsOO0KP+Mn2FFrrapNhUQdhxGhXQKMfcgtVo8M+CvTxdXChWQGHTH/W VgOjqu81GI8wTq9oMFjhQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:owbmdKLP9M8=:hriNDP9vp6dkIyF6o3IdUm MGtnck9XRNtzHEGI6c79AFlQ6HHL8RJdXNrtcxO2NfAIZ4kwAglf3QfTS1AdlBSImO+0g1Gob OXq8IdtPcSm8EBEsB8DSzWlAmpYjyzme39fuj8T5f2iUteC+CZJru86wWzFF4IVA0+g4ZW2Gb QfH00n1WVclTNDKxt9QA1LDPF3tkwR/yCgk7NNi53wZWsMEUQ3I57Sh+rQfPX02tcj1WmGiPK l7/Yo4sqhdR2ZZRU83Q77wZ9ubheWNVEaUt/yxfKRrNlfKziVhZwC1eSROYiWT64ba9id2Ot2 zKOsrOkilcNqVp23qjKRFA5gI6MCjmPcrhJdhaEYyaBjG0Pqf5UvvlMlxLK4KwnvQRGpoXBc/ d0RD3817G1kcPh+wWal0rs7g1Pae47JkpRxm2nVJZGNgwgwa07wqw8fz3a1IdKjxgJxxYPowm mmbv0R2ojXjP6aPuOOjka4ygN4FFi92RdxVKrbkzo3wzEb9L7lNaHKWkOMe8xWj5gzptEeG8D Ch84yEgv7/ZHjUj8ZrO5qvRMTR3LljrdzbQhhsod5B+Elj/wbxdxe5whOgYcPbFCR3Cucbg71 Qc/tzQjXjPTc7LNB6yuqOXksbShkFJljCB3lnU22sVnYDz2CRtSu8l7SmXe5U1vc0v+BS2f4T vD2jyuaQJHgEyeLvZWQbziX2rp+42UhKe8nYgk2JDCJuL+LN27M1W+F7PXtlqTNP/8CsiEivV SkSm4BWT8LdrXt7X Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 30 October 2015 01:54:10 Tina Ruchandani wrote: > > > > Thanks for the conversion. Can you please check if other (scsi) drivers > > have the same y2038 issues? A quick "git grep do_gettimeofday > > drivers/scsi/ | wc -l" reveals 30 occurrences (of cause not all are > > problematic). In fact all of them are problematic, just for different reasons. * Some drivers actually overflow in 2038 in a way that causes problems in those drivers. These obviously need to be fixed right away. * A second class of drivers pass time_t/timeval/timespec values to or from user space. Even in cases where the absolute numbers are small (monotonic times, or time intervals), we have to change them to be able to deal with 32-bit user space that will be compiled against a modified libc using 64-bit time_t. * All other driver are likely not broken, but we want to change them anyway, to annotate the fact that we have looked at them. My goal is to remove the definition of time_t (and all derived structures) from the kernel once all drivers have been converted, to ensure that we are not adding new broken users, and to have a reasonable confidence that we have in actually found the ones that were wrong. > Hi Johannes, > Yes, there are quite a few occurrences of timeval within scsi. I had > sent some of the trivial back in the Feb-May 2015 period, and they > were ack-ed by my then mentor and a couple of other people, but not > merged or ack-ed by someone from linux-scsi. Until today, I thought > using "RESEND" would be impolite, but now I will resend the other ones > as well. Arnd Bergmann is leading this effort and may have more > insightful comments. > I provided a "Reviewed-by" tag in https://lkml.org/lkml/2015/5/5/201 . Normally, when patches get picked up directly from the list, the person who merges it should add the tags directly. However, if you have to re-send the patch (with or without small modifications), you should add that tag after your Signed-off-by, so it does not get lost when the new patch is applied. Arnd