From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CE69423E92 for ; Wed, 15 Jul 2026 09:25:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784107529; cv=none; b=G07S02yzNaiyl/XiSJW+ZY9gpJo3WBXD5GTxhdxAy4YpQ99yRExtN5B/yPD1wk8mLqNH7Y4uwpecjUNVyUZbB+TF2M9PltwLGfZU3JXbq/fLwHFkgWr2dNGZLWn1toflnvNFX+0l2HIaq6FmKhPXb+0uHv//HFyzfzFpI5B/m9A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784107529; c=relaxed/simple; bh=u4v43/Sd36brNlwbrbJ/ls1718vshZGyGcvjaF/4pqo=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=eqetMsaSuCcB9i2SRHCt2LTMzJzPCpMJ/URmzO0OOwtPT4NG9ZlRNqUQcHSihE99Ea/ZoN4+EM2QUKWUSTe5OYVlMlzjp1KvVA3QxFvRatOt2EbeFkUe4BbcSg2mcfRPQP+8sC1KKHyNfHG4vqZh0LrId4vwm6aQCwHF7ldZ9I4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q0xIibAt; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Y6eJFYXk; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q0xIibAt"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Y6eJFYXk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1784107526; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=u4v43/Sd36brNlwbrbJ/ls1718vshZGyGcvjaF/4pqo=; b=Q0xIibAtNQH58w5qf296OBAyDO0IpNpvn/+x1qaycBWhAJNaEdefE/MJvut1Z1yUXD71j8 gxEEeaVHJdbpCqA+tnKSx8AL1JZ+qPtU3cnSz0cGGuBPq918dfb8QaM3pMsSz+MlElnXTd eIthDyHYanBXlBsjy1DTvRojqGaoSSk= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-582-S2kn85SdOv2RdMau0H6VGg-1; Wed, 15 Jul 2026 05:25:10 -0400 X-MC-Unique: S2kn85SdOv2RdMau0H6VGg-1 X-Mimecast-MFC-AGG-ID: S2kn85SdOv2RdMau0H6VGg_1784107509 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-c15d4224f9dso275760166b.3 for ; Wed, 15 Jul 2026 02:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1784107509; x=1784712309; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=u4v43/Sd36brNlwbrbJ/ls1718vshZGyGcvjaF/4pqo=; b=Y6eJFYXkY8RWeoU02ZHI/5IVwzkjmGgbclwYXgOSC9g72UwvteRbP9l4x8pPwO9nQ5 8dys/NEm3OCpMwwvIPX+cYq7lMXHPiXcG6LOCD0ktOQRseCkq2kyhMglsAtVZkSB6dmJ cU/s5xiMqKi91O2tr2Ewu+fWckzr5x5754F9EgbsMDdOwgd5fraYzAZcswqn7c2OEywq OxJ9yOC/NFlgS9vzBUHk6Y1NkpQ0HCiNbyr9nfk5n/tTRkzjFB8gU7CqX7l14Qq8cyYd MMfNFOIC49CMIfqs7zkB+uDkIuBadF7H9Dq4r26lNMfGP27BJhwPdG35Ilagttjncgc9 i3yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784107509; x=1784712309; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=u4v43/Sd36brNlwbrbJ/ls1718vshZGyGcvjaF/4pqo=; b=QHsbXY5ewjgmhstjJjWdRpoGXtnKgXTJk/IDK8fQhcMU0E2FC5XomjdCg55T2btV8i YID9WVlafE1lAXUYeOVglVaJ/y6wNCeNyWdvZzbc88UuDtmXdKorHwzoGzybV0Soj4EN MzTHukbZ35tHaUi/iq0TQEI9kRGEfXkVqO9eNqGalgGKgLfKSSbuPu0fNZ5CkrzQH/h/ PABVtRw+kXXyH4XBjKNCs1afsURB4f1IFpIu4s4Sc9wsH/fKeSSr9JvNzzp4fGcnC/OX wuDO7GOLI1IMhBpxsRXqvZHR445lyfJcck+p2wmaP/zH4uVES4tqN7I6PiqTLH8T9q5X cpVw== X-Forwarded-Encrypted: i=1; AHgh+RpNtuK4DMjTwK75b7TbmSqrzXY77iAuBpigMiDflXUEZESsIfaV583s1N7P7Wfnk+2USyGEzXZJhJcTL6Q=@vger.kernel.org X-Gm-Message-State: AOJu0Yx3X5LOFddDJxDmZEee8uh0NbL77dNeBcKYHvrv22KcqUbwfSSf 5F71yVjonV30GuXaahFItjugmfyhCJQu5dTyOQX9e2yXeo3FlSH+n6JtkSOzJLLEsRJ3v9tDvKw mkNebO/HflaAFAiCmEwV/rAVldmiP6ZazVZPsdwmqmhjKdWF1wEgWu4UF9jkJTRXoHA== X-Gm-Gg: AfdE7ckvo49m3EKGOWQ/DiDBILukgzuapPSYlltAXlIEsJlH2y+dc/uNiyTYbBmAqy9 FyDq49sYjcN7LDJsRfJme+0pMa0u6/Za3FcueIw7oAiwYpRKZYf9gNX3UaRhc2Xtmn6qzKVFcZ0 7aDsC/mAeyWjFRQ5ODmh7ekNEWwCTXYRkSeI8HPv1yZV4ELPWw//G9g5bSvRlCT9wCGmC0V1cVd b+IKz70oC0zMsJJH6L/QJH76Nay+Qir0SpmkAcKiZCaXgyTZQGXsV51ArSFYDNA9ASWG9v1qCkx Hlgr6k6B/5sVoNY+IX0tmZtgBGr6bxzwYzsJ/NimyJdn7vAv8P5+m6dnqIQI3ANX3HayZGingwV MPVhmRA1lBbTrUQvL1cmsQ4498Kipfp156U0MJf6Gw4FouwA5JDoZ1mJNT5HSEvGpXaFyz7jHOr AQMsGO X-Received: by 2002:a17:907:3e95:b0:c16:55e0:adaa with SMTP id a640c23a62f3a-c16794b68c9mr127732866b.58.1784107508896; Wed, 15 Jul 2026 02:25:08 -0700 (PDT) X-Received: by 2002:a17:907:3e95:b0:c16:55e0:adaa with SMTP id a640c23a62f3a-c16794b68c9mr127730866b.58.1784107508348; Wed, 15 Jul 2026 02:25:08 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (212-8-243-115.hosted-by-worldstream.net. [212.8.243.115]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-69cd293be91sm2643190a12.23.2026.07.15.02.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jul 2026 02:25:07 -0700 (PDT) Message-ID: <4885b2132ca1e8ed0fd6010ef9506d6e99e58fdb.camel@redhat.com> Subject: Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit From: Gabriele Monaco To: Wen Yang , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org, Nam Cao Cc: Steven Rostedt , Thomas Weissschuh , Tomas Glozar , John Kacur Date: Wed, 15 Jul 2026 11:25:06 +0200 In-Reply-To: References: <20260625121440.116317-1-gmonaco@redhat.com> <20260625121440.116317-15-gmonaco@redhat.com> <53f2d13c-cc1d-48fd-95f0-2c1ff1edfc88@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-07-15 at 01:49 +0800, Wen Yang wrote: >=20 > Note that the same typo (handle_sample_event) appears in the other two > LTL golden files added in patch 05/17 as well: ltl_pertask.c and > test_ltl.c. The root is likely in the rvgen LTL template itself, so > the fix there would regenerate all three consistently. Yeah that's trivial to fix. > Understood on the intent. One small concern:=C2=A0 MODULE_AUTHOR(/* TODO = */) > is subtly different from an XXX comment =E2=80=94 a C preprocessor strips= the > comment before macro expansion, leaving=C2=A0 MODULE_AUTHOR() with an emp= ty > argument. When the user does go to compile, they get a cryptic error > rather than a clear "fill this in" hint. Well, I believe a compiler failure was indeed the original intent (that's k= inda what we do in rv_attach_trace_probe), to avoid unauthored monitors. Anyway an unauthored monitor isn't as bad as a missing tracepoint, so proba= bly I could make the LTL template consistent with the others. Unless Nam has concerns with that. Thanks, Gabriele