mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Lu Hongfei <luhongfei@vivo.com>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	Daniil Lunev <dlunev@chromium.org>, Bean Huo <beanhuo@micron.com>,
	Peter Wang <peter.wang@mediatek.com>,
	open list <linux-kernel@vger.kernel.org>,
	"open list:UNIVERSAL FLASH STORAGE HOST CONTROLLER DRIVER" 
	<linux-scsi@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Subject: Re: [PATCH v5] scsi: ufs: wb: Add explicit flush_threshold sysfs attribute
Date: Tue, 13 Jun 2023 07:03:51 -0700	[thread overview]
Message-ID: <488689a7-e68e-bd68-2cb2-f2f67baa176d@acm.org> (raw)
In-Reply-To: <20230613022240.16595-1-luhongfei@vivo.com>

On 6/12/23 19:22, Lu Hongfei wrote:
> +	/* The range of values for wb_flush_threshold is (0,10] */
> +	if (wb_flush_threshold > UFS_WB_BUF_REMAIN_PERCENT(100) ||
> +		wb_flush_threshold == 0) {

For future patches, please align split lines as is done elsewhere in the 
kernel. This means aligning "wb_flush_threshold == 0" with 
"wb_flush_threshold > ...". Anyway:

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply	other threads:[~2023-06-13 14:06 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-13  2:22 Lu Hongfei
2023-06-13 14:03 ` Bart Van Assche [this message]
2023-06-15  1:51 ` Martin K. Petersen
2023-06-22  1:26 ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=488689a7-e68e-bd68-2cb2-f2f67baa176d@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=dlunev@chromium.org \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=luhongfei@vivo.com \
    --cc=martin.petersen@oracle.com \
    --cc=opensource.kernel@vivo.com \
    --cc=peter.wang@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®