From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 462D3C77B72 for ; Mon, 17 Apr 2023 07:40:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbjDQHkd (ORCPT ); Mon, 17 Apr 2023 03:40:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230221AbjDQHkP (ORCPT ); Mon, 17 Apr 2023 03:40:15 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A1C9B44AF for ; Mon, 17 Apr 2023 00:39:41 -0700 (PDT) Received: from [IPV6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2] (unknown [IPv6:2001:b07:2ed:14ed:c5f8:7372:f042:90a2]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 993FE66031ED; Mon, 17 Apr 2023 08:39:39 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1681717180; bh=nfJnFA6ozqy7nT17maYMPunxHTfwoBhKeGFcQ+Uj5Q8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hMw+lqC/7vzygX0PTxg7wyItot6slBOu2uapMTb+eM0UHDDYpPos8JXblPp/5h5/k e/UqNBwwTtwEjJ6WAn0eeZwyrZxU9W8MB3eE0FX3YuFGgR9jnABdruC5Kt6GOz+RRU OnlgAgoc3s/bZhFgZr1RNQjuvtu0d0Bn62Ri0KcHt6M+VW9JwdCamopr4nEenzVHIy oCqM+o/urOtwfi2+vm/Ug4rsKbiQCCFWjyWwJ6SrvurHUivaldOgrpIot8eDgUv1m/ 63MdXdOAYjqWU/c+SNMil2yN4GsFzX3/eXglHtKbJS30TRHUEfv0Rb3UTxXrJAdTR/ 0SivOK3w9NM8Q== Message-ID: <488b6455-098e-ac7b-8996-53d782b5488f@collabora.com> Date: Mon, 17 Apr 2023 09:39:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v2 1/2] phy: mediatek: hdmi: mt8195: fix uninitialized variable usage in pll_calc Content-Language: en-US To: Guillaume Ranquet , Chun-Kuang Hu , Philipp Zabel , Chunfeng Yun , Vinod Koul , Kishon Vijay Abraham I , Matthias Brugger Cc: dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, kernel test robot References: <20230413-fixes-for-mt8195-hdmi-phy-v2-0-bbad62e64321@baylibre.com> <20230413-fixes-for-mt8195-hdmi-phy-v2-1-bbad62e64321@baylibre.com> From: AngeloGioacchino Del Regno In-Reply-To: <20230413-fixes-for-mt8195-hdmi-phy-v2-1-bbad62e64321@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 14/04/23 18:07, Guillaume Ranquet ha scritto: > The ret variable in mtk_hdmi_pll_calc() was used unitialized as reported > by the kernel test robot. > > Fix the issue by removing the variable altogether and testing out the > return value of mtk_hdmi_pll_set_hw() > > Fixes: 45810d486bb44 ("phy: mediatek: add support for phy-mtk-hdmi-mt8195") > Reported-by: kernel test robot > Signed-off-by: Guillaume Ranquet Reviewed-by: AngeloGioacchino Del Regno