From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BFC6F361DA5 for ; Fri, 6 Mar 2026 17:22:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772817746; cv=none; b=LtfyYM4hNm8iMJnoFh0RyL6RfM873JkWdaEARyGqS2eOq7dYFdilOx/kzH5SsXINFH32DyGJV23n9JmR7OVgLSRGHDa0vdKUjJl/2Ynyj92G51suq2b3MiHiO7FyFRnbc6fM21biCUSKSXhlA7LbM3GtxO5MSBDPKKbH53MEMCY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772817746; c=relaxed/simple; bh=xxB+8H55hbL/yjvhqnz15bcDlScKmxdX8S07eoZ8gKc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=NMUc2Gwh4zIAG8TjIQ519kX2oB7BbySmvtSEN0XGS26ZOaE/LhG8dsxO/hwFd9ZijiLGjHOoDBb3o8Mf99e87RnSqWVYVCQ+F4VgJJv8SYAoqU1V1LMwKdt+iEYGWuM4RhjtW3JQ47QjIlDg6VeaI0XCyx9wUTlTG0l+x1+NV8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=au0Yn6VX; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="au0Yn6VX" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-439c9eb5d36so3011756f8f.2 for ; Fri, 06 Mar 2026 09:22:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1772817743; x=1773422543; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YCiYsbFiG6El5+CfgRgDUsrrJZ9QgM65vIFR8M6oVrU=; b=au0Yn6VXmh/3GeqfKl4apMtNpJp0XpBswNmJxziLQVYxn5wnfW2+xemwWPQa5P+0gG LqtQWmeUH3q/+zTn7Me69tny7suju6D4+WyMJ4R0nuKXc0Pb96zc5enTtyI9Vxlpztid LR795Xzzb4As04AwHUFgucNfSHw3DF5+HvzRWv9dOVD/Lf0HsMVJsrsou8UCCT2bKBaF DYG2/IzepUKBa6RpzZBGZi80/d7GlVq2veF88uq8N5dailwBKE54cJqXCoPWKfamWelY kK6jkwoAic5nTSGbIbI2xZuljCmFo1oW6/g8xPWP+OtAwPrTR1qkC5aHmPXBmp+S+ErS lpEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772817743; x=1773422543; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=YCiYsbFiG6El5+CfgRgDUsrrJZ9QgM65vIFR8M6oVrU=; b=sbfvprvP3HEiVgb6g4HBq6qmUnZDjlbP2UM6nS/NYg0UEEcJ6A5D/m4k/yIYDJ+odh Pv0IgPskySsFTOaGnzFbgW93EE97RvWDIsd0nenLedXVwWfYCVkRacxi8JhpBTRwINMs Kp9vQOmPkzVes+MHgPZ2V2yMjKSb08CY8JoWvhrv+OTHe4l6JDi5RmjlWWvLLq9O2EoS kdqEYypNbuYC4FeqmAEDl8yNBUb8JWDqUqsn9YNvdXydPW4LlthkcUiNpAyBVXQL5Xrr ZBrsteBGIeEqJfqzOEN+l+/MpP9Pv4WxfamLw0mW1SA9cAxrCVoxVKuyheAS5UowD2Is 9IBA== X-Forwarded-Encrypted: i=1; AJvYcCXEKAy1xYU1AZqa/Qa1z04cCqUBNAmoDpjmAGppgOa2HvJ6+lhUC9wyAzXVJatZuaYx3NlfdZm0BPAgfaE=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5v7l6YreP0zpnhUej8WaxY8pum6u+YD/lyykI5inHZMuROj5v RjP6ifVIik5vFIgo3NVDv0+3QkrUSduSp6XOS6k7fCrLdckOJHTrjecxBfcpQ41cF60= X-Gm-Gg: ATEYQzyFjf9eVcJc0acwX9y/+9wgT8rA+lKN4iDT3LngaU7oLrTcvHkJWJu/Iq5xRX1 61YxTkUrAKufEpjBDL21SE9ox8Nywy2W6E7N3l0LizbcqTV7zgdzU/V1UoSYjTaxnFFNh2GfE8i 731czEoQSUOVgfbeun5l2rz/zTLotdo+D2+lfcuOVc+Oi9mEbSXzZSAyCbWVmjl4DcJ8r8dFvi0 QeWMWMAPOi1uWg8tKn9eNzBUVcamFh7PKSAVkUkfg6nFj4m3KZ7xk+6UvExSTYlduQAgvgNPLXJ R3GK8Aw2p1JteeYgXcXDHwfOyEg3Me/GBoAnXOfabelhccqsEZHXoMB4d6smIOkXjF/TgspbXot qb5VpO+NnfjQjZbSZnG/X26phdimwoE2BRuDHgnXx0xHrr+/dWAjb7Td7RsBsu3PUKMOuymtv2w pwyn11i+rAo7Xl67VIcMWys6nnkxnneuRcZYbxCJjuYWK7 X-Received: by 2002:a05:600c:548b:b0:483:78c7:e1c1 with SMTP id 5b1f17b1804b1-4852693046bmr52154805e9.12.1772817743033; Fri, 06 Mar 2026 09:22:23 -0800 (PST) Received: from [10.100.51.209] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4852ad0ce60sm30982035e9.12.2026.03.06.09.22.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 09:22:22 -0800 (PST) Message-ID: <488d93b9-d13c-4269-b7d5-ede1536f5701@suse.com> Date: Fri, 6 Mar 2026 18:22:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/8] rust: macros: add early_param support to module! macro To: Matthew Wood Cc: Miguel Ojeda , Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Boqun Feng , Gary Guo , =?UTF-8?Q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Danilo Krummrich , Tamir Duberstein , David Gow , =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= , linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260226234736.428341-1-thepacketgeek@gmail.com> <20260226234736.428341-7-thepacketgeek@gmail.com> Content-Language: en-US From: Petr Pavlu In-Reply-To: <20260226234736.428341-7-thepacketgeek@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/27/26 12:47 AM, Matthew Wood wrote: > Allow module parameters to be registered as early boot command-line > parameters via the existing __setup infrastructure. > > Add an optional `early_param` field to the parameter block in the > module! macro. When specified, the macro generates: > > - A setup callback that calls ModuleParam::from_setup_arg() and > stores the result via ModuleParamAccess::set_value(). > - A static string in .init.rodata with the command-line prefix. > - An ObsKernelParam entry in the .init.setup section linking the > two together. The early_param() macro on the C side creates an obs_kernel_param entry with early=1. However, this patch handles the new early_param setting in Rust by creating an obs_kernel_param with early=0. Non-early obs_kernel_params are processed by obsolete_checksetup() during the parse_args("Booting kernel") call in start_kernel(), which also handles regular kernel_params. Actual early parameters are handled by parse_early_param(). Note that the command line parsed in this case is marked as __initdata, so it would not be available for the kernel's entire lifetime, as the previous patches assume. So I'm somewhat confused by this patch, or perhaps I misunderstood something? > diff --git a/rust/macros/lib.rs b/rust/macros/lib.rs > index 0c36194d9971..83dcc89a425a 100644 > --- a/rust/macros/lib.rs > +++ b/rust/macros/lib.rs [...] > + #[link_section = ".init.setup"] > + #[used(compiler)] > + static #setup_name: ::kernel::module_param::ObsKernelParam = > + ::kernel::module_param::ObsKernelParam { > + str_: #setup_str_name.as_ptr().cast(), > + setup_func: ::core::option::Option::Some(#setup_fn_name), > + early: 0, > + }; -- Thanks, Petr