From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f228.google.com (mail-dy1-f228.google.com [74.125.82.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D7083EFD10 for ; Thu, 18 Jun 2026 10:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.228 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781779869; cv=none; b=dEleuOHRi8IeUyZKwD3Tv/gB2jyHtNsM0OoCDkZMmmRXhO/AgZk5BCDXWxfZ+sjpIOjfehlBZx7g8EgDf1fmG6s2s/L41aYkp99XvleCwZkCIOHCWEqrCaMFMzhP/J7nfYzGY1X5iulkBNXteVQmul6NAh1gfz5dz4TiqmJ8/4U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781779869; c=relaxed/simple; bh=cmuTSsCgNAJE4B9L+eGkzn08EDZSleRnAL/KhaOgNic=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HS2T1lo/OFoHu/ea+04o4qxvfdMM77qJMEZKBUfuiQo0HN12J9v+CaqwqnY7lJoJ46IvWjI5FJPM4Sk0HzjY5GqZdx63kkRFIwO/yPIXx9YhBSl8Fsb3grQoLg/Mk1k6ch6yuGWQkqLcdCoQWP/ysaW4ZXrJ1rHEP3/yQ6KdK1A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=VJct+FmF; arc=none smtp.client-ip=74.125.82.228 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="VJct+FmF" Received: by mail-dy1-f228.google.com with SMTP id 5a478bee46e88-30759632453so328014eec.1 for ; Thu, 18 Jun 2026 03:51:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781779862; x=1782384662; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=b+MRDwuUQuk4HJCf9ITWIh7vsEHgsSIvVGf6giRg95o=; b=NZV876jM+1tRr0u6MK4Rhwe2jKMFU8j1IeYi3Dv/iDlhqTNEJImRiHpcUwQbsgrEp8 rDJBbGUW8I93szS9MMXAEUHiEuYvg7wzDhElCVDqJPmOFjRIJyrIOz1p6bz4an2AUrBP HgrwqB+irexliHr0FvrCtQGZR87IyojPmGfgO8D/ojF3ZMQmiVQfnP0VU/2xRlBd0oJd DYmCJpr4FNXMoZJmjkD4jLWOC7N6lMgipN8ptKc8rt54d8ImSgzI6bqh5+CwUP0+e8X+ QS1NUI0Ffmuz3OQdQ5zPGTiMI56gvuG8tHbbVLJFUJ3PLTLwF47zfSuTtrPB/Ir8Vuqi ErfA== X-Forwarded-Encrypted: i=1; AFNElJ//XOP3NXD0TRNKs5vlSrpCJRmXOK78UVlFXRMyn+c1LHOrCUbJ4yPQ971fkW/uO+W8vLwV0DkreERzHF0=@vger.kernel.org X-Gm-Message-State: AOJu0YwEHK6Tx07pGvRwuUegK6rkSWlp2/yVYYtPoTyyUeT10JTjJmsz Wa5pESrLHlsuZOrAO0hi6g3nPmA7+2gWQUPpPURr9lkwyFCn9Xd3NbT7JR6LMOc40IGdp3YwQ7k rXt7Q3mTh8ZWnwi6bVpItqD227lryXLge4gUjchmuOvgf0Kupuai4SZhrQYns3vRGdJMzO4CMHj ny5kfHWarP+Nz4RwmFmHvCPEW5tiHNtrZCdjPexdNs4P0A9SFEQCmDxlxym5qz+BOigKuA64amA E3QJYn6QynWFN2qTQKCyLOhmUc= X-Gm-Gg: AfdE7cnJO5QTBlQTKyeTrJJf1UMfNuD9tODCdMS6I9roVQy70cUJINts5oed2bcmUqL QASE0pOUomQiWB9Pbz5wVLY84ZQevfxGuOOUX2DhVN8prFsMrxd7/fN49IsGSUxiAyigoPBdqV8 dl+GzrA5y5V5T5HiqGZY0uOi8QSAUnR+zUy7srBCEksBONPNYcJq5bhMnAOL98lEpYiP1UtzJDf Aap7YgqgdeFTldaZP5uqmc2Tp5taM6g12aA7e2UTfhqrPxDQjHxoM/H3FaLC1h8syFVq0pLYvcR pJsPHFkNl0Lo0ZlIzf0YVzf4TKgFxRlVdHh0BVzH8BRlIkqOps5teIKtFOl3NrjljNTrrviKAo3 Ojrpzxjh8yW2jjFbJNTpvIVakP6v4IRq4ukFZeBp8Hoy10n3iPdtZgtiSdY4W/D9/JYs2vVxHt8 3D+dZKr2BdgRg2nKwmWAYyVtXwfoBr8QZqD+UCIAfrVb2hZ+SwAQc= X-Received: by 2002:a05:7300:7483:b0:2f5:5dd3:1fcf with SMTP id 5a478bee46e88-30bc9ce3227mr5576436eec.10.1781779862192; Thu, 18 Jun 2026 03:51:02 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-23.dlp.protect.broadcom.com. [144.49.247.23]) by smtp-relay.gmail.com with ESMTPS id 5a478bee46e88-30bf444ad78sm118657eec.17.2026.06.18.03.51.01 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 18 Jun 2026 03:51:02 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-490bae3a39bso6448735e9.1 for ; Thu, 18 Jun 2026 03:51:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1781779860; x=1782384660; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=b+MRDwuUQuk4HJCf9ITWIh7vsEHgsSIvVGf6giRg95o=; b=VJct+FmFT/Zlv3JxVIZ5t4nzU/NUZahmsszY07Hj5KkAOsqmuBXKUNT5ts9rJQiJRV hircs/g71IqCLimId/x0gS4vf6wZbXQgFP3BQEMl9V1DIes/+W6y7D5RTHezg+IAkawB lZIVAmzxK4RI6/ItCl345lwur/8/pZ3CIyebA= X-Forwarded-Encrypted: i=1; AFNElJ8eTpMt+4lk1gk5LmNaLd2PwZAW2WMZqLgUz+jjLVKMMsOiaB4+3TlnEgX5od+jB0oQe/uDhI7xMPE8lbo=@vger.kernel.org X-Received: by 2002:a05:600c:34c9:b0:492:3346:e2c with SMTP id 5b1f17b1804b1-492341275d8mr107419145e9.23.1781779859724; Thu, 18 Jun 2026 03:50:59 -0700 (PDT) X-Received: by 2002:a05:600c:34c9:b0:492:3346:e2c with SMTP id 5b1f17b1804b1-492341275d8mr107418695e9.23.1781779859274; Thu, 18 Jun 2026 03:50:59 -0700 (PDT) Received: from [192.168.1.21] ([41.140.50.249]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4619fb12edbsm25700899f8f.17.2026.06.18.03.50.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 03:50:57 -0700 (PDT) Message-ID: <48910e5e-f694-4db4-87ea-da322b915b34@broadcom.com> Date: Thu, 18 Jun 2026 11:50:56 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/3] net: bcmgenet: collapse TX priority queues to a single queue To: Nicolai Buchwitz , Doug Berger , bcm-kernel-feedback-list@broadcom.com, Andrew Lunn , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Justin Chen , Ovidiu Panait , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260612205915.3156127-1-nb@tipi-net.de> <20260612205915.3156127-2-nb@tipi-net.de> Content-Language: en-US From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20260612205915.3156127-2-nb@tipi-net.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e On 6/12/2026 1:59 PM, Nicolai Buchwitz wrote: > The strict-priority TX queues can starve under multi-queue load and > trip NETDEV_WATCHDOG. Justin's earlier series [1] worked around the > symptom but kept the design. > > The multi-queue design was originally used for STB use cases that are > no longer needed, as confirmed by Justin. v1 hw_params already > exercises a single-queue path. Point v2-v4 at the same configuration: > ring 0 takes the full BD pool, every per-ring loop collapses to one > iteration, and netif_set_real_num_tx_queues drops to 1 via the > existing tx_queues + 1 arithmetic. > > Tested on Raspberry Pi CM4 (BCM2711). The baseline kernel trips > NETDEV_WATCHDOG within seconds under iperf3 UDP saturation > (-u -b0 -P16 -t60). After the change the same test completes > without a watchdog, and a single-stream 60 s UDP run sustains > 956 Mbit/s with 0/4952890 datagrams lost. Single-stream TCP > throughput is unchanged at 943 Mbit/s. > > [1] https://lore.kernel.org/netdev/20260406175756.134567-1-justin.chen@broadcom.com/ > > Signed-off-by: Nicolai Buchwitz Reviewed-by: Florian Fainelli -- Florian