From: Evgeniy Polyakov <zbr@ioremap.net>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ludek Hlavacek <ludek_h@seznam.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] w1: Drop owner assignment from i2c_driver
Date: Sat, 11 Jul 2015 17:41:36 +0300 [thread overview]
Message-ID: <4892291436625696@web27m.yandex.ru> (raw)
In-Reply-To: <1436510291-5732-1-git-send-email-k.kozlowski@samsung.com>
Hi Krzysztof
Patch looks good to me, thank you.
Greg, please pull it into your tree.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
10.07.2015, 09:38, "Krzysztof Kozlowski" <k.kozlowski@samsung.com>:
> i2c_driver does not need to set an owner because i2c_register_driver()
> will set it.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> ---
>
> The coccinelle script which generated the patch was sent here:
> http://www.spinics.net/lists/kernel/msg2029903.html
> ---
> drivers/w1/masters/ds2482.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c
> index a674409edfb3..b05e8fefbabd 100644
> --- a/drivers/w1/masters/ds2482.c
> +++ b/drivers/w1/masters/ds2482.c
> @@ -97,7 +97,6 @@ MODULE_DEVICE_TABLE(i2c, ds2482_id);
>
> static struct i2c_driver ds2482_driver = {
> .driver = {
> - .owner = THIS_MODULE,
> .name = "ds2482",
> },
> .probe = ds2482_probe,
> --
> 1.9.1
prev parent reply other threads:[~2015-07-11 14:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 6:38 Krzysztof Kozlowski
2015-07-11 14:41 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4892291436625696@web27m.yandex.ru \
--to=zbr@ioremap.net \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludek_h@seznam.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®