From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933016AbbFIStj (ORCPT ); Tue, 9 Jun 2015 14:49:39 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:58254 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754097AbbFIStT (ORCPT ); Tue, 9 Jun 2015 14:49:19 -0400 Date: Tue, 9 Jun 2015 20:49:14 +0200 (CEST) From: Stefan Wahren Reply-To: Stefan Wahren To: Mark Brown Cc: Joe Perches , Liam Girdwood , linux-kernel@vger.kernel.org, stable@vger.kernel.org Message-ID: <489276691.38639.1433875754470.JavaMail.open-xchange@oxbsltgw09.schlund.de> In-Reply-To: <20150609180028.GT14071@sirena.org.uk> References: <1433368589-16806-1-git-send-email-stefan.wahren@i2se.com> <20150609180028.GT14071@sirena.org.uk> Subject: Re: [PATCH V2] regulator: core: fix constraints debug output MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.2-Rev17 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:FypuKbRhpZjbGrYxRQMecgDX0/f1aqPtStnFsNO1PdieoeXir+H RH/QPnTw/mIJsk4XeHRDjn9tfwDGEsSFyfbp1p5vLU8XKDfA+D02Mn1Z+In0BV8OZntaGiI NUUIGde02qm3XZjUVECFeu+k9w4BBLlIpvlbbpcjyYaKVmp8jBvYX8bFzMBHtEe2o85pEix Vn2WfXJCOq+G/SfcOEtTw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Cn3Q5gcYp9U=:agHTbWFIOjXIb6Y24zHcGd idsjPQ0Hdyreic0J3fjHhgPIpChGyZuP6fUoSssmnEFe/Nl5xWgXE1lFmqWknq8x+VhMEQ5cE 1LWtqHJ+440+syclz4wpxcxhPoBpON/2NNgGQDSq4zhl7Er8gZhhR6F2VH8/jApLEeZ2QjGdw ao/0FTw1UklnM0ge4LqXJEKgfrsEG9aJhTjQFeLSBeJw+xCxzskpa7B3XzVT4ZWIqa4D++s+b 62reeV65rjV8LxnYatQBtR2+awmNqc/UlmfZw3+w6IB64PpWA25lRImoKSiMLhZi1wgEhvp0Y 0ceCQULXw7S1ztoVukfvFwL9aUY+t6gZqV3bEE0HSPkmtkC2LyqQqDN73rOWeieTP2beNQ/pZ AXSwvY9tFFqwyOEzD66PZLB9gweL3Z8t7vkKTt8EFev8gM8nfAo0JFuuOOs6UW+/xELfUqRKi WJEV999debrWP/3k8Cbgs/sMITQKxBHNfiZzgIXFKu/XlHc2El2XgMegK/neOoYVtzT4Cycg6 5tmwfk1lV1yG75qvrRwFWPvFEPuuLEkcm6lGF1sb4bly8WtddjcmxbPyN2hyXxEbc4XKcUmrO MdmJYgT439H01X8QjHuhzLDbyRnXSr67zS4WtQ7T49WuQ/O3tak6BcQSThaPqnweFBM9lzNZO D1CZEWqW3+Hl+Ki2Dy9WPCUzhigazqAty+WbjvoXrWAAvPg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Mark Brown hat am 9. Juni 2015 um 20:00 geschrieben: > > > On Wed, Jun 03, 2015 at 09:56:29PM +0000, Stefan Wahren wrote: > > The line buffer for constraints debug isn't big enough to hold the output > > in all cases. So fix the possible buffer overflow by the usage of the > > scnprintf(). > > If we know how much output we might produce then why not extend the > buffer so we don't need to cut it off? The defensive programming is > good but that seems a better fix. I thought the intension was to keep the output in "one" line. If not i suggest to increase the size to 160 bytes, which is sufficient for all cases.