Re: [PATCH 2/5] x86: Coding style fixes to arch/x86/kernel/bios_uv.c

[Stefan Richter <stefanr@s5r6.in-berlin.de>]

H. Peter Anvin wrote:
> Paolo Ciarrocchi wrote:
>>
>> diff --git a/arch/x86/kernel/bios_uv.c b/arch/x86/kernel/bios_uv.c
>> index c639bd5..100e759 100644
>> --- a/arch/x86/kernel/bios_uv.c
>> +++ b/arch/x86/kernel/bios_uv.c
>> @@ -25,11 +25,21 @@ x86_bios_strerror(long status)
>>  {
>>      const char *str;
>>      switch (status) {
>> -    case  0: str = "Call completed without error"; break;
>> -    case -1: str = "Not implemented"; break;
>> -    case -2: str = "Invalid argument"; break;
>> -    case -3: str = "Call completed with error"; break;
>> -    default: str = "Unknown BIOS status code"; break;
>> +    case  0:
>> +        str = "Call completed without error";
>> +        break;
>> +    case -1:
>> +        str = "Not implemented";
>> +        break;
>> +    case -2:
>> +        str = "Invalid argument";
>> +        break;
>> +    case -3:
>> +        str = "Call completed with error";
>> +        break;
>> +    default:
>> +        str = "Unknown BIOS status code";
>> +        break;
>>      }
>>      return str;
>>  }
> 
> This should be an array in the first place...

Besides, by following CodingStyle to the letter, it arguably breaks 
rather than fixes coding style.  The former code was easy enough to read.
-- 
Stefan Richter
-=====-==--- =--- ---==
http://arcgraph.de/sr/