mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Engraf <david.engraf@netcom.eu>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "Dasgupta, Romit" <romit@ti.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>, Greg KH <greg@kroah.com>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Linux-pm mailing list <linux-pm@lists.linux-foundation.org>
Subject: Re: [PATCH] [PM] Fixes missing PM entries in sysfs without CONFIG_PM_SLEEP
Date: Tue, 05 Aug 2008 16:45:43 +0200	[thread overview]
Message-ID: <48986797.5090007@netcom.eu> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0808051020220.2518-100000@iolanthe.rowland.org>

Is there an option to make a patch for the recent 2.6.26.1 kernel, so
that I can use the next 2.6.26.2 kernel instead of waiting a few months
for the next big release?

Thanks David Engraf


Alan Stern wrote:
> On Tue, 5 Aug 2008, Dasgupta, Romit wrote:
>
>   
>> A minor change below: Removed old goto label PMError and introduced SysFSError.
>> Tested with CONFIG_PM, CONFIG_PM_SLEEP, without CONFIG_PM and ofcourse with CONFIG_USB_SUSPEND. Works fine.
>>     
>
> Strictly speaking, I suppose the statement label should be 
> DPMSysfsError.
>
> On the other hand, the corresponding label for
> device_add_class_symlinks() is SymlinkError, not
> DeviceAddClassSymlinksError.  The label for device_add_attrs() is
> AttrsError, not DeviceAddAttrsError.  And the label for
> bus_add_device() is BusError, not BusAddDeviceError.
>
> Following those precedents, it seems appropriate that the label for
> dpm_sysfs_add() should be DPMError.  I'll make the change and submit
> the patch.
>
> Alan Stern
>
>   

  reply	other threads:[~2008-08-05 14:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <B85A65D85D7EB246BE421B3FB0FBB593013C91EE00@dbde02.ent.ti.com>
     [not found] ` <Pine.LNX.4.44L0.0808021944110.18555-100000@netrider.rowland.org>
2008-08-03 14:12   ` Dasgupta, Romit
2008-08-04 14:45     ` Alan Stern
2008-08-04 15:03       ` Rafael J. Wysocki
2008-08-04 15:14         ` Alan Stern
2008-08-04 15:24           ` Rafael J. Wysocki
2008-08-04 15:45             ` Alan Stern
2008-08-05  0:19               ` Dasgupta, Romit
2008-08-05 12:58                 ` David Engraf
2008-08-05 13:08                   ` Dasgupta, Romit
2008-08-05 14:26                 ` Alan Stern
2008-08-05 14:45                   ` David Engraf [this message]
2008-08-05 15:00                     ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48986797.5090007@netcom.eu \
    --to=david.engraf@netcom.eu \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=romit@ti.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®