From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Rusty Russell <rusty@rustcorp.com.au>
Subject: Re: [PATCH] Make kthread_stop() not oops when passed a bad pointer
Date: Tue, 05 Aug 2008 17:57:18 +0200 [thread overview]
Message-ID: <4898785E.1010702@s5r6.in-berlin.de> (raw)
In-Reply-To: <20080805135559.GQ26461@parisc-linux.org>
Matthew Wilcox wrote:
> --- a/kernel/kthread.c
> +++ b/kernel/kthread.c
> @@ -201,6 +201,9 @@ int kthread_stop(struct task_struct *k)
> {
> int ret;
>
> + if (!k || IS_ERR(k))
> + return -EINVAL;
> +
> mutex_lock(&kthread_stop_lock);
>
> /* It could exit after stop_info.k set, but before wake_up_process. */
Would
if (WARN_ON(!k || IS_ERR(k)))
be in order, or are there valid cases of passing an invalid pointer?
--
Stefan Richter
-=====-==--- =--- --=-=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-08-05 15:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 13:55 Matthew Wilcox
2008-08-05 15:57 ` Stefan Richter [this message]
2008-08-05 16:22 ` Andrew Morton
2008-08-06 5:42 ` [PATCH][migration] Trivial cleanup MinChan Kim
2008-08-06 14:25 ` Christoph Lameter
2008-08-06 1:22 ` [PATCH] Make kthread_stop() not oops when passed a bad pointer Rusty Russell
2008-08-06 12:07 ` Matthew Wilcox
2008-08-06 20:48 ` Rusty Russell
2008-08-08 20:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4898785E.1010702@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®