mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Philipp Kohlbecher <xt28@gmx.de>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: [PATCH] x86: fix comment in protected mode header
Date: Wed, 06 Aug 2008 15:25:26 +0200	[thread overview]
Message-ID: <4899A646.20205@gmx.de> (raw)

From: Philipp Kohlbecher <xt28@gmx.de>

Comments in arch/x86/boot/compressed/head_32.S erroneously refer to the 
real mode pointer as the second and the heap area as the third argument 
to decompress_kernel(). In fact, these have been the first and second 
argument, respectively, since v2.6.20.

This patch corrects the comments. It introduces no code changes.

Signed-off-by: Philipp Kohlbecher <xt28@gmx.de>

---

Please CC me, I am not on the list.

  arch/x86/boot/compressed/head_32.S |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/arch/x86/boot/compressed/head_32.S 
b/arch/x86/boot/compressed/head_32.S
index ba7736c..29c5fbf 100644
--- a/arch/x86/boot/compressed/head_32.S
+++ b/arch/x86/boot/compressed/head_32.S
@@ -137,14 +137,15 @@ relocated:
   */
  	movl output_len(%ebx), %eax
  	pushl %eax
+			# push arguments for decompress_kernel:
  	pushl %ebp	# output address
  	movl input_len(%ebx), %eax
  	pushl %eax	# input_len
  	leal input_data(%ebx), %eax
  	pushl %eax	# input_data
  	leal boot_heap(%ebx), %eax
-	pushl %eax	# heap area as third argument
+	pushl %eax	# heap area
-	pushl %esi	# real mode pointer as second arg
+	pushl %esi	# real mode pointer
  	call decompress_kernel
  	addl $20, %esp
  	popl %ecx


                 reply	other threads:[~2008-08-06 13:25 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4899A646.20205@gmx.de \
    --to=xt28@gmx.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®