From: Paulo Marques <pmarques@grupopie.com>
To: Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] kallsyms exclude local symbols
Date: Thu, 07 Aug 2008 13:00:05 +0100 [thread overview]
Message-ID: <489AE3C5.2000807@grupopie.com> (raw)
In-Reply-To: <87fxphzan5.wl%ysato@users.sourceforge.jp>
Yoshinori Sato wrote:
> h8300's nm output include '.Lfoo' local symbols.
> [...]
> /* exclude also MIPS ELF local symbols ($L123 instead of .L123) */
> - else if (str[0] == '$')
> + else if (str[0] == '$' || str[0] == '.')
The comment above needs some updating too. Something along these lines:
/* exclude also MIPS ELF local symbols (eg. $L123) and h8300 (eg .LM10) */
Other than that, the patch seems fine.
--
Paulo Marques - www.grupopie.com
"...so she told me it was either her or the ham radio, over."
next prev parent reply other threads:[~2008-08-07 12:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 4:55 Yoshinori Sato
2008-08-07 12:00 ` Paulo Marques [this message]
2008-08-07 23:36 ` [PATCH] exclude h8300 local symbols (Re: kallsyms exclude local symbols) Yoshinori Sato
2008-09-08 6:56 ` Andrew Morton
2008-09-08 19:20 ` Paulo Marques
2008-09-08 20:58 ` Yoshinori Sato
2008-09-08 23:39 ` Hugh Dickins
2008-09-09 3:07 ` Yoshinori Sato
2008-09-12 19:28 ` Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489AE3C5.2000807@grupopie.com \
--to=pmarques@grupopie.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome