From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: jmerkey@wolfmountaingroup.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] mdb-2.6.27-rc2-ia32-08-07-08.patch
Date: Thu, 07 Aug 2008 18:46:40 +0200 [thread overview]
Message-ID: <489B26F0.3030603@s5r6.in-berlin.de> (raw)
In-Reply-To: <1923.69.2.248.210.1218124570.squirrel@webmail.wolfmountaingroup.com>
jmerkey@wolfmountaingroup.com wrote:
> rspin locks are for these types of cases -- so if I fault on the same
> processor I took the lock on it just bumps a counter -- yes, it is atomic
> and SMP safe to do it this way.
Only if all contexts which take rlocks are not preemptible. Which I
don't know whether they are; I'm just a driver guy. You use
spin_lock_irqsave() rather than plain spin_lock() though, which
indicates that you want to be able to take the locks from preemptible
contexts too. In that case, your accessors are subtly buggy.
--
Stefan Richter
-=====-==--- =--- --===
http://arcgraph.de/sr/
next prev parent reply other threads:[~2008-08-07 16:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 14:29 jmerkey
2008-08-07 15:49 ` Stefan Richter
2008-08-07 15:59 ` Stefan Richter
2008-08-07 15:56 ` jmerkey
2008-08-07 16:46 ` Stefan Richter [this message]
2008-08-07 16:33 ` jmerkey
2008-08-07 17:19 ` Stefan Richter
2008-08-07 17:33 ` Stefan Richter
2008-08-07 17:52 ` jmerkey
2008-08-07 17:52 ` jmerkey
2008-08-07 16:04 ` jmerkey
2008-08-09 5:07 ` Jeremy Fitzhardinge
2008-08-09 8:04 ` Stefan Richter
2008-08-09 14:44 ` jmerkey
2008-08-08 2:18 ` Parag Warudkar
2008-08-08 4:33 Parag Warudkar
2008-08-08 13:11 ` jmerkey
[not found] ` <37357.166.70.238.45.1218201115.squirrel@webmail.wolfmountaingroup.com >
2008-08-08 13:23 ` jmerkey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489B26F0.3030603@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=jmerkey@wolfmountaingroup.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®