From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965747AbcCOSa2 (ORCPT ); Tue, 15 Mar 2016 14:30:28 -0400 Received: from vulcan.natalenko.name ([104.207.131.136]:28778 "EHLO vulcan.natalenko.name" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965568AbcCOSaZ (ORCPT ); Tue, 15 Mar 2016 14:30:25 -0400 DMARC-Filter: OpenDMARC Filter v1.3.1 vulcan.natalenko.name E9CDFA808E Authentication-Results: vulcan.natalenko.name; dmarc=none header.from=natalenko.name MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 15 Mar 2016 20:30:19 +0200 From: Oleksandr Natalenko To: Lee Jones Cc: Ben Hutchings , Wolfram Sang , Roger Tseng , linux-kernel@vger.kernel.org Subject: [RFC][PATCH] rtsx_usb_ms: Use msleep_interruptible() in polling loop Organization: pf-kernel developing community Message-ID: <489b0107c6a086e82f8eb17c0f64e0d0@natalenko.name> User-Agent: Roundcube Webmail/1.2-beta Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This patch has already been posted to LKML by Ben Hutchings ~5 months ago, but AFAIK no further action were performed. However, this patch really fixes weird loadavg with RTS5129 card reader, so I would wonder if this could be merged. AFAIK, it has been applied to some distros' kernels, e.g., Ubuntu. Original Ben's message goes below. rtsx_usb_ms creates a task that mostly sleeps, but tasks in uninterruptible sleep still contribute to the load average (for bug-compatibility with Unix). A load average of ~1 on a system that should be idle is somewhat alarming. Change the sleep to be interruptible, but still ignore signals. A better fix might be to replace this loop with a delayed work item. References: https://bugs.debian.org/765717 Signed-off-by: Ben Hutchings Signed-off-by: Oleksandr Natalenko --- drivers/memstick/host/rtsx_usb_ms.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/memstick/host/rtsx_usb_ms.c b/drivers/memstick/host/rtsx_usb_ms.c index 1105db2..645dede 100644 --- a/drivers/memstick/host/rtsx_usb_ms.c +++ b/drivers/memstick/host/rtsx_usb_ms.c @@ -706,7 +706,8 @@ poll_again: if (host->eject) break; - msleep(1000); + if (msleep_interruptible(1000)) + flush_signals(current); } complete(&host->detect_ms_exit); -- 2.7.3