From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 849713A5E88 for ; Mon, 3 Aug 2026 06:36:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738972; cv=none; b=SGB9mewmiPWvJsP1O3uDoACKjYN+1xRn4wJwljYrhM/OHNQMKv8FW1FgAlyx5cpGh0KaG68b7KPeJiqEI9UcF9YyK0z7yS8p8/JMIVs+aa2sJun9AI/icj2TTJHbZHHEZoMSRCga5zIeV59SceUXwyj4NB61jqbEu+J5/5ydkzU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785738972; c=relaxed/simple; bh=GFfKWnJCeRvb8L7n1H72YNMWOwBZb330igAaUIOgIE4=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=jbaBay8zfCteaMAsX+i3oyWfiglOiZlYOG9CeYlGXzUt8pxYHfQKtWNI4EcsO3Jg+id4VMsfXz/Ui5y72LityhdVIjBiWZ0JUDH/jGGcpiDVYvOHInV2Tc/u5iCE/DxCrf2l9ld+iCz7/FXUOF2nkwTk3y7Lmt9Czj5/lySTbYM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=UD8tZZPK; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=O4uAjISJ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="UD8tZZPK"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="O4uAjISJ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785738969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=j97nUM679ILSO2OJT5uVm1JNmnswxH5ehx4we/pp/9A=; b=UD8tZZPKENZIcklv6ifQM6cCt7jiFoxR0tmVrMwTfT4Ql9TvZ5DkToPLxu6EsvltwBAY03 LIHT1AoU5ge2792O+iDqyWZQez1wtnY0E2ma+TI12OdfpS3KLlxuMm5oi8XDuEjCCjLlXb 6MRW3jrtZu+PeBmH2AQ3H7Dy9ZT8JZI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-128-S8E6hTWnPkeolRvczIZ-sg-1; Mon, 03 Aug 2026 02:35:56 -0400 X-MC-Unique: S8E6hTWnPkeolRvczIZ-sg-1 X-Mimecast-MFC-AGG-ID: S8E6hTWnPkeolRvczIZ-sg_1785738955 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-47f726186c4so2179816f8f.2 for ; Sun, 02 Aug 2026 23:35:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785738955; x=1786343755; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :from:to:cc:subject:date:message-id:reply-to:content-type; bh=j97nUM679ILSO2OJT5uVm1JNmnswxH5ehx4we/pp/9A=; b=O4uAjISJ25axeWfzEPHSApnUCQZu5wtVB235zCHHKjmo70B7nMXpf4P+SmX15Qdh8W 6kAh3P3gqISN42Z2L2hKfmAafVuLOltGA8znznnghEdX2JkSXUVH3OvyqyaS64BrCnFa U6mevUMEnWmljG+zpAM5erWJ5xxIwO1ah/VOCNN7eaWPba0/VSXdALqffxCeZb9rYRVa lYSfKVi6KYC4jcnKifLkC2n9q3Etgcv+b2AUz11tvd0SUJXaRaWyk0isuuuWPAHy0NWC h8xtW6nY8AtFgngefbQhooWPWRJBFOYn5ZUGaRqg0XkMCCFMq+KliJGLd+W8pOOUiWLc p+fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785738955; x=1786343755; h=mime-version:user-agent:content-transfer-encoding:content-type :autocrypt:references:in-reply-to:date:cc:to:from:subject:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=j97nUM679ILSO2OJT5uVm1JNmnswxH5ehx4we/pp/9A=; b=mJMfQx1yb44PszB6jQccJbrsmG3SO7QpoEh2WKFXVCy0DPUn4pUXZMGPWyzE85vFN2 y8oiQMMfRzBQdkSR+ZSdvcdYfn4MV4sTif5vCifI+c8fE8n408sc6tgVekAWDoUK+Pp5 yxPOoIJXoZ+P7UdMhNkcac6PI/55SgF3RIX/aAszk5Th360G4hWYYyX7ekrc8hhbvxU/ 3fqYeX8QC91y15RX0O2koxIYxCEXRfeBcO1VYDbZ/jNgX0FElwMdJG74a8+Sc6ZJubWB XOoKMjxjvxCXh3N5M//qCORGvTyDjkdMn7zuljJTXPhbDlhn+rhI4QYAyb2aTvMPW2Kx Z4Vg== X-Forwarded-Encrypted: i=1; AHgh+Ro0vnyFxQmD7SQtXOb1RyvCw3TvrEJmR8zqwpM+aVTiB4P4Rgf+vGXkDClgjlWrInKmILgGMzK2xvkXsGg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxqa7zh2pWGh3/OvcMDU80IgujRqmaH8s7zstA8p5KdYYWWRBnr LlgY6t8pNR+4GyoyGgxHxizC8+YGfV00dYdQ4H7JpTkg5SZvA0zaSjNK33VSbS12xtQa/Cvq4jY LlTnsEGhncMW+LIUdQ2l11KcBjh841jvgX/lfG3N6ga+pNbLbTfZ/ydxjW01nCpoABA== X-Gm-Gg: AR+sD12sOesGVwjuqsV77ZF+RUnGDFCRKW8YBAySOJrhGdnbXnARP1yFsjp0RLbmq95 LY3OxMvMEoUcUO1c64bMZMnSiBO3q53TPgvAYGx73TWYR9Uk+JrV0lv8HZyZyLy6fyefFNnEqdK SWuytprKf/8qUT0qAH9Z6Y4gTtEVo8R7vYYZXJahtfvBpbBX8eJvVWgc7Y/CE9tSDk4X2EtWr9y aR62zHuugvKbfHD5QGFuJmEmbdu9Su7QXZgBRikBe1xqp3JIQnlRd+rREA1enXWD5XWbO8qbrpi MUGvhSaPoSzmSkgo5Tu6JGLRxuJvR2gLABIBE0fAxzIlUHhHwj/cq7sIuhQsmLFzjZZt06rXM1l IERrO5zoC51SW6qaqjHeRLUAAloGD X-Received: by 2002:a5d:46c1:0:b0:47f:8b9e:f457 with SMTP id ffacd0b85a97d-47fd72b0552mr15007961f8f.17.1785738955067; Sun, 02 Aug 2026 23:35:55 -0700 (PDT) X-Received: by 2002:a5d:46c1:0:b0:47f:8b9e:f457 with SMTP id ffacd0b85a97d-47fd72b0552mr15007927f8f.17.1785738954669; Sun, 02 Aug 2026 23:35:54 -0700 (PDT) Received: from gmonaco-thinkpadt14gen3.rmtit.csb ([185.168.96.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47fd41cf404sm29281638f8f.1.2026.08.02.23.35.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Aug 2026 23:35:54 -0700 (PDT) Message-ID: <489b764f5add05c08a468dca02b6c0f0d8197a90.camel@redhat.com> Subject: Re: [PATCH v2 2/4] rv/reactors: propagate rv_register_reactor() error from reactor init From: Gabriele Monaco To: wen.yang@linux.dev Cc: Nam Cao , linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 03 Aug 2026 08:35:53 +0200 In-Reply-To: <76b672af7c3eed78582ae90fcbf4736a76783df5.1785695669.git.wen.yang@linux.dev> References: <76b672af7c3eed78582ae90fcbf4736a76783df5.1785695669.git.wen.yang@linux.dev> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.60.2 (3.60.2-1.fc44) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-08-03 at 02:43 +0800, wen.yang@linux.dev wrote: > From: Wen Yang >=20 > Both register_react_printk() and register_react_panic() ignore the > return value of rv_register_reactor() and always return 0.=C2=A0 If the > registration fails (e.g. a duplicate reactor name), the init functions > silently report success even though the reactor was not registered. >=20 > Propagate the error from rv_register_reactor() so a failed registration > is reported instead of being silently ignored. Reviewed-by: Gabriele Monaco >=20 > Suggested-by: Gabriele Monaco > Signed-off-by: Wen Yang > --- > =C2=A0kernel/trace/rv/reactor_panic.c=C2=A0 | 3 +-- > =C2=A0kernel/trace/rv/reactor_printk.c | 3 +-- > =C2=A02 files changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/kernel/trace/rv/reactor_panic.c b/kernel/trace/rv/reactor_pa= nic.c > index 76537b8a4343..db7116ceafff 100644 > --- a/kernel/trace/rv/reactor_panic.c > +++ b/kernel/trace/rv/reactor_panic.c > @@ -26,8 +26,7 @@ static struct rv_reactor rv_panic =3D { > =C2=A0 > =C2=A0static int __init register_react_panic(void) > =C2=A0{ > - rv_register_reactor(&rv_panic); > - return 0; > + return rv_register_reactor(&rv_panic); > =C2=A0} > =C2=A0 > =C2=A0static void __exit unregister_react_panic(void) > diff --git a/kernel/trace/rv/reactor_printk.c > b/kernel/trace/rv/reactor_printk.c > index 48c934e315b3..002a10f6aa7b 100644 > --- a/kernel/trace/rv/reactor_printk.c > +++ b/kernel/trace/rv/reactor_printk.c > @@ -25,8 +25,7 @@ static struct rv_reactor rv_printk =3D { > =C2=A0 > =C2=A0static int __init register_react_printk(void) > =C2=A0{ > - rv_register_reactor(&rv_printk); > - return 0; > + return rv_register_reactor(&rv_printk); > =C2=A0} > =C2=A0 > =C2=A0static void __exit unregister_react_printk(void)