From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92ECB147C7D for ; Tue, 16 Jul 2024 08:47:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721119652; cv=none; b=oxxCQfQlo0BKFDBFk55CM377IlUq4o1ovX7R70BSAcg4g9C0CXZScDHc+G9PSM1kOl1/fwLUZQv6g3cUy2qa56KYXT7+vbv1SAqRvlul5AqveWGPnPxISB02SQZGRcHVoryhm7nIxtxTFcmjJNu2suET6dtqmZPTQ4dLBjMZgcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1721119652; c=relaxed/simple; bh=c4erRTdFplUVeHe4jpoOM8K/0mISg3+RT23JsUTBU+M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=DZ9VS2STj7mAQ69MthpcfCHy7Hs/T2j6wWteRnJ+jV2ekZYN0zZZCGqin5Nrlu7e+EF1nOuSMNcFO/5wOlfl9ziqv5GdUUIgQvYjnQAN6JXVS7Jx4aTppRtmO7oP9CyNc4Vbar5r04Lbc9NkpBMIC8a6shJArBPMAAXCZ677KEM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Jce51NNR; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Jce51NNR" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1721119649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=crDBCxIFGRc2BYULIH2EJGJ3gLrx1/8/kRZTfiMWf7c=; b=Jce51NNRPSvmNnMQUzoPmbcX7q8ql5kp7XCG1MPvQEz3wgJAx/2Qv+F4Z85taar89Ll8GK DkaKyzfKyhbUxz+bQL6iRHyVOrcyaQkjjT8yPqti/3MlXCimFJ6Qmm9XU08zEK6T5NE8Si P9abbuVDTVvetKmbZPncl+joRVcfcI8= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-558-GpnfUSMcP_GMOiJLCgYutA-1; Tue, 16 Jul 2024 04:47:27 -0400 X-MC-Unique: GpnfUSMcP_GMOiJLCgYutA-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3678c35e69bso56009f8f.0 for ; Tue, 16 Jul 2024 01:47:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721119646; x=1721724446; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=crDBCxIFGRc2BYULIH2EJGJ3gLrx1/8/kRZTfiMWf7c=; b=f3m2jGRq2m4nrsAtas3t9x45W3+c3wbHCQefHyfS+k39IY3QJvRr4L1n74ba6naLqD MaL4Tme3USibBOZt1iKOuvisKAdydGBQpVT53FUHu4FaOhnfFn+g5qNv7fVwf0NIku67 Qel0BDHjUPfPmHcqqjZlJ2gld2oPotZnXZ9z9Rb+vDwi+QmvWEzjUnepSNFzPNzgtdqK Y0o7nVczdMfJIb867yb/ymUC1xnkNMTM6RBgM/VWZs1ByFeu6QQg0eRtHINa1TKGswzl m3lKVjwzgpzpnbIUIMJBm1DznON1pVfzFA4gMJWDks+8JJC0SZQx2dOtgNPkGDjpouiL GLDg== X-Forwarded-Encrypted: i=1; AJvYcCW4Yjs+3CpPH1VARU8jM6nLFnh6IXi9QeP6EUAt1KOX54KBgR4+1XYS9KQv4X+s73pL3jXHaDa+gTksJ0Xi3P3eDlL5LEhXNgu3QJ2E X-Gm-Message-State: AOJu0YyJYtwh4teea0Nt1/IZEYomZ/6CbAtF526jWsQsT8JymIT0sJE5 YP+Nxg/uaqAMJ0bNU2F7PawP+1msN3F6lC6/gz6zTaEcWJgSRljcraUKE3MgBJP+JhpFu04ZLEM 3dMORpq7WvB6sFPLAN+F9W58cF3dGMBfrB0cmSdmG2q8UEdTvOcy9yoyqwlBuRA== X-Received: by 2002:a05:600c:3ba4:b0:426:4920:2846 with SMTP id 5b1f17b1804b1-427b88ce8edmr9293595e9.3.1721119646689; Tue, 16 Jul 2024 01:47:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH6rQx1hBFnFYexTWpYbB/AkzYaZwA7flJDCAawbmUGBdGsvrkFQkbKmHEDzaXLz7ure/UvMA== X-Received: by 2002:a05:600c:3ba4:b0:426:4920:2846 with SMTP id 5b1f17b1804b1-427b88ce8edmr9293335e9.3.1721119646270; Tue, 16 Jul 2024 01:47:26 -0700 (PDT) Received: from ?IPV6:2a0d:3344:1738:5210:e05b:d4c9:1ad4:1bd3? ([2a0d:3344:1738:5210:e05b:d4c9:1ad4:1bd3]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-427a5e93c92sm117370435e9.22.2024.07.16.01.47.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jul 2024 01:47:25 -0700 (PDT) Message-ID: <489bff95-5b5a-447f-82c0-9d724bc9d1b1@redhat.com> Date: Tue, 16 Jul 2024 10:47:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 13/15] net: jme: Convert tasklet API to new bottom half workqueue mechanism To: Allen Cc: kuba@kernel.org, Guo-Fu Tseng , "David S. Miller" , Eric Dumazet , jes@trained-monkey.org, kda@linux-powerpc.org, cai.huoqing@linux.dev, dougmill@linux.ibm.com, npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, nnac123@linux.ibm.com, tlfalcon@linux.ibm.com, marcin.s.wojtas@gmail.com, mlindner@marvell.com, stephen@networkplumber.org, nbd@nbd.name, sean.wang@mediatek.com, Mark-MC.Lee@mediatek.com, lorenzo@kernel.org, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, borisp@nvidia.com, bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, louis.peens@corigine.com, richardcochran@gmail.com, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acenic@sunsite.dk, linux-net-drivers@amd.com, netdev@vger.kernel.org References: <20240621050525.3720069-1-allen.lkml@gmail.com> <20240621050525.3720069-14-allen.lkml@gmail.com> <7348f2c9f594dd494732c481c0e35638ae064988.camel@redhat.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/15/24 19:50, Allen wrote: > Thank you very much. Will send out v3 later today with these changes. > Note, it will be as follows, enable_work() does not have workqueue type. > > + if (jme->rxempty_bh_work_queued) > + enable_and_queue_work(system_bh_wq, &jme->rxempty_bh_work); > + else > - enable_work(system_bh_wq, &jme->rxempty_bh_work); > + enable_work(&jme->rxempty_bh_work); Yup, sorry I was very hasty. More important topic: net-next is currently closed for the merge window, You will have to wait to post the new revision of this series until we re-open net-next in ~2w. Thanks, Paolo