mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jelle van der Waa <jelle@vdwaa.nl>
To: "Rong Zhang" <i@rong.moe>, "Ike Panhc" <ikepanhc@gmail.com>,
	"Mark Pearson" <mpearson-lenovo@squebb.ca>,
	"Derek J. Clark" <derekjohn.clark@gmail.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] platform/x86: ideapad-laptop: Add charge_types:Fast (Rapid Charge)
Date: Thu, 6 Nov 2025 13:59:25 +0100	[thread overview]
Message-ID: <489d1b5f-4177-4a8a-855c-adc65f794177@vdwaa.nl> (raw)
In-Reply-To: <20251105182832.104946-5-i@rong.moe>

On 05/11/2025 19:28, Rong Zhang wrote:
> The GBMD/SBMC interface on recent devices supports Rapid Charge mode
> (charge_types: Fast) in addition to Conservation Mode (charge_types:
> Long_Life).
> 
> Query the GBMD interface on probe to determine if a device supports
> Rapid Charge. If so, expose these two modes while carefully maintaining
> their mutually exclusive state, which aligns with the behavior of
> manufacturer utilities on Windows.
> 
> Signed-off-by: Rong Zhang <i@rong.moe>
> Acked-by: Ike Panhc <ikepanhc@gmail.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> Changes in v2:
> - Only expose Rapid Charge on devices that support it (thanks Jelle van
>    der Waa)
> - Reword commit message
> ---
<snip>

Tested on my U330p and it doesn't expose the "Fast" charge type as expected.

You can add Tested-By: Jelle van der Waa <jelle@vdwaa.nl>

Thanks,

Jelle van der Waa

  reply	other threads:[~2025-11-06 12:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 18:28 [PATCH v2 0/4] " Rong Zhang
2025-11-05 18:28 ` [PATCH v2 1/4] platform/x86: ideapad-laptop: Use str_on_off() helper Rong Zhang
2025-11-05 18:28 ` [PATCH v2 2/4] platform/x86: ideapad-laptop: Protect GBMD/SBMC calls with mutex Rong Zhang
2025-11-05 18:28 ` [PATCH v2 3/4] platform/x86: ideapad-laptop: Support multiple power_supply_ext definitions Rong Zhang
2025-11-05 18:28 ` [PATCH v2 4/4] platform/x86: ideapad-laptop: Add charge_types:Fast (Rapid Charge) Rong Zhang
2025-11-06 12:59   ` Jelle van der Waa [this message]
2025-11-10 12:00 ` [PATCH v2 0/4] " Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489d1b5f-4177-4a8a-855c-adc65f794177@vdwaa.nl \
    --to=jelle@vdwaa.nl \
    --cc=derekjohn.clark@gmail.com \
    --cc=hansg@kernel.org \
    --cc=i@rong.moe \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpearson-lenovo@squebb.ca \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®