mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luke Yang <luke.adi@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Two bugs in kernel 2.6.15-rc5
Date: Wed, 14 Dec 2005 10:37:36 +0800	[thread overview]
Message-ID: <489ecd0c0512131837p654b7d8bqd63cd3342542d1da@mail.gmail.com> (raw)

Hi all,

   During porting Blackfin architecture to latest kernel, I found two issues:

 1. kernel/futex.c invokes handle_mm_fault() function, which calls
__handle_mm_fault(). But __handle_mm_fault() is defined in
mm/memory.c, which is only compiled when CONFIG_MMU is defined. So
those without MMUs can not use futex any more.

   How do you think this shall be fixed? Use #ifdef CONFIG_MMU ... #endif?

 2. In include/linux/module.h, "__crc_" and "__ksymtab_" are hard
coded to be the   prefix for some kinds of symbols (CRC symbol and
ksymtab section). But in script /mod/modpost.c,
MODULE_SYMBOL_PREFIX##"__crc_" is used as the prefix to search CRC
symbols. So if an architecture (such as h8300 or Blackfin) defines
MODULE_SYMBOL_PREFIX as not NULL ("_"), modpost will always warn about
"no invalid crc".

   I think we can just remove the MODULE_SYMBOL_PREFIX from  CRC_PFX
and  KSYMTAB_PFX in modpost.c. If you agree, I can send a patch for
this.

Best regards,
Luke Yang
Analog Device Inc.

             reply	other threads:[~2005-12-14  2:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-14  2:37 Luke Yang [this message]
2005-12-17 20:36 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=489ecd0c0512131837p654b7d8bqd63cd3342542d1da@mail.gmail.com \
    --to=luke.adi@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®