From: "Luke Yang" <luke.adi@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix undefined symbols for nommu architecture --improved version
Date: Mon, 20 Feb 2006 15:40:08 +0800 [thread overview]
Message-ID: <489ecd0c0602192340h710b5807r4bc3e66b25c59bd9@mail.gmail.com> (raw)
In-Reply-To: <20060219223944.1a70aee1.akpm@osdl.org>
Hi,
This is renewed patch. Tested on Blackfin platform.
Signed-off-by: Luke Yang <luke.adi@gmail.com>
Index: git/linux-2.6/mm/nommu.c
===================================================================
--- git.orig/linux-2.6/mm/nommu.c 2006-02-20 12:33:25.000000000 +0800
+++ git/linux-2.6/mm/nommu.c 2006-02-20 15:12:08.000000000 +0800
@@ -57,6 +57,8 @@
EXPORT_SYMBOL(vfree);
EXPORT_SYMBOL(vmalloc_to_page);
EXPORT_SYMBOL(vmalloc_32);
+EXPORT_SYMBOL(vmap);
+EXPORT_SYMBOL(vunmap);
/*
* Handle all mappings that got truncated by a "truncate()"
Index: git/linux-2.6/include/linux/mm.h
===================================================================
--- git.orig/linux-2.6/include/linux/mm.h 2006-02-20 15:25:21.000000000 +0800
+++ git/linux-2.6/include/linux/mm.h 2006-02-20 15:26:24.000000000 +0800
@@ -1051,7 +1051,11 @@
void drop_pagecache(void);
void drop_slab(void);
+#ifndef CONFIG_MMU
+#define randomize_va_space 0
+#else
extern int randomize_va_space;
+#endif
#endif /* __KERNEL__ */
#endif /* _LINUX_MM_H */
Index: git/linux-2.6/kernel/sysctl.c
===================================================================
--- git.orig/linux-2.6/kernel/sysctl.c 2006-02-20 15:26:47.000000000 +0800
+++ git/linux-2.6/kernel/sysctl.c 2006-02-20 15:27:22.000000000 +0800
@@ -638,6 +638,7 @@
.proc_handler = &proc_dointvec,
},
#endif
+#if defined(CONFIG_MMU)
{
.ctl_name = KERN_RANDOMIZE,
.procname = "randomize_va_space",
@@ -646,6 +647,7 @@
.mode = 0644,
.proc_handler = &proc_dointvec,
},
+#endif
#if defined(CONFIG_S390) && defined(CONFIG_SMP)
{
.ctl_name = KERN_SPIN_RETRY,
On 2/20/06, Andrew Morton <akpm@osdl.org> wrote:
> "Luke Yang" <luke.adi@gmail.com> wrote:
> >
> > Index: git/linux-2.6/mm/nommu.c
> > ===================================================================
> > --- git.orig/linux-2.6/mm/nommu.c 2006-02-17 17:40:34.000000000 +0800
> > +++ git/linux-2.6/mm/nommu.c 2006-02-20 12:09:32.000000000 +0800
> > @@ -57,7 +57,10 @@
> > EXPORT_SYMBOL(vfree);
> > EXPORT_SYMBOL(vmalloc_to_page);
> > EXPORT_SYMBOL(vmalloc_32);
> > +EXPORT_SYMBOL(vmap);
> > +EXPORT_SYMBOL(vunmap);
> >
> > +#define randomize_va_space 0
> > /*
> > * Handle all mappings that got truncated by a "truncate()"
> > * system call.
>
> That can't be right - the #define should be in a header file - mm.h:
>
> #ifdef CONFIG_NOMMU
> #define randomize_va_space 0
> #else
> extern int randomize_va_space;
> #endif
>
> Are you sure you test-compiled this?
Sorry, nommu.c was compiled but the error still exists at the end of
compilation. This time it is right.
>
--
Best regards,
Luke Yang
magic.yyang@gmail.com; luke.adi@gmail.com
next prev parent reply other threads:[~2006-02-20 7:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-20 6:33 Luke Yang
2006-02-20 6:39 ` Andrew Morton
2006-02-20 7:40 ` Luke Yang [this message]
2006-02-20 10:35 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489ecd0c0602192340h710b5807r4bc3e66b25c59bd9@mail.gmail.com \
--to=luke.adi@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®