From: "Luke Yang" <luke.adi@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Replace "vmalloc_node" with "vmalloc" for no-mmu architectures in oprofile driver
Date: Tue, 28 Feb 2006 11:45:43 +0800 [thread overview]
Message-ID: <489ecd0c0602271945g1a4963c6kb7de7c6b0df90a07@mail.gmail.com> (raw)
In-Reply-To: <20060227193322.7a78c585.akpm@osdl.org>
On 2/28/06, Andrew Morton <akpm@osdl.org> wrote:
> You wanted CONFIG_MMU there.
Yes.
>
> A better fix is to provide vmalloc_node() on nommu architectures. COuld you
> compile-test this please?
Tested. Then my patch is obsolete. Thanks!
>
> --- devel/mm/nommu.c~nommu-implement-vmalloc_node 2006-02-27 19:30:47.000000000 -0800
> +++ devel-akpm/mm/nommu.c 2006-02-27 19:31:53.000000000 -0800
> @@ -53,7 +53,6 @@ DECLARE_RWSEM(nommu_vma_sem);
> struct vm_operations_struct generic_file_vm_ops = {
> };
>
> -EXPORT_SYMBOL(vmalloc);
> EXPORT_SYMBOL(vfree);
> EXPORT_SYMBOL(vmalloc_to_page);
> EXPORT_SYMBOL(vmalloc_32);
> @@ -205,6 +204,13 @@ void *vmalloc(unsigned long size)
> {
> return __vmalloc(size, GFP_KERNEL | __GFP_HIGHMEM, PAGE_KERNEL);
> }
> +EXPORT_SYMBOL(vmalloc);
> +
> +void *vmalloc_node(unsigned long size, int node)
> +{
> + return vmalloc(size);
> +}
> +EXPORT_SYMBOL(vmalloc_node);
>
> /*
> * vmalloc_32 - allocate virtually continguos memory (32bit addressable)
> _
>
>
--
Best regards,
Luke Yang
magic.yyang@gmail.com; luke.adi@gmail.com
prev parent reply other threads:[~2006-02-28 3:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 3:20 Luke Yang
2006-02-28 3:33 ` Andrew Morton
2006-02-28 3:45 ` Luke Yang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=489ecd0c0602271945g1a4963c6kb7de7c6b0df90a07@mail.gmail.com \
--to=luke.adi@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®