Dave Chinner wrote: > On Mon, Aug 18, 2008 at 06:53:51PM -0700, Kevin Diggs wrote: > >>Could someone ... anyone take a look at these kernel doc additions? > > ..... > >>+/** >>+ * complete: - signals a single thread waiting on this completion >>+ * @x: holds the state of this particular completion >>+ * >>+ * This will wake up a single thread waiting on this completion. If >>multiple > > > Your mailer appears to be wrapping lines. > > >>+ * threads are waiting ??? >>+ */ >> void complete(struct completion *x) >> { >> unsigned long flags; > > > complete() will only wake one waiting thread. If there are multiple > waiters, then further calls to complete() are required to wake them, > or a single call to complete_all() could be used. > > >> EXPORT_SYMBOL(wait_for_completion); >> >>+/** Take 2 ... Files attached this time ... kevin