From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Mel Gorman <mel@skynet.ie>,
andi@firstfloor.org, Rik van Riel <riel@redhat.com>,
mpm@selenic.com, Dave Chinner <david@fromorbit.com>
Subject: Re: [patch 1/3] dentries: Always use list_del_init() when removing a dentry from the lru
Date: Sun, 31 Aug 2008 17:50:24 +0300 [thread overview]
Message-ID: <48BAAFB0.8060304@cs.helsinki.fi> (raw)
In-Reply-To: <20080825212053.255444022@quilx.com>
Christoph Lameter wrote:
> The patch restores what commit 4a0962abd187df29b7d1378b2f372a55667d54c0
> already implemented. The feature was subsequently clobbered by
> commit da3bbdd4632c0171406b2677e31494afa5bde2f8
>
> Before this patch some execution path use list_del() instead of
> list_del_init() which results in inconsitencies in the state of d_lru
> when the object is freed.
>
> The performance of list_del_init() and list_del() is the same.
> So lets just have one dentry removal function named dentry_lru_del() that always
> does a list_del_init().
>
> The result of this patch is that dentry->d_lru is now always empty when a
> dentry is freed. The dentry defragmentation patch depends on a defined state
> of a dentry on free.
>
> Signed-off-by: Christoph Lameter <cl@linux-foundation.org>
Applied, thanks!
next prev parent reply other threads:[~2008-08-31 14:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-25 21:20 [patch 0/3] Dentry support for Slab Fragmentation Reduction Christoph Lameter
2008-08-25 21:20 ` [patch 1/3] dentries: Always use list_del_init() when removing a dentry from the lru Christoph Lameter
2008-08-31 14:50 ` Pekka Enberg [this message]
2008-08-25 21:20 ` [patch 2/3] dentries: Add constructor Christoph Lameter
2008-08-31 14:50 ` Pekka Enberg
2008-08-25 21:20 ` [patch 3/3] dentries: dentry defragmentation Christoph Lameter
2008-08-31 14:50 ` Pekka Enberg
2008-09-01 7:28 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48BAAFB0.8060304@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=cl@linux-foundation.org \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@skynet.ie \
--cc=mpm@selenic.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome