mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boaz Harrosh <bharrosh@panasas.com>
To: Ingo Molnar <mingo@elte.hu>,
	Rusty Russell <rusty@rustcorp.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	Ivo van Doorn <IvDoorn@gmail.com>,
	"John W. Linville" <linville@tuxdriver.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Theodore Tso <tytso@mit.edu>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jan Beulich <jbeulich@novell.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions
Date: Mon, 01 Sep 2008 16:00:45 +0300	[thread overview]
Message-ID: <48BBE77D.7070007@panasas.com> (raw)

Submitted a patchset to fix BUILD_BUG_ON to no longer let through
none compile-time constant expressions. This was debated a few
times on LKML. The final solution is as proposed by Rusty Russell,
which produces all expected results in my tests.
[see: http://www.spinics.net/lists/kernel/msg772904.html]

[PATCH 1/5] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__
  Ingo this is your patch. Please verify?

[PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage
[PATCH 3/5] virtio: Fix none-const BUILD_BUG_ON usage
[PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ON
  These three need maintainers approval. I hope I did not forget
  anyone

[PATCH 5/5] debug: BUILD_BUG_ON: error on none-const expressions
  Finally after all call sites are fixed this can go in.
  (Rusty this one is From: you)

I have only compiled ARCH=x86 (64/32) allmodconfig. So this might
break on other ARCHs. It should spend a night in Linux-Next to expose
these places.

Thanks
Boaz


             reply	other threads:[~2008-09-01 13:02 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 13:00 Boaz Harrosh [this message]
2008-09-01 13:07 ` [PATCH] debug, x86: move BUILD_BUG_ON() ARRAY_SIZE and __FUNCTION__ Boaz Harrosh
2008-09-01 13:11 ` [PATCH 2/5] net/niu: Fix none-const BUILD_BUG_ON usage Boaz Harrosh
2008-09-01 13:13 ` [PATCH 3/5] virtio: " Boaz Harrosh
2008-09-02 15:53   ` [PATCH 3/5 ver2] virtio: Fix non-const " Boaz Harrosh
2008-09-01 13:21 ` [PATCH 4/5] rt2x00: Compiler warning unmasked by fix of BUILD_BUG_ON Boaz Harrosh
2008-09-01 13:27   ` Ivo Van Doorn
2008-09-01 13:27   ` Benny Halevy
2008-09-01 13:44   ` [PATCH 4/5 ver2] " Boaz Harrosh
2008-09-01 14:01     ` Ivo Van Doorn
2008-09-01 15:17       ` Boaz Harrosh
2008-09-01 16:34         ` Ivo van Doorn
2008-09-02 14:20           ` Boaz Harrosh
2008-09-02 14:27             ` Ivo van Doorn
2008-09-02 15:55   ` Boaz Harrosh
2008-09-01 13:28 ` [PATCH 5/5] debug: BUILD_BUG_ON: error on non-const expressions Boaz Harrosh
2008-09-01 13:55   ` Jan Beulich
2008-09-01 14:21     ` Boaz Harrosh
2008-09-01 14:36       ` Jan Beulich
2008-09-01 15:00         ` Boaz Harrosh
2008-09-01 15:29           ` Jan Beulich
2008-09-01 16:41             ` Boaz Harrosh
2008-09-02  7:47               ` Jan Beulich
2008-09-02 15:19                 ` Boaz Harrosh
2008-09-02 15:57   ` [PATCH 5/5 ver2] " Boaz Harrosh
2008-09-02 16:06     ` Boaz Harrosh
2008-09-02 16:11     ` Jan Beulich
2008-09-03  8:57       ` Boaz Harrosh
2008-09-03 10:19         ` Jan Beulich
2008-09-03 10:52           ` Boaz Harrosh
2008-10-02  5:35     ` Rusty Russell
2008-10-05  9:34       ` Boaz Harrosh
2008-09-02 16:07   ` [PATCH 5/5 ver3] " Boaz Harrosh
2008-09-06 16:01 ` [PATCHSET 0/5] BUILD_BUG_ON: error on none-const expressions Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BBE77D.7070007@panasas.com \
    --to=bharrosh@panasas.com \
    --cc=IvDoorn@gmail.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mingo@elte.hu \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome