mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Joseph Barrow <D.Barow@option.com>
To: linux-kernel@vger.kernel.org,
	Andrew Bird <ajb@spheresystems.co.uk>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	Jeff Garzik <jgarzik@pobox.com>
Subject: re /drivers/char/n_tty.c drops characters
Date: Wed, 03 Sep 2008 11:29:39 +0200	[thread overview]
Message-ID: <48BE5903.1040207@option.com> (raw)

Hi all,
It looks like the it was the intention that n_tty.c
would not drop characters in older kernels around 2.6.15 in the
n_tty layer if N_TTY_BUF_SIZE was 4096 bytes
as TTY_FLIPBUF_SIZE was only 512 bytes.

Now since 2.6.15 or so tty_buffer_alloc in tty_io.c is capible
of allocating a tty buffer of over 64k I believe this
means that the n_tty_receive_buf will overflow if tty_buffer_alloc 
throws a buffer of over 4k to n_tty_receive_buf.

Any comments?

-- 
best regards,
D.J. Barrow

             reply	other threads:[~2008-09-03 10:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  9:29 Denis Joseph Barrow [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-09-03  8:32 Denis Joseph Barrow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48BE5903.1040207@option.com \
    --to=d.barow@option.com \
    --cc=ajb@spheresystems.co.uk \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome