From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6479C2D0B1 for ; Tue, 4 Feb 2020 12:03:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4AE220730 for ; Tue, 4 Feb 2020 12:03:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727218AbgBDMDU (ORCPT ); Tue, 4 Feb 2020 07:03:20 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:46937 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgBDMDU (ORCPT ); Tue, 4 Feb 2020 07:03:20 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 48BjyF4dRPzB3ww; Tue, 4 Feb 2020 23:03:17 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 6ec20aa2e510b6297906c45f009aa08b2d97269a In-Reply-To: To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 2/7] powerpc/32s: Fix bad_kuap_fault() Message-Id: <48BjyF4dRPzB3ww@ozlabs.org> Date: Tue, 4 Feb 2020 23:03:17 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-01-24 at 11:54:40 UTC, Christophe Leroy wrote: > At the moment, bad_kuap_fault() reports a fault only if a bad access > to userspace occurred while access to userspace was not granted. > > But if a fault occurs for a write outside the allowed userspace > segment(s) that have been unlocked, bad_kuap_fault() fails to > detect it and the kernel loops forever in do_page_fault(). > > Fix it by checking that the accessed address is within the allowed > range. > > Fixes: a68c31fc01ef ("powerpc/32s: Implement Kernel Userspace Access Protection") > Cc: stable@vger.kernel.org # v5.2+ > Signed-off-by: Christophe Leroy > Signed-off-by: Michael Ellerman > Link: https://lore.kernel.org/r/1e07c7de4ffdd9cda35d1ffe8258af75579d3e91.1579715466.git.christophe.leroy@c-s.fr Patches 2-7 applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/6ec20aa2e510b6297906c45f009aa08b2d97269a cheers