From: "Jan Beulich" <jbeulich@novell.com>
To: "Yinghai Lu" <yhlu.kernel@gmail.com>
Cc: "Ingo Molnar" <mingo@elte.hu>, <tglx@linutronix.de>,
<linux-kernel@vger.kernel.org>, <hpa@zytor.com>
Subject: Re: [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v2)
Date: Mon, 08 Sep 2008 16:30:38 +0100 [thread overview]
Message-ID: <48C5613E.76E4.0078.0@novell.com> (raw)
In-Reply-To: <86802c440809080753u5c42d052l65c7690b45854115@mail.gmail.com>
>> c->x86_virt_bits = (eax >> 8) & 0xff;
>> c->x86_phys_bits = eax & 0xff;
>> + /* CPUID workaround for Intel 0F33/0F34 CPU */
>> + if (c->x86_vendor == X86_VENDOR_INTEL
>> + && c->x86 == 0xF && c->x86_model == 0x3
>> + && (c->x86_mask == 0x3
>> + || c->x86_mask == 0x4))
>> + c->x86_phys_bits = 36;
>
>these lines should be in early_init_intel/init_intel.
>also need to be checked if it could be overwriten by others functions later..
I think this should then be a follow-up patch.
>BTW, did you address Peter's concern?
Sorry, I don't recall anything else I needed to address.
Jan
prev parent reply other threads:[~2008-09-08 15:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 12:07 Jan Beulich
2008-09-05 15:00 ` Ingo Molnar
2008-09-05 16:56 ` Yinghai Lu
2008-09-08 10:50 ` Jan Beulich
2008-09-08 13:40 ` Ingo Molnar
2008-09-08 18:54 ` Ingo Molnar
2008-09-09 7:22 ` Jan Beulich
2008-09-09 7:31 ` Ingo Molnar
2008-09-09 7:36 ` Jan Beulich
2008-09-09 7:43 ` [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v3) Jan Beulich
2008-09-09 7:47 ` Ingo Molnar
2008-09-09 7:58 ` Ingo Molnar
2008-09-09 8:15 ` Jan Beulich
2008-09-08 14:53 ` [PATCH] x86: x86_{phys,virt}_bits field also for i386 (v2) Yinghai Lu
2008-09-08 15:30 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48C5613E.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome