From: Eric Dumazet <dada1@cosmosbay.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
Christoph Lameter <clameter@sgi.com>,
linux-mm@vger.kernel.org, jeremy@goop.org, ebiederm@xmission.com,
travis@sgi.com, herbert@gondor.apana.org.au, xemul@openvz.org
Subject: Re: [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator
Date: Fri, 19 Sep 2008 09:39:55 +0200 [thread overview]
Message-ID: <48D3574B.40209@cosmosbay.com> (raw)
In-Reply-To: <20080918233701.832528677@quilx.com>
Christoph Lameter a écrit :
> Remove the builtin per cpu allocator from modules.c and use cpu_alloc instead.
>
> Signed-off-by: Christoph Lameter <clameter@sgi.com>
> + percpu_size = sechdrs[pcpuindex].sh_size;
> +
> + if (align > PAGE_SIZE) {
> + printk(KERN_WARNING "%s: per-cpu alignment %li > %li\n",
> + mod->name, align, PAGE_SIZE);
> + align = PAGE_SIZE;
> + }
Minor question : Wy do you have to keep this cap of alignment ?
I could not find such a limit in the allocator
next prev parent reply other threads:[~2008-09-19 7:40 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-18 23:36 [patch 0/4] Cpu alloc V4: Replace percpu allocator in modules.c Christoph Lameter
2008-09-18 23:36 ` [patch 1/4] Make the per cpu reserve configurable Christoph Lameter
2008-09-19 7:12 ` Pekka Enberg
2008-09-19 12:56 ` Christoph Lameter
2008-09-18 23:36 ` [patch 2/4] percpu: Rename variables PERCPU_ENOUGH_ROOM -> PERCPU_AREA_SIZE Christoph Lameter
2008-09-18 23:36 ` [patch 3/4] cpu alloc: The allocator Christoph Lameter
2008-09-19 7:58 ` Pekka Enberg
2008-09-19 13:11 ` Christoph Lameter
2008-09-19 14:12 ` Pekka Enberg
2008-09-19 14:27 ` Christoph Lameter
2008-09-19 14:35 ` Pekka Enberg
2008-09-18 23:36 ` [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator Christoph Lameter
2008-09-19 7:39 ` Eric Dumazet [this message]
2008-09-19 12:59 ` Christoph Lameter
2008-09-19 13:23 ` Eric Dumazet
2008-09-19 14:58 [patch 0/4] Cpu alloc V5: Replace percpu allocator in modules.c Christoph Lameter
2008-09-19 14:59 ` [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator Christoph Lameter
2008-09-29 19:35 [patch 0/4] Cpu alloc V6: Replace percpu allocator in modules.c Christoph Lameter
2008-09-29 19:35 ` [patch 4/4] cpu alloc: Use cpu allocator instead of the builtin modules per cpu allocator Christoph Lameter
2008-09-30 22:28 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48D3574B.40209@cosmosbay.com \
--to=dada1@cosmosbay.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=ebiederm@xmission.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=travis@sgi.com \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome