From: Lai Jiangshan <laijs@cn.fujitsu.com>
To: Andrew Morton <akpm@linux-foundation.org>, Greg KH <gregkh@suse.de>
Cc: stable@kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>,
Roland McGrath <roland@redhat.com>,
Wenji Huang <wenji.huang@oracle.com>,
Takashi Nishiie <t-nishiie@np.css.fujitsu.com>,
systemtap@sourceware.org
Subject: [PATCH] markers: fix missing modpost entry in Module.markers
Date: Tue, 07 Oct 2008 14:35:23 +0800 [thread overview]
Message-ID: <48EB032B.3070200@cn.fujitsu.com> (raw)
commit d35cb360c29956510b2fe1a953bd4968536f7216 brought a bug.
marker points compiled in vmlinux are missing in Module.markers.
# cat Module.markers
subsystem_event samples/markers/marker-example integer %d string %s
subsystem_eventb samples/markers/marker-example
# stap -e 'probe kernel.mark("core_marker_format"){} '
semantic error: no match while resolving probe point kernel.mark("core_marker_format")
semantic error: no probes found
Pass 2: analysis failed. Try again with more '-v' (verbose) options.
This patch revert a part of d35cb360c29956510b2fe1a953bd4968536f7216.
Other parts have fixed duplicate modpost entry bug.
Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
---
diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c
index 418cd7d..3509142 100644
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1992,8 +1992,7 @@ static void read_markers(const char *fname)
mod->skip = 1;
}
- if (!mod->skip)
- add_marker(mod, marker, fmt);
+ add_marker(mod, marker, fmt);
}
return;
fail:
next reply other threads:[~2008-10-07 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-07 6:35 Lai Jiangshan [this message]
2008-10-07 6:51 ` KOSAKI Motohiro
2008-10-07 10:09 ` Lai Jiangshan
2008-10-07 15:10 ` Mathieu Desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48EB032B.3070200@cn.fujitsu.com \
--to=laijs@cn.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
--cc=systemtap@sourceware.org \
--cc=t-nishiie@np.css.fujitsu.com \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome