From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A4D5C34047 for ; Wed, 19 Feb 2020 12:40:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB70A24656 for ; Wed, 19 Feb 2020 12:40:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727860AbgBSMkF (ORCPT ); Wed, 19 Feb 2020 07:40:05 -0500 Received: from bilbo.ozlabs.org ([203.11.71.1]:57039 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727833AbgBSMkD (ORCPT ); Wed, 19 Feb 2020 07:40:03 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 48My3h6S2Rz9sSd; Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 477f3488a94e35380c82a7498d46f10fa5f3edd2 In-Reply-To: <7bce32ccbab3ba3e3e0f27da6961bf6313df97ed.1581663140.git.christophe.leroy@c-s.fr> To: Christophe Leroy , Benjamin Herrenschmidt , Paul Mackerras , Larry Finger From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc/6xx: Fix power_save_ppc32_restore() with CONFIG_VMAP_STACK Message-Id: <48My3h6S2Rz9sSd@ozlabs.org> Date: Wed, 19 Feb 2020 23:40:00 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-02-14 at 06:53:00 UTC, Christophe Leroy wrote: > power_save_ppc32_restore() is called during exception entry, before > re-enabling the MMU. It substracts KERNELBASE from the address > of nap_save_msscr0 to access it. > > With CONFIG_VMAP_STACK enabled, data MMU translation has already been > re-enabled, so power_save_ppc32_restore() has to access > nap_save_msscr0 by its virtual address. > > Reported-by: Larry Finger > Signed-off-by: Christophe Leroy > Fixes: cd08f109e262 ("powerpc/32s: Enable CONFIG_VMAP_STACK") > Tested-by: Larry Finger Applied to powerpc fixes, thanks. https://git.kernel.org/powerpc/c/477f3488a94e35380c82a7498d46f10fa5f3edd2 cheers