From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=113.46.200.224 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1793090058; b=2rgje2ONi2ykmLFEJdT/frbQo2YJi5zaB0I4VIjxlogOEs8x7MhYu+36xg2w4s2+7HS+ cmlWKUumqBEzCG5k1PH/weDxM1Kxnice2tM0XSBb3xrYAlsCGmJ1Q3ju2dsk9fAUn4pTy K7zPvBJgCKWkPTkH6hKjo/pYZ88kSSY4JsqZk5MxzDV8xQra3oWnCOA1GiBW8iM3djbii 0SgBI+nrYHlIcztfjiyLfDNItv8KKtvTfXTnzQNmlzZy+aosZJHy+YEp8RsR397mA8lry XaYtHizQtXwSlJumSiLCAQMvwljPeDUgg/WTF3BJ0TkAcl8FkUChsRWC8n8/MOC38rQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1793090058; h=DMARC-Filter:dkim-signature:Received:Received:Received:Message-ID: Date:MIME-Version:User-Agent:Subject:To:CC:References:From: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Originating-IP: X-ClientProxiedBy; bh=Paz70CUE45Za5sCIaBCXSjkvwQezPROW6m2aMims3AY=; b=yhD++NL+bbTO/qtg2NiVmt/sYak+9/Et/LulG0CXFBCWQyRrR0D4l729B4wPHJWCUitG xla/doJ4+w6XxqDAghA8cZt2TGkCRHEY2h9XIEmwi7cwv7mDPW/evS1u4nM/dz5etQ2NX mu2JWx4fW/tYyFWazy8TfZcRC9+/f4+Sqx4jhVE8s2GAxlB/tcBdxmEwynItyzPjx2zZV eTm+nmGRP++cOiX+0TLKgWeIs/Ryo6lh1dNryNRyCp6uHrXNyLEDchjaLYyrl9w0hzLz1 fLVOszx1wA5BbutU7lwJidURFcWfGnyioBZjHfTr2bMhSQ94qG0tfpangLkfa/wq17A== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=huawei.com; spf=pass smtp.mailfrom=huawei.com; dkim=pass header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=QCjKH4ww; arc=none smtp.remote-ip=113.46.200.224 Received: from canpmsgout09.his.huawei.com (canpmsgout09.his.huawei.com [113.46.200.224]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE23F606A31B for ; Tue, 27 Oct 2026 08:34:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org BE23F606A31B Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=huawei.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=huawei.com header.i=@huawei.com header.a=rsa-sha256 header.s=dkim header.b=QCjKH4ww dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=Paz70CUE45Za5sCIaBCXSjkvwQezPROW6m2aMims3AY=; b=QCjKH4wwbxLVvROikxS5bkrF++9leg0mfIB3QR4giEMGIb82tHm8U7zlam2teLcUtmubZcl5E n6p2BKIvhiD6BVQmDLxEbFV+W7x0PTmYarRsmCkPHs3YazFtigkV8ko/GHg87JJOHq9sMKQ9P7C bf2aRIpweJ/1pXyMeDS+Scs= Received: from mail.maildlp.com (unknown [172.19.163.200]) by canpmsgout09.his.huawei.com (SkyGuard) with ESMTPS id 4jDP0p0FlXz1cyQt; Tue, 27 Oct 2026 16:34:02 +0800 (CST) Received: from kwepemk200008.china.huawei.com (unknown [7.202.194.74]) by mail.maildlp.com (Postfix) with ESMTPS id 2839D40563; Tue, 27 Oct 2026 16:34:08 +0800 (CST) Received: from [10.67.110.68] (10.67.110.68) by kwepemk200008.china.huawei.com (7.202.194.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.45; Tue, 27 Oct 2026 16:34:07 +0800 Message-ID: <48a17188-cddb-4759-b5df-2ba5691f17ac@huawei.com> Date: Tue, 27 Oct 2026 16:34:06 +0800 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/5] fs/resctrl: Drop unnecessary is_mba_linear() helper To: Reinette Chatre , , , , , , , , CC: , , , , , , , References: <816855328d87740b2cb720215d222702abba4b0f.1791406459.git.reinette.chatre@intel.com> From: Jinjie Ruan In-Reply-To: <816855328d87740b2cb720215d222702abba4b0f.1791406459.git.reinette.chatre@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-ClientProxiedBy: kwepems500002.china.huawei.com (7.221.188.17) To kwepemk200008.china.huawei.com (7.202.194.74) 在 2026/10/8 5:06, Reinette Chatre 写道: > is_mba_linear() assumes it operates on the MBA resource and returns whether > the resource's delay values are linear. There is only one caller that > separately makes the same assumption. > > Avoid duplicating the resource assumptions and let the only caller access > the needed property directly. > > Signed-off-by: Reinette Chatre > Reviewed-by: Chen Yu > Reviewed-by: Ben Horgan > --- > Changes from RFC v1: > - RFC v1 made bandwidth delay a resource property. That change was dropped > and this cleanup is all that remained. > > Changes since v1: > - Add Chenyu and Ben's Reviewed-by tags. > - Clarify "resource is linear" vs. "resource's delay values are linear". > --- > fs/resctrl/rdtgroup.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c > index 68be9b903ac6..821c6e2b10f4 100644 > --- a/fs/resctrl/rdtgroup.c > +++ b/fs/resctrl/rdtgroup.c > @@ -2577,11 +2577,6 @@ mongroup_create_dir(struct kernfs_node *parent_kn, struct rdtgroup *prgrp, > return ret; > } > > -static inline bool is_mba_linear(void) > -{ > - return resctrl_arch_get_resource(RDT_RESOURCE_MBA)->membw.delay_linear; > -} > - > static int mba_sc_domain_allocate(struct rdt_resource *r, struct rdt_ctrl_domain *d) > { > u32 num_closid = resctrl_arch_get_num_closid(r); > @@ -2621,7 +2616,7 @@ static bool supports_mba_mbps(void) > struct rdt_resource *r = resctrl_arch_get_resource(RDT_RESOURCE_MBA); > > return (resctrl_is_mbm_enabled() && > - r->alloc_capable && is_mba_linear() && > + r->alloc_capable && r->membw.delay_linear && LGTM Reviewed-by: Jinjie Ruan > r->ctrl_scope == rmbm->mon_scope && > !rmbm->mon.mbm_cntr_assignable); > } -- Best regards, Jinjie