From: Krzysztof Kozlowski <krzk@kernel.org>
To: tanmay.shah@amd.com, Ben Levinsky <ben.levinsky@amd.com>
Cc: jassisinghbrar@gmail.com, andersson@kernel.org,
mathieu.poirier@linaro.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, michal.simek@amd.com,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/6] mailbox: Add AMD PL Mailbox soft IP controller
Date: Fri, 16 Oct 2026 16:56:59 +0200 [thread overview]
Message-ID: <48ac1f6a-3de8-401b-a348-502178f7ff1c@kernel.org> (raw)
In-Reply-To: <0ad96f34-97d6-4998-9cf3-4b09ab6c94a2@amd.com>
On 16/10/2026 16:54, Shah, Tanmay wrote:
>>> +static const struct of_device_id amd_pl_mbox_of_match[] = {
>>> + { .compatible = "amd,zynqmp-pl-mbox-2.1" },
>>> + { .compatible = "amd,versal-pl-mbox-2.1" },
>>> + { .compatible = "amd,versal-net-pl-mbox-2.1" },
>>> + { .compatible = "amd,versal2-pl-mbox-2.1" },
>>
>> So all of them are compatible? Then why do you need all this?
>>
>
> Hi Krzysztof,
>
> This block will be used on 4 SoC - zynqmp, versal, versal-net & versal2.
> IIRC we should list each SoC where the device/hw block is available.
No, you do not list here every compatible device. You only list
fallbacks. Please open other drivers to see how this is done. Only hwmon
is an exception here with its own reason.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-16 14:57 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 21:34 [PATCH 0/6] Add AMD PL Mailbox and RPMsg support for the AMD BRAM remoteproc Ben Levinsky
2026-10-14 21:34 ` [PATCH 1/6] remoteproc: amd_mbv_bram: Bound device name formatting Ben Levinsky
2026-10-14 21:34 ` [PATCH 2/6] remoteproc: amd_mbv_bram: Restore reset GPIO direction after PL reconfig Ben Levinsky
2026-10-14 21:34 ` [PATCH 3/6] dt-bindings: mailbox: Add AMD PL Mailbox IP Ben Levinsky
2026-10-15 9:46 ` Krzysztof Kozlowski
[not found] ` <DM4PR12MB644859F1CA3A936684A3338B839C2@DM4PR12MB6448.namprd12.prod.outlook.com>
2026-10-15 14:29 ` Ben Levinsky
2026-10-15 15:31 ` Shah, Tanmay
2026-10-16 13:59 ` Krzysztof Kozlowski
2026-10-16 14:11 ` Shah, Tanmay
2026-10-16 13:57 ` Krzysztof Kozlowski
2026-10-14 21:34 ` [PATCH 4/6] mailbox: Add AMD PL Mailbox soft IP controller Ben Levinsky
2026-10-15 9:48 ` Krzysztof Kozlowski
[not found] ` <DM4PR12MB6448B4B18D0B45CCA678814F839C2@DM4PR12MB6448.namprd12.prod.outlook.com>
2026-10-15 14:30 ` Ben Levinsky
2026-10-16 14:54 ` Shah, Tanmay
2026-10-16 14:56 ` Krzysztof Kozlowski [this message]
2026-10-16 15:02 ` Ben Levinsky
2026-10-14 21:34 ` [PATCH 5/6] dt-bindings: remoteproc: Add RPMsg resources to AMD BRAM rproc Ben Levinsky
2026-10-15 9:49 ` Krzysztof Kozlowski
[not found] ` <DM4PR12MB64480F027338BA7A1EF91E17839C2@DM4PR12MB6448.namprd12.prod.outlook.com>
2026-10-15 14:32 ` Ben Levinsky
2026-10-14 21:34 ` [PATCH 6/6] remoteproc: amd_mbv_bram: Add RPMsg support Ben Levinsky
2026-10-15 9:51 ` Krzysztof Kozlowski
[not found] ` <DM4PR12MB6448FDE3208DB753A37EF3F9839C2@DM4PR12MB6448.namprd12.prod.outlook.com>
2026-10-15 14:33 ` Ben Levinsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ac1f6a-3de8-401b-a348-502178f7ff1c@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=ben.levinsky@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®