From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2525A3FD1; Sat, 28 Dec 2024 03:12:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=202.12.124.150 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735355538; cv=none; b=pem1YnPWoKSNZuraSqqmsCG+Je2IAsUiBqwJq57ng66v7HKDHFki5bFx4Tc/hHyEnk3SDZWzkwIWEvZP68OzLn2GGtmBn0sdZxMRYILiHOtB3UeXgcNUS9yXyhTY2Qw8hCtuZAKNE66LEPfyp/F5fxpi/m9cccTUBP4yPlzpcCo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735355538; c=relaxed/simple; bh=xB2b8kyWFRxwy++8sAnMq9Dp69EoofQxZcVM3Z5Y4QA=; h=MIME-Version:Date:From:To:Message-Id:In-Reply-To:References: Subject:Content-Type; b=PpWAyQ1RCwpHtft0DDlgYtTK9Wm2q9obDIrLXnV5Q90iA1/P3iCvyysJMmPMlIkuvSgIwP2+DMJWZGl+FIlvJb1g6llJzw/2LV7fTbNivy9jUUQm4pCm12pHVapDffLx/oyU908/1Pz3/2h8M7aIshnbC/th1pTerX+pwh5RBTQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca; spf=pass smtp.mailfrom=squebb.ca; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b=Gx0uFCW9; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=Uh273FYS; arc=none smtp.client-ip=202.12.124.150 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=squebb.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=squebb.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=squebb.ca header.i=@squebb.ca header.b="Gx0uFCW9"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="Uh273FYS" Received: from phl-compute-02.internal (phl-compute-02.phl.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id D24E51140145; Fri, 27 Dec 2024 22:12:13 -0500 (EST) Received: from phl-imap-10 ([10.202.2.85]) by phl-compute-02.internal (MEProxy); Fri, 27 Dec 2024 22:12:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=squebb.ca; h=cc :content-transfer-encoding:content-type:content-type:date:date :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1735355533; x=1735441933; bh=oTCiyUx/+Iu2Q1iKJZ0C11ZHzMKd0uDToUXZUmnZC9g=; b= Gx0uFCW9SJyIgblSonOVxISR1yFbwePs54I9de9HxcgQSj9aL/JbT8rUn671jL3j 4R2WB/qfQK6pFy1dM485GtJW895iJ1ltZUhpBeLmqZFXK28J2NhVEJxBRJRhKkfg P8aq5nVwHfuUMvsTnbfcyGL3dMqNZUzk+nlSpIMpG8EuGTUhNri4v+YbU1XpugeI /Y7kiDGwy3euuFK9ennxzuyXczlEgiOpt3kiSerKQRhrQ5LgjWhQVmRuBnQrnjly IdQs7Tk5Tzfd0ioiwfCbJx1DDCeXkZU4VOROExuK8ZbxTZrz9lqwiUa5rTXR7jfw TCxgTgQlyHf9Ku4B0D8C2g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm2; t=1735355533; x=1735441933; bh=o TCiyUx/+Iu2Q1iKJZ0C11ZHzMKd0uDToUXZUmnZC9g=; b=Uh273FYS3gHKEoK4R BdVwb6CxtzjnDIPIz6ZHIHUV3KpxjovBarjzpVtQ5DmHFDwGzx/l1Pq3Dy0oiJdD QtNYwHwDgjdNLaIHxZnILrZ8VR/fAHNXtMmEJ2SNFnRSVX/3pdwc3c7p4om6U7+2 Lf0Kdp5ke6TEBCeKHtAeZcPfbjNQuODh4WGe/P9OwqT4nFpthIKQwVGRPuCVWuFJ 1x307Z2f1pf4kW0i+7m0U/kyRSJHjDFTnJQM4v864RtWC2e4GBhzp3gvYr35W/eF J0qPHYxzRQqGlsgDJ2nP5XRIzDl2htI/Fkx5elSD0FMhWUD8FFrCuydaJKnkoCt3 mfzLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddruddvuddgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnecujfgurhepofggfffhvffkjghfufgtgfesthejredtredttden ucfhrhhomhepfdforghrkhcurfgvrghrshhonhdfuceomhhpvggrrhhsohhnqdhlvghnoh hvohesshhquhgvsggsrdgtrgeqnecuggftrfgrthhtvghrnhepkeffuedtveekjeeukefg leejgeetleduueetudefudehfefhheefleehheffffeknecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepmhhpvggrrhhsohhnqdhlvghnohhvohes shhquhgvsggsrdgtrgdpnhgspghrtghpthhtohepledpmhhouggvpehsmhhtphhouhhtpd hrtghpthhtohepvhhishhhnhhuohgtvhesghhmrghilhdrtghomhdprhgtphhtthhopehh mhhhsehhmhhhrdgvnhhgrdgsrhdprhgtphhtthhopehilhhpohdrjhgrrhhvihhnvghnse hlihhnuhigrdhinhhtvghlrdgtohhmpdhrtghpthhtohepihgsmhdqrggtphhiqdguvghv vghlsehlihhsthhsrdhsohhurhgtvghfohhrghgvrdhnvghtpdhrtghpthhtoheptghorh gsvghtsehlfihnrdhnvghtpdhrtghpthhtohephhguvghgohgvuggvsehrvgguhhgrthdr tghomhdprhgtphhtthhopehlihhnuhigqdguohgtsehvghgvrhdrkhgvrhhnvghlrdhorh hgpdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdho rhhgpdhrtghpthhtohepphhlrghtfhhorhhmqdgurhhivhgvrhdqgiekieesvhhgvghrrd hkvghrnhgvlhdrohhrgh X-ME-Proxy: Feedback-ID: ibe194615:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 030473C0066; Fri, 27 Dec 2024 22:12:12 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Fri, 27 Dec 2024 22:11:51 -0500 From: "Mark Pearson" To: "Vishnu Sankar" , "Jonathan Corbet" , "Henrique de Moraes Holschuh" , "Hans de Goede" , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net, "platform-driver-x86@vger.kernel.org" Message-Id: <48ae0687-0426-48d0-8f50-0b8f4e849697@app.fastmail.com> In-Reply-To: <20241227231840.21334-1-vishnuocv@gmail.com> References: <20241227231840.21334-1-vishnuocv@gmail.com> Subject: Re: [PATCH] platform/x86: thinkpad-acpi: Add support for hotkey 0x1401 Content-Type: text/plain Content-Transfer-Encoding: 7bit Thanks Vishnu, On Fri, Dec 27, 2024, at 6:18 PM, Vishnu Sankar wrote: > F8 mode key on Lenovo 2025 platforms use a different key code. > Adding support for the new keycode 0x1401. > > Tested on X1 Carbon Gen 13 and X1 2-in-1 Gen 10. > > Signed-off-by: Vishnu Sankar > --- > Documentation/admin-guide/laptops/thinkpad-acpi.rst | 10 +++++++--- > drivers/platform/x86/thinkpad_acpi.c | 4 +++- > 2 files changed, 10 insertions(+), 4 deletions(-) > > diff --git a/Documentation/admin-guide/laptops/thinkpad-acpi.rst > b/Documentation/admin-guide/laptops/thinkpad-acpi.rst > index 7f674a6cfa8a..4ab0fef7d440 100644 > --- a/Documentation/admin-guide/laptops/thinkpad-acpi.rst > +++ b/Documentation/admin-guide/laptops/thinkpad-acpi.rst > @@ -445,8 +445,10 @@ event code Key Notes > 0x1008 0x07 FN+F8 IBM: toggle screen expand > Lenovo: configure UltraNav, > or toggle screen expand. > - On newer platforms (2024+) > - replaced by 0x131f (see below) > + On 2024 platforms replaced by > + 0x131f (see below) and on newer > + platforms (2025 +) keycode is > + replaced by 0x1401 (see below). > > 0x1009 0x08 FN+F9 - > > @@ -506,9 +508,11 @@ event code Key Notes > > 0x1019 0x18 unknown > > -0x131f ... FN+F8 Platform Mode change. > +0x131f ... FN+F8 Platform Mode change (2024 systems). > Implemented in driver. > > +0x1401 ... FN+F8 Platform Mode change (2025 + systems). > + Implemented in driver. > ... ... ... > > 0x1020 0x1F unknown > diff --git a/drivers/platform/x86/thinkpad_acpi.c > b/drivers/platform/x86/thinkpad_acpi.c > index 6371a9f765c1..2cfb2ac3f465 100644 > --- a/drivers/platform/x86/thinkpad_acpi.c > +++ b/drivers/platform/x86/thinkpad_acpi.c > @@ -184,7 +184,8 @@ enum tpacpi_hkey_event_t { > */ > TP_HKEY_EV_AMT_TOGGLE = 0x131a, /* Toggle AMT on/off */ > TP_HKEY_EV_DOUBLETAP_TOGGLE = 0x131c, /* Toggle trackpoint doubletap > on/off */ > - TP_HKEY_EV_PROFILE_TOGGLE = 0x131f, /* Toggle platform profile */ > + TP_HKEY_EV_PROFILE_TOGGLE = 0x131f, /* Toggle platform profile in > 2024 systems */ > + TP_HKEY_EV_PROFILE_TOGGLE2 = 0x1401, /* Toggle platform profile in > 2025 + systems */ > > /* Reasons for waking up from S3/S4 */ > TP_HKEY_EV_WKUP_S3_UNDOCK = 0x2304, /* undock requested, S3 */ > @@ -11200,6 +11201,7 @@ static bool tpacpi_driver_event(const unsigned > int hkey_event) > tp_features.trackpoint_doubletap = !tp_features.trackpoint_doubletap; > return true; > case TP_HKEY_EV_PROFILE_TOGGLE: > + case TP_HKEY_EV_PROFILE_TOGGLE2: > platform_profile_cycle(); > return true; > } > -- > 2.45.2 Looks good to me. Reviewed-by: Mark Pearson Mark