mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Nayna <nayna@linux.vnet.ibm.com>
To: Stefan Berger <stefanb@linux.ibm.com>,
	linux-integrity@vger.kernel.org, keyrings@vger.kernel.org
Cc: linux-security-module@vger.kernel.org,
	David Howells <dhowells@redhat.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Mimi Zohar <zohar@linux.ibm.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Nayna Jain <nayna@linux.ibm.com>
Subject: Re: [PATCH 1/5] keys: cleanup build time module signing keys
Date: Fri, 12 Feb 2021 16:33:48 -0500	[thread overview]
Message-ID: <48b93c21-594b-2598-2fbc-bbb56fc1b277@linux.vnet.ibm.com> (raw)
In-Reply-To: <0f5c8c18-2a53-d3c4-e252-44aaee76a9e6@linux.ibm.com>


On 2/11/21 4:57 PM, Stefan Berger wrote:
> On 2/11/21 2:54 PM, Nayna Jain wrote:
>> The "mrproper" target is still looking for build time generated keys
>> in the old path instead of certs/ directory.
>> This patch fixes the path as well removes the names of the files which
>> are no longer generated.
>>
>> Signed-off-by: Nayna Jain <nayna@linux.ibm.com>
>> Fixes: 28a68f828266 ("modsign: Use single PEM file for autogenerated 
>> key")
> I was curious about some of the files and how they were created in the
> past but couldn't see it in the hostory of the Makefile. The above
> Fixes tag seems to give the wrong commit id:
>
>
> commit 28a68f828266754c2bd64b87873e8099e3f8fe0c
>
> Author: Dave Airlie <airlied@redhat.com>
> Date:   Thu Oct 29 13:59:45 2020 +1000
>
>     drm/radeon/ttm: use multihop
>

Thanks Stefan for noticing it. I will fix this in v2.

Thanks & Regards,

        - Nayna


  reply	other threads:[~2021-02-12 21:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-11 19:54 [PATCH 0/5] ima: kernel build support for loading the kernel module signing key Nayna Jain
2021-02-11 19:54 ` [PATCH 1/5] keys: cleanup build time module signing keys Nayna Jain
2021-02-11 21:57   ` Stefan Berger
2021-02-12 21:33     ` Nayna [this message]
2021-02-12 23:47   ` Jarkko Sakkinen
2021-02-11 19:54 ` [PATCH 2/5] keys: generate self-signed module signing key using CSR Nayna Jain
2021-02-11 22:01   ` Stefan Berger
2021-02-18 22:02     ` Nayna
2021-02-12 23:47   ` Jarkko Sakkinen
2021-02-11 19:54 ` [PATCH 3/5] ima: update kernel module signing process during build Nayna Jain
2021-02-11 19:54 ` [PATCH 4/5] keys: define build time generated ephemeral kernel CA key Nayna Jain
2021-02-11 22:13   ` Stefan Berger
2021-02-11 23:25     ` Mimi Zohar
2021-02-12  3:30   ` kernel test robot
2021-02-12  8:25   ` kernel test robot
2021-02-11 19:54 ` [PATCH 5/5] ima: enable loading of build time generated key to .ima keyring Nayna Jain
2021-02-11 22:32   ` Stefan Berger
2021-02-12 23:48   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48b93c21-594b-2598-2fbc-bbb56fc1b277@linux.vnet.ibm.com \
    --to=nayna@linux.vnet.ibm.com \
    --cc=dhowells@redhat.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=keyrings@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=nayna@linux.ibm.com \
    --cc=stefanb@linux.ibm.com \
    --cc=zohar@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®