From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailbackend.panix.com (mailbackend.panix.com [166.84.1.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E7EDA2E0402; Fri, 19 Dec 2025 20:55:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=166.84.1.89 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177739; cv=none; b=p1zyvRP34xQLSnOkp6imLY5Ta09L7wjrffoisc0JX5eSBhdMQEeKYBiuUbIUES9odmbMsHwCnXCcXi4w80k/3tYUb4w+PW9UPezNxKXwoK178rGvBLov4SYABScQZCqOgMuheYMr7xdj8cSxIWneqOEmx1GjqNdrpMP+7fwW/as= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766177739; c=relaxed/simple; bh=902N7+vSq4ZtgNz/0oajexrC3xsamP0KPKTs2JdrpEA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=oyTwj9r/X1cM2L6G6zgGA6nJTogM8hMFyHBZqo3nnKy1RS63rzo7CvQ6yaFE40ju/e2JprpXqQwg2TFUoEejPtKXdbMESB1mOLI8eDjHCkHe7sJI4SOTrH09VP2d3RJgOQXH/KNoD4+wikVOdzbWrosEmnss2iio5EVZRvUC0tU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=panix.com; spf=pass smtp.mailfrom=panix.com; dkim=pass (1024-bit key) header.d=panix.com header.i=@panix.com header.b=fHLo7h2x; arc=none smtp.client-ip=166.84.1.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=panix.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=panix.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=panix.com header.i=@panix.com header.b="fHLo7h2x" Received: from [192.168.123.3] (kenny-tx.gotdns.com [162.196.229.233]) by mailbackend.panix.com (Postfix) with ESMTPSA id 4dY0DN36Ldz4SSl; Fri, 19 Dec 2025 15:55:32 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=panix.com; s=panix; t=1766177735; bh=902N7+vSq4ZtgNz/0oajexrC3xsamP0KPKTs2JdrpEA=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=fHLo7h2xpB/TslaDr47UJ2ca80htNrHviXZyT/1DLKooZSuUCvGY1HXciWIqZR2C1 loy01eHGMtYjPwOTp7qJn28lI3Z2ai9XgIQ1PVHSCIRJy/oR9XETe6zbJ44ZJoXDvz dujiFZ8pZPqFY2eNsRSgvwGzGza5nRXFEuhRkTjc= Message-ID: <48b94c22-c1ca-4220-b184-f38e22544b9d@panix.com> Date: Fri, 19 Dec 2025 12:55:30 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] software node: Also support referencing non-constant software nodes To: Sakari Ailus , linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , "Rafael J. Wysocki" , Danilo Krummrich , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Linus Walleij , Philipp Zabel , Charles Keepax , linux-acpi@vger.kernel.org, linux-media@vger.kernel.org, johannes.goede@oss.qualcomm.com, Bartosz Golaszewski References: <20251219083638.2454138-1-sakari.ailus@linux.intel.com> Content-Language: en-US From: Kenneth Crudup In-Reply-To: <20251219083638.2454138-1-sakari.ailus@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Apparently last to the party :) but: Tested-By: Kenneth R. Crudup -K On 12/19/25 00:36, Sakari Ailus wrote: > Fwnode references are be implemented differently if referenced node is a > software node. _Generic() is used to differentiate between the two cases > but only const software nodes were present in the selection. Also add > non-const software nodes. > > Reported-by: Kenneth Crudup > Closes: https://lore.kernel.org/all/af773b82-bef2-4209-baaf-526d4661b7fc@panix.com/ > Fixes: d7cdbbc93c56 ("software node: allow referencing firmware nodes") > Signed-off-by: Sakari Ailus > --- > Hi Kenneth, > > Many thanks for reporting the issue and bisecting the offending patch! > Could you confirm whether this fixes the issue (it does for me)? > > - Sakari > > include/linux/property.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/linux/property.h b/include/linux/property.h > index 272bfbdea7bf..e30ef23a9af3 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -371,6 +371,7 @@ struct software_node_ref_args { > (const struct software_node_ref_args) { \ > .swnode = _Generic(_ref_, \ > const struct software_node *: _ref_, \ > + struct software_node *: _ref_, \ > default: NULL), \ > .fwnode = _Generic(_ref_, \ > struct fwnode_handle *: _ref_, \ -- Kenneth R. Crudup / Sr. SW Engineer, Scott County Consulting, Orange County CA