From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009B7426EA8 for ; Wed, 15 Jul 2026 09:46:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784108815; cv=none; b=qqXfarqG4ZNLSw/TQZOXEUUBBEGlbTjQm5nAbv57pQaWpzN6suJmUIgG/SAosqsKRH1ISALrZoQhr6wFoA2XjZeHjOxh8deh4P+0lS40VKUDWoX3UajrYhWN03ats968vAAV2ZnCMBCRvnNBg6nolkKUyU62SAetx6hPZljdACQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784108815; c=relaxed/simple; bh=DVHlqR13RKKSicyNlmQLuQKCabNOtP0RQfhHOijiZ/A=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=g1nGgfnO+cf5xiaGs+Sz6apZixdD5thAqhSI35hEYBDd1yfnLuTl0SsdePLB2Zf7U//BxeJENYHs603lff/cPlKCwurOOM2yTY/SXY42aVDmr9S55SYsX7Jz7GRO4ken9yyddUn2K/m3j8586rFeeyqZNcGa71qjuYT4s9AxlLI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=C/Y5Vh9G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=BRdegl71; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="C/Y5Vh9G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="BRdegl71" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66F3lGso2555482 for ; Wed, 15 Jul 2026 09:46:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 5U2dKNr880n5H4mqNL7E/1ba8CM5ns5ZA6U85j4NUqA=; b=C/Y5Vh9GLv2p8A7z yEEjzzhODb8g3+dXWTV2EkTieNoNpUj2TyEUbLzGCt5K9SmjPep97sNqWYQ0+2/3 GTgEsSRj3ryR2IV7N8d3N3SSWtvIuTNXTBjGMpZ+3wAEdOCrKrZo9RIGCqRmvBtI r+VrC6sLQLa+YKhud/sjqwB8gbG3YciBHiiIopLf2omc98QgYRBT2hCCcaDcQj9u SrYW6Pmi1nDfxYLYuHjJEE7Qmv3Hj5B57aQ+X+tV57251Uj9m7PwxMnKumO59C1N T577cEv/MEMN0sfZ4fMa7yb6lmBEqdFEMJsfsnVhw/7mJ9LFjAnXdluRFNpT/w8a JQlTUQ== Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fds9ku1n7-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 15 Jul 2026 09:46:49 +0000 (GMT) Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-2ccbb61893fso120487095ad.0 for ; Wed, 15 Jul 2026 02:46:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1784108808; x=1784713608; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=5U2dKNr880n5H4mqNL7E/1ba8CM5ns5ZA6U85j4NUqA=; b=BRdegl71T6wOulYbxLtNjGerfKE90f6aPhp+fenrRbdG55iLm9/P73BczLuSmAJsGb YgZWDzNQodcSHIZ1lfZgapMuHNLYdyVQEC0Fuxfc4OOWl5khbtxvny6VrJqHJnom6aZk OvkPoWHZpcosjSFWqHMPDM7VOnTIXtKPSUx3XxAMeAFi3ArlXhAISj2n7GyeMYvGplap xrx16hAua+ukn33pTY1KMKux5g8L5l0oI2JaXiuHQ28sNmrHcoXWZ0yxln946KKt4dgL Rt9uRJUO97iW4gcor8pWB4LG9OWfe4CInedtxAdnLGXRt0+0p/mPKczm82bbmulraB7E K5Rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784108808; x=1784713608; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=5U2dKNr880n5H4mqNL7E/1ba8CM5ns5ZA6U85j4NUqA=; b=iVJL8+TnmH/B02GAeoUjCEGPiAt2ERtYXGNZSxKEuTPJHB/0wR7K6e5RRnpMLLnrug xDsR8d/n+MA6JIabmLVt1vzhii/+oW4hcDpErw1Civc+1N4s+6dxsb/Y10T6z7b40lgx YvDYnkZJw3VC6hqXU0oCNcHeTxpYDZEPvNjXqrnDTwUQBp7l0TZ/8IpxU8RFNLYhJ2IQ hjFoG+eRqKlWlABsId5QxsJ0bg8gDm5c2G1rQLiHJ/laBlEAJFPB6qAWXqp2xBNY3ek8 3gRKfJjZaxFyxV5dArXeDnW0U1ELkmjuCG7AXSAUTpWsZ+eaJoNT4QM99Ng0+E5ZW2Zq EVDA== X-Forwarded-Encrypted: i=1; AHgh+Ro1H42P1j0oLf/XllkRMyXBHDNtIL+cWO3xOe9dpXOZzFyXETcb98HQCxzkevze5aw4jzOVid9/RKDONI0=@vger.kernel.org X-Gm-Message-State: AOJu0YxwK2OE48d3nTWakKE84BVh4pWfMpdsq17q4ztM+t1vMGUILLYe 1v1QLlwS5v5R+BmIX5gzybuXEy8e6FbmGY4TzRLehUR2uCL/yCUYhgi6fBhdC8oOBlnAnkTlgTI Z80wMfOhU3A57kYEBAz5+cKWsYetF2FOr/xq86qV4HahXY8JDuWRYuJl82+20i0/3bxY= X-Gm-Gg: AfdE7ck00pIYOKRMg+AyzIZMcEbMlUliulZU6gjqnqir5tm3fNNyVsCDpjh7GgaHNPe vepDV7uYE/CaPNNmYcsqnkr0JyJ9ikOe2GOqbG8RpnweNbM2SlhtVr4kMzeGGMtRBJdoclUbgyx nJcIXvWMdXtcXMXvd68jCMsy0buakO/Fcy5CumBiVkHcMPR7XwdqTJD1C1KNONUk8q2zKJiGTHn +5DKYYUfsbvduAVYrPwiGAl27/JcOmI71NtvYoKfXzO25nUnKy2Uk2eOG4JMLrOrGJhYNEskmNW pDTXeq7l3Jp6oheTuUHCIv7sU65/OVstQNyQB54BKDG7lf8mgm5jQZatygNEur4Wkuzpee9xNyn CgX0qbilEQzXH+zeYg5p5pFYD5e0zYID2XBmz52cjptwa X-Received: by 2002:a05:6a21:3a43:b0:3bf:a638:4376 with SMTP id adf61e73a8af0-3c357001859mr6662624637.21.1784108808136; Wed, 15 Jul 2026 02:46:48 -0700 (PDT) X-Received: by 2002:a05:6a21:3a43:b0:3bf:a638:4376 with SMTP id adf61e73a8af0-3c357001859mr6662586637.21.1784108807661; Wed, 15 Jul 2026 02:46:47 -0700 (PDT) Received: from [10.219.49.235] ([202.46.23.19]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3118ee6091dsm109927379eec.14.2026.07.15.02.46.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Jul 2026 02:46:47 -0700 (PDT) Message-ID: <48ba26cb-ada9-4639-8b77-d8cba2b31e22@oss.qualcomm.com> Date: Wed, 15 Jul 2026 15:16:41 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/7] ASoC: qcom: q6apm-lpass-dais: add TDM DAI operations To: Srinivas Kandagatla , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-sound@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260712134110.3306763-1-prasad.kumpatla@oss.qualcomm.com> <20260712134110.3306763-3-prasad.kumpatla@oss.qualcomm.com> Content-Language: en-US From: Prasad Kumpatla In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Q63iJY2a c=1 sm=1 tr=0 ts=6a575709 cx=c_pps a=IZJwPbhc+fLeJZngyXXI0A==:117 a=j4ogTh8yFefVWWEFDRgCtg==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=1NWjRULo-yTEZTBn0VQA:9 a=QEXdDO2ut3YA:10 a=uG9DUKGECoFWVXl0Dc02:22 X-Proofpoint-ORIG-GUID: lYkN79o4gZZRCjLOfH0onVWdoPsUWKSz X-Proofpoint-Spam-Info: AW1haW4tMjYwNzE1MDA5NCBTYWx0ZWRfX+VjV7m8EqDGJ bhpl9rWm4ZZKu4y/SBvZIOzeWAim2ym0P/D4S+U1rhX82hTf77nYDXtIK/CwEbyNUSTYEduezqo SBUuH4O2+GQDc8FAcCjrFbvz17fp37o= X-Proofpoint-GUID: lYkN79o4gZZRCjLOfH0onVWdoPsUWKSz X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzE1MDA5NCBTYWx0ZWRfX7deDZjX/b/y8 eP5hMVphRhdQXIwN+YZ5rHz43DmuJV6NzvWHPizYsvKWvmtai+JO6KuRLD01EX1rWXee6FBd2xB zwft20b6ucjsZ5U82pc5Cn22ISnMsa2On6GzebsFEBi44Kf9zjEVBc3LnJygj6SaZ85F65WXkcI FNdBCzyiB4aTOVJzCnxNVvMbXUqHUBv56iIumVV3S+sVgR+oa8QP23QcyjPiQEZgkWWBT5dypC3 1PFYFH29pkXb6rQgaDAwijNKfufWibs9Y8dsNKCHtRAciB9Ig3Jigym9SyFBFxlRvQHiFTyHhgt 2Rg3K9W/qnx9u4qTaiiUZ2TNO025Lhu/e2Ie93ixcfORGhYr/JtgoGZGlnuR2prR9pGcwiNtu1R ck/AybCdWsG6vdC5o1ljlXfDuq9wp0H9fnhjwoaaLpYqAGSqetRxjeK+eZIKxbqVdHzwvJTWHTL jVbshiLc+ckscOqT0sg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-15_02,2026-07-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607150094 On 7/14/2026 2:02 PM, Srinivas Kandagatla wrote: > > On 7/12/26 2:41 PM, Prasad Kumpatla wrote: >> Add TDM DAI operations to q6apm-lpass-dais so AudioReach TDM >> backends can be configured through the normal ASoC hw_params and DAI >> setup flow. >> >> The TDM set_tdm_slot() callback validates the supported slot width and >> slot count, stores the active slot mask in the AudioReach module >> configuration, and leaves existing DMA, I2S and HDMI paths unchanged. >> >> Reuse the existing LPASS child-clock handling for TDM nodes as well as >> MI2S nodes, since TDM backends also request optional backend clocks >> through the machine driver set_sysclk() path. >> >> Signed-off-by: Prasad Kumpatla >> --- >> sound/soc/qcom/qdsp6/q6apm-lpass-dais.c | 57 +++++++++++++++++++++++++ >> 1 file changed, 57 insertions(+) >> >> diff --git a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> index 5743586ff..672189625 100644 >> --- a/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> +++ b/sound/soc/qcom/qdsp6/q6apm-lpass-dais.c >> @@ -372,6 +372,50 @@ static int q6i2s_set_fmt(struct snd_soc_dai *dai, unsigned int fmt) >> return 0; >> } >> >> +static int q6tdm_set_tdm_slot(struct snd_soc_dai *dai, unsigned int tx_mask, >> + unsigned int rx_mask, int slots, int slot_width) >> +{ >> + struct q6apm_lpass_dai_data *dai_data = dev_get_drvdata(dai->dev); >> + struct audioreach_module_config *cfg = &dai_data->module_config[dai->id]; >> + unsigned int cap_mask; >> + >> + if (slot_width != 16 && slot_width != 32) { >> + dev_err(dai->dev, "%s: invalid slot_width %d\n", __func__, slot_width); >> + return -EINVAL; >> + } >> + >> + switch (slots) { >> + case 2: >> + cap_mask = 0x03; >> + break; >> + case 4: >> + cap_mask = 0x0f; >> + break; >> + case 8: >> + cap_mask = 0xff; >> + break; >> + case 16: >> + cap_mask = 0xffff; >> + break; > switch (slots) { > case 2: > case 4: > case 8: > case 16: > cap_mask = GENMASK(slots - 1, 0); > break; > ? Hi Srini, Thanks for review. Good suggestion. The mask is derived directly from the number of slots, so using GENMASK(slots - 1, 0) is cleaner and avoids maintaining hardcoded values. I'll update this in the next revision. >> + default: >> + dev_err(dai->dev, "%s: invalid slots %d\n", __func__, slots); >> + return -EINVAL; >> + } >> + >> + switch (dai->id) { >> + case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7: >> + cfg->nslots_per_frame = slots; >> + cfg->slot_width = slot_width; >> + cfg->slot_mask = ((dai->id & 0x1) ? tx_mask : rx_mask) & cap_mask; > Should we validate the tx/rx mask here if its with in cap_mask range? That's a good point. The current implementation silently truncates any bits outside the valid slot range through & cap_mask. I'll add validation to reject masks containing bits beyond the configured number of slots and return -EINVAL instead of silently modifying the requested configuration. Thanks, Prasad >> + break; >> + default: >> + dev_err(dai->dev, "%s: invalid dai id 0x%x\n", __func__, dai->id); >> + return -EINVAL; >> + } >> + >> + return 0; >> +} >> + >> static const struct snd_soc_dai_ops q6dma_ops = { >> .prepare = q6apm_lpass_dai_prepare, >> .startup = q6apm_lpass_dai_startup, >> @@ -401,6 +445,17 @@ static const struct snd_soc_dai_ops q6hdmi_ops = { >> .trigger = q6apm_lpass_dai_trigger, >> }; >> >> +static const struct snd_soc_dai_ops q6tdm_ops = { >> + .prepare = q6apm_lpass_dai_prepare, >> + .startup = q6apm_lpass_dai_startup, >> + .shutdown = q6i2s_lpass_dai_shutdown, >> + .set_tdm_slot = q6tdm_set_tdm_slot, >> + .hw_params = q6dma_hw_params, >> + .set_fmt = q6i2s_set_fmt, >> + .set_sysclk = q6i2s_set_sysclk, >> + .trigger = q6apm_lpass_dai_trigger, >> +}; >> + >> static const struct snd_soc_component_driver q6apm_lpass_dai_component = { >> .name = "q6apm-be-dai-component", >> .of_xlate_dai_name = q6dsp_audio_ports_of_xlate_dai_name, >> @@ -429,6 +484,7 @@ static int of_q6apm_parse_dai_data(struct device *dev, >> case PRIMARY_MI2S_RX ... QUATERNARY_MI2S_TX: >> case QUINARY_MI2S_RX ... QUINARY_MI2S_TX: >> case SENARY_MI2S_RX ... SENARY_MI2S_TX: >> + case PRIMARY_TDM_RX_0 ... QUINARY_TDM_TX_7: >> priv = &data->priv[id]; >> priv->mclk = of_clk_get_by_name(node, "mclk"); >> if (IS_ERR(priv->mclk)) { >> @@ -490,6 +546,7 @@ static int q6apm_lpass_dai_dev_probe(struct platform_device *pdev) >> cfg.q6i2s_ops = &q6i2s_ops; >> cfg.q6dma_ops = &q6dma_ops; >> cfg.q6hdmi_ops = &q6hdmi_ops; >> + cfg.q6tdm_ops = &q6tdm_ops; >> dais = q6dsp_audio_ports_set_config(dev, &cfg, &num_dais); >> >> ret = devm_snd_soc_register_component(dev, &q6apm_lpass_dai_component, dais, num_dais);