From: Dmitry Safonov <dima@arista.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Dmitry Safonov <0x7f454c46@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andy Lutomirski <luto@kernel.org>,
Brian Geffon <bgeffon@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Chen Wandun <chenwandun@huawei.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Jiang <dave.jiang@intel.com>,
Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@redhat.com>,
Jason Gunthorpe <jgg@ziepe.ca>,
John Hubbard <jhubbard@nvidia.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
Minchan Kim <minchan@kernel.org>,
Ralph Campbell <rcampbell@nvidia.com>,
Russell King <linux@armlinux.org.uk>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
Thomas Gleixner <tglx@linutronix.de>,
Vishal Verma <vishal.l.verma@intel.com>,
Vlastimil Babka <vbabka@suse.cz>,
Wei Yongjun <weiyongjun1@huawei.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH v2] mm/mremap: Don't account pages in vma_to_resize()
Date: Wed, 21 Jul 2021 21:08:58 +0100 [thread overview]
Message-ID: <48ba72b8-3da2-e438-6148-5ec22172d475@arista.com> (raw)
In-Reply-To: <20210721130551.bbdeae56ca3ec2d0f28b0bac@linux-foundation.org>
On 7/21/21 9:05 PM, Andrew Morton wrote:
> On Wed, 21 Jul 2021 14:21:54 +0100 Dmitry Safonov <0x7f454c46@gmail.com> wrote:
>
>>> Let's not do this.
>>> Account memory in mremap() fast-path for growing VMAs or in move_vma()
>>> for actually moving things. The same simpler way as it's done by
>>> vm_stat_account(), but with a difference to call
>>> security_vm_enough_memory_mm() before copying/adjusting VMA.
>>>
>>> Originally noticed by Chen Wandun:
>>> https://lkml.kernel.org/r/20210717101942.120607-1-chenwandun@huawei.com
>>
>> The patch by Chen Wandun still makes sense with this v2.
>> Heh :-)
>
> Should
> https://lkml.kernel.org/r/20210717101942.120607-1-chenwandun@huawei.com
> still be applied then? Did you ack it?
>
Yes, please keep that patch with
Acked-by: Dmitry Safonov <dima@arista.com>
This one comes on the top to correct accounting for MREMAP_DONTUNMAP.
Thanks,
Dmitry
next prev parent reply other threads:[~2021-07-21 20:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 13:13 Dmitry Safonov
2021-07-21 13:21 ` Dmitry Safonov
2021-07-21 20:05 ` Andrew Morton
2021-07-21 20:08 ` Dmitry Safonov [this message]
2021-07-21 20:18 ` Dmitry Safonov
2021-07-22 15:58 ` Brian Geffon
2021-07-22 16:00 ` Brian Geffon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48ba72b8-3da2-e438-6148-5ec22172d475@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bgeffon@google.com \
--cc=catalin.marinas@arm.com \
--cc=chenwandun@huawei.com \
--cc=dan.carpenter@oracle.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jhubbard@nvidia.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=rcampbell@nvidia.com \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=vbabka@suse.cz \
--cc=viro@zeniv.linux.org.uk \
--cc=vishal.l.verma@intel.com \
--cc=wangkefeng.wang@huawei.com \
--cc=weiyongjun1@huawei.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®