From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3FCF0315D22 for ; Mon, 26 Jan 2026 09:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420627; cv=none; b=kNQUqBpWpWZItw5wCuv1GhzMv3eRbQQb8G52mpRGF9U//cJCAEqOx8OOIwh11oQic5geAnabP9EpfbQKJYKZSnPtTecYvEB+iBDwXTpFz7HJCyUc5TbIFyODJqIJqw4Q5w7+MP++HJbjBiXjT+32LVow9yiozq61ru5R4OL/Jqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769420627; c=relaxed/simple; bh=iF0jtrJlUrNHpWgOjOkf75eJXLoQ3RvCmYCuoX+XzEQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kfnW6U+aW6w3bT5JGuWSXX2FGq7DmpSp/c034lo5t9BN42dzQHdFu2xeFc7ryiG5ePSjKeQ/nqUdfFiMpnA80rjXzJ3Gl80BTx3sltZODhpm1HULH1A5TYI1x1Qp+h5L9DvWiFmJUNLMGHx3H1AJp23+sDKjqpFfrQ+UmNNwrMg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=SmHssHOQ; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=W6PIOwEZ; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="SmHssHOQ"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="W6PIOwEZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769420624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2RIapV1jNyyZRIdn1KJNs6Oqxeyn0EIFbQQYGbVwf34=; b=SmHssHOQsGJBENM+4MKgrA1wpKhd/L7m4e/k8O59f5P1XSrWkJ1f+iJt9V7VLot9BjhGgu PTSABwtvzrutp6eUhwIXhUc+76LcpgXCVva9FOtW1TINHrSuVPyogISwxwGPLPRATfhrfb b6Y2TAzT5nZ66G6HeO4PdstV7dp13wk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-74-Jo3-r-cuPHuzLqLfjBhJ6w-1; Mon, 26 Jan 2026 04:43:42 -0500 X-MC-Unique: Jo3-r-cuPHuzLqLfjBhJ6w-1 X-Mimecast-MFC-AGG-ID: Jo3-r-cuPHuzLqLfjBhJ6w_1769420621 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-435a6c0c794so3450860f8f.2 for ; Mon, 26 Jan 2026 01:43:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769420621; x=1770025421; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2RIapV1jNyyZRIdn1KJNs6Oqxeyn0EIFbQQYGbVwf34=; b=W6PIOwEZq2K8zbDXan8eNKI93yTeuukwcEeaWOroJxvkC6mCoqGtp5YZ3XhakvBv/a Uj/7FidsJnmLf1WlEDUI+G0hmPE8niyEOQuyBfuzI+fsm92nc4y3Rub/6vvxBUKWYPSV AwkQybI4veIUtyl4v+tIDgyZHVI/udyut02TTwTq0JFGBm264AkkfgKapTPL6bO7Tfuw QNTlFnV8dC3KPD2LBefmFldEVG9DLuEk105iiwyoo+RL0Id2k95oC14+FUmPxh1/c25e luyZ6k/BGUyG+Sj5pgvoeo7fJ0g49wse5mnSFwrr9WnC31+sJjW9V5CVShxKd9ZLbiUm LWjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769420621; x=1770025421; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2RIapV1jNyyZRIdn1KJNs6Oqxeyn0EIFbQQYGbVwf34=; b=Hsrs08C1+GiLQcA2VxoaAuStiwSKrfvnoT5k5hu2OFI82YzpMvwkdf5d9vbhhiYzct GQczc/gjnLzc5oiV+uUiy+buzD3u2S9JrA1P5y4TJmNA1ml2p9THlp4mQ0RuXfsLkKAv Wbmo6tK5d64UmK8tOmVQAtAMiVRo57PJfjXUsGq8sihRv5MjAhQohWDgAgyJyZWI1WCc lAT+G4xxZUmrIK3Ag4IOcvAHTPe2L5m0QWFralJZtPAAJdufYNG6KuxX9UuQfXuKEcNj 15p5HFsyG0uPnEn0SOrxYnGo4qWaVPUDJRhRHtMq5pQVPttJVPzshb2IUTRgqx+TXao5 V8RA== X-Forwarded-Encrypted: i=1; AJvYcCX0lBZRwhGk7T0xRIZTCE0MoeiFUYkluRM86i1CyBrIWt8k6tvJZ4pidwC3jKLa7uBwQqWTgByngkcDnzo=@vger.kernel.org X-Gm-Message-State: AOJu0YyvvCb/NJiEc6VoE2gDept94K/QBuqGP8drzcHtLh7Iid2PHkL2 pGATHYv0t+w9/zJPO1Q8XwAKTHK3oBw3lRirLFAqCwX/BHnNp5amQcNuu7TBBIYtx7ZhTAOH6rq MlvyTUo1APF3O/Zh61GZWbybLZoigftSQBBYT5ICU7fGGC1GNEP1UwDJB8oDFcSOxzw== X-Gm-Gg: AZuq6aKB0sPAb726gA9Ib24zYIO/cQeMcYv6YCYu/ddVPOwJtR10bHneEbP2dDDiFGU K3ZQiaziq/5hMEZxK7+qwThpXyBO+BglqLprV+teQqo5PyUbEDbxX8E3CRh0Mr5MrmuQhP70M/b 2+4qh1xy7rs1XMnTJ4uGwRjsWxay9SgibrAdh28RPNYT31hhOA1TBx9tnAgsrHc9ghnGLFroKJ8 1BeJSadOGhCoS00Ou0pwkXHC8z8NueFOF3gov6DLL9RPWtOik9gbTm13nmBgRBJ4+LAlhmagUTE yqti5p2/j9qKJsxycsGpGO2FxvmPN7LuU8jTndmThiuKynLR7Oz1272l4G0A3BmzGjGD0tq3TZw sMLc1ldOqxJJq8+DEgFQSmDj17W2m8y9oWfDcN8U0H/IdmzVi7Q== X-Received: by 2002:a05:6000:40dd:b0:42f:bc61:d1bd with SMTP id ffacd0b85a97d-435ca138f4cmr6111228f8f.45.1769420620895; Mon, 26 Jan 2026 01:43:40 -0800 (PST) X-Received: by 2002:a05:6000:40dd:b0:42f:bc61:d1bd with SMTP id ffacd0b85a97d-435ca138f4cmr6111188f8f.45.1769420620482; Mon, 26 Jan 2026 01:43:40 -0800 (PST) Received: from ?IPV6:2a01:e0a:c:37e0:8998:e0cf:68cc:1b62? ([2a01:e0a:c:37e0:8998:e0cf:68cc:1b62]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-435b1f7b4d8sm27537474f8f.38.2026.01.26.01.43.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jan 2026 01:43:40 -0800 (PST) Message-ID: <48be84fb-bee4-4a22-bde4-0d0c78282f80@redhat.com> Date: Mon, 26 Jan 2026 10:43:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] vt: Add enable module parameter To: Greg Kroah-Hartman Cc: Jiri Slaby , Nicolas Pitre , Calixte Pernot , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org References: <20260126092234.713465-1-jfalempe@redhat.com> <2026012613-cotton-jellied-b67a@gregkh> Content-Language: en-US, fr From: Jocelyn Falempe In-Reply-To: <2026012613-cotton-jellied-b67a@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 26/01/2026 10:33, Greg Kroah-Hartman wrote: > On Mon, Jan 26, 2026 at 10:21:50AM +0100, Jocelyn Falempe wrote: >> This allows to build the kernel with CONFIG_VT enabled, and choose >> on the kernel command line to enable it or not. > > This says what is happening, but not why? > >> Add vt.enable=1 to force enable, or vt.enable=0 to force disable. > > Why are we using a 1990's technology for a new feature? What is this > going to allow to have happen? Who needs/wants this? Who will use it? > For what? The goal is to ease the transition to disable CONFIG_VT. So if this is merged, you can boot without VT on any Linux distribution, without rebuilding the kernel. This option will also allow a distribution to disable VT by default, but users that really wants this can enable it on the kernel command line, without rebuilding the kernel. It will also avoid hacky solution in userspace like this: https://overhead.neocities.org/blog/systemd-logind-seat/#very-hacky-solutions > >> Signed-off-by: Jocelyn Falempe >> --- >> drivers/tty/Kconfig | 13 +++++++++++++ >> drivers/tty/vt/vt.c | 5 +++++ >> 2 files changed, 18 insertions(+) >> >> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig >> index 149f3d53b7608..2b94c2710687a 100644 >> --- a/drivers/tty/Kconfig >> +++ b/drivers/tty/Kconfig >> @@ -41,6 +41,19 @@ config VT >> If unsure, say Y, or else you won't be able to do much with your new >> shiny Linux system :-) >> >> +config VT_ENABLE >> + depends on VT >> + default y >> + bool "enable VT terminal" if EXPERT > > So no one will ever really use this config option? > > And you are doing 2 things in this patch, not just one, unlike what the > changelog said :( I can split that in two if you prefer. Adding a module parameter, and adding a Kconfig option, to choose the default for this module parameter. > > thanks, > > greg k-h > -- Jocelyn