From: Casey Connolly <casey.connolly@linaro.org>
To: Lukas Bulwahn <lbulwahn@redhat.com>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@redhat.com>
Subject: Re: [PATCH] MAINTAINERS: rectify file entry in QUALCOMM SMB CHARGER DRIVER
Date: Mon, 23 Jun 2025 18:31:32 +0200 [thread overview]
Message-ID: <48c87af4-7d42-4283-b407-697b78d5b913@linaro.org> (raw)
In-Reply-To: <20250623081240.149446-1-lukas.bulwahn@redhat.com>
On 6/23/25 10:12, Lukas Bulwahn wrote:
> From: Lukas Bulwahn <lukas.bulwahn@redhat.com>
>
> Commit 4deeea4b0741 ("MAINTAINERS: add myself as smbx charger driver
> maintainer") adds the section QUALCOMM SMB CHARGER DRIVER in MAINTAINERS,
> including a file entry pointing to qcom_smbx_charger.c. Within the same
> patch series, the commit 5ec53bcc7fce ("power: supply: pmi8998_charger:
> rename to qcom_smbx") renames qcom_pmi8998_charger.c to qcom_smbx.c and not
> to qcom_smbx_charger.c, though. Note that the commit message clearly
> indicates the intentional removal of the "_charger" suffix.
>
> Refer to the intended file.
oh dear, thanks for catching this!
>
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@redhat.com>
Acked-by: Casey connolly <casey.connolly@linaro.org>
> ---
> MAINTAINERS | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 41f13ccef4c8..c76ea415c56f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20612,7 +20612,7 @@ M: Casey Connolly <casey.connolly@linaro.org>
> L: linux-arm-msm@vger.kernel.org
> S: Maintained
> F: Documentation/devicetree/bindings/power/supply/qcom,pmi8998-charger.yaml
> -F: drivers/power/supply/qcom_smbx_charger.c
> +F: drivers/power/supply/qcom_smbx.c
>
> QUALCOMM QSEECOM DRIVER
> M: Maximilian Luz <luzmaximilian@gmail.com>
--
Casey (she/they)
next prev parent reply other threads:[~2025-06-23 16:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 8:12 Lukas Bulwahn
2025-06-23 16:31 ` Casey Connolly [this message]
2025-06-23 20:20 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48c87af4-7d42-4283-b407-697b78d5b913@linaro.org \
--to=casey.connolly@linaro.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lbulwahn@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas.bulwahn@redhat.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®