From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40EFCC3065A for ; Thu, 17 Aug 2023 15:39:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353238AbjHQPiz (ORCPT ); Thu, 17 Aug 2023 11:38:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47114 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353255AbjHQPi3 (ORCPT ); Thu, 17 Aug 2023 11:38:29 -0400 Received: from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B92130C5 for ; Thu, 17 Aug 2023 08:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Abhsr4wAJkBHjt5gPP6KEIw82cxDP5GLaTx4EpSEDTs=; b=s7n2Gqx8odgjU9jxl0Af1p0Rrl MLMfGUL/lO0LtGt1EKZMJlEW4CbKXZXNIgIw5iJUdVcykDfF7MlXpTedcJ369k6Z4VzpkajMC0BSC LDyMTiXxfQyK2hJizvGMF/3iK48pclfq8ciymfeP6GPUe4wag+r/NQIhWHS/gg+xxnTbR82ciFPsV DoBHx0PKRI3gOu4COtkRNIYZaTW/ZvV/9AbMb98+2V1ZxRDEyLvPSd/VCe3UkmADtBEW0o6mOvbMt Dlis387iIL2yhaiK39sqTD8lwzBdVYiCw5f3Ggg3XtToVb3giyetkF3eSEqTUARlWF6DddVr3FmCl QAip7EYQ==; Received: from [191.193.179.209] (helo=[192.168.1.111]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1qWf4n-001yCJ-VO; Thu, 17 Aug 2023 17:38:22 +0200 Message-ID: <48c9521c-88f5-4975-8bf0-85ac42431a36@igalia.com> Date: Thu, 17 Aug 2023 12:38:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/4] drm/amdgpu: Rework coredump to use memory dynamically Content-Language: en-US To: Shashank Sharma Cc: pierre-eric.pelloux-prayer@amd.com, amd-gfx@lists.freedesktop.org, =?UTF-8?B?J01hcmVrIE9sxaHDoWsn?= , =?UTF-8?Q?Timur_Krist=C3=B3f?= , Samuel Pitoiset , kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20230815195100.294458-1-andrealmeid@igalia.com> <20230815195100.294458-3-andrealmeid@igalia.com> <07ef59db-da17-15cf-789a-7f5d01b2c9c9@amd.com> <43f2df2f-46ff-4240-a86b-eff5f0c08888@igalia.com> From: =?UTF-8?Q?Andr=C3=A9_Almeida?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em 17/08/2023 12:26, Shashank Sharma escreveu: > > On 17/08/2023 17:17, André Almeida wrote: >> >> >> Em 17/08/2023 12:04, Shashank Sharma escreveu: >>> >>> On 17/08/2023 15:45, André Almeida wrote: >>>> Hi Shashank, >>>> >>>> Em 17/08/2023 03:41, Shashank Sharma escreveu: >>>>> Hello Andre, >>>>> >>>>> On 15/08/2023 21:50, André Almeida wrote: >>>>>> Instead of storing coredump information inside amdgpu_device struct, >>>>>> move if to a proper separated struct and allocate it dynamically. >>>>>> This >>>>>> will make it easier to further expand the logged information. >>>>>> >>>>>> Signed-off-by: André Almeida >>>>>> --- >>>>>> v4: change kmalloc to kzalloc >>>>>> --- >>>>>>   drivers/gpu/drm/amd/amdgpu/amdgpu.h        | 14 +++-- >>>>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 63 >>>>>> ++++++++++++++-------- >>>>>>   2 files changed, 49 insertions(+), 28 deletions(-) >>>>>> >>>>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >>>>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >>>>>> index 9c6a332261ab..0d560b713948 100644 >>>>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h >>>>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h >>>>>> @@ -1088,11 +1088,6 @@ struct amdgpu_device { >>>>>>       uint32_t *reset_dump_reg_list; >>>>>>       uint32_t            *reset_dump_reg_value; >>>>>>       int                             num_regs; >>>>>> -#ifdef CONFIG_DEV_COREDUMP >>>>>> -    struct amdgpu_task_info         reset_task_info; >>>>>> -    bool                            reset_vram_lost; >>>>>> -    struct timespec64               reset_time; >>>>>> -#endif >>>>>>       bool                            scpm_enabled; >>>>>>       uint32_t                        scpm_status; >>>>>> @@ -1105,6 +1100,15 @@ struct amdgpu_device { >>>>>>       uint32_t            aid_mask; >>>>>>   }; >>>>>> +#ifdef CONFIG_DEV_COREDUMP >>>>>> +struct amdgpu_coredump_info { >>>>>> +    struct amdgpu_device        *adev; >>>>>> +    struct amdgpu_task_info         reset_task_info; >>>>>> +    struct timespec64               reset_time; >>>>>> +    bool                            reset_vram_lost; >>>>>> +}; >>>>> >>>>> The patch looks good to me in general, but I would recommend >>>>> slightly different arrangement and segregation of GPU reset >>>>> information. >>>>> >>>>> Please consider a higher level structure adev->gpu_reset_info, and >>>>> move everything related to reset dump info into that, including >>>>> this new coredump_info structure, something like this: >>>>> >>>>> struct amdgpu_reset_info { >>>>> >>>>>      uint32_t *reset_dump_reg_list; >>>>> >>>>>      uint32_t *reset_dump_reg_value; >>>>> >>>>>      int num_regs; >>>>> >>>> >>>> Right, I can encapsulate there reset_dump members, >>>> >>>>> #ifdef CONFIG_DEV_COREDUMP >>>>> >>>>>     struct amdgpu_coredump_info *coredump_info;/* keep this dynamic >>>>> allocation */ >>>> >>>> but we don't need a pointer for amdgpu_coredump_info inside >>>> amdgpu_device or inside of amdgpu_device->gpu_reset_info, right? >>> >>> I think it would be better if we keep all of the GPU reset related >>> data in the same structure, so adev->gpu_reset_info->coredump_info >>> sounds about right to me. >>> >> >> But after patch 2/4, we don't need to store a coredump_info pointer >> inside adev, this is what I meant. What would be the purpose of having >> this pointer? It's freed by amdgpu_devcoredump_free(), so we don't >> need to keep track of it. > > Well, actually we are pulling in some 0parallel efforts on enhancing the > GPU reset information, and we were planning to use the coredump info for > some additional things. So if I have the coredump_info available (like > reset_task_info and vram_lost) across a few functions in the driver with > adev, it would make my job easy there :). It seems dangerous to use an object with this limited lifetime to rely to read on. If you want to use it you will need to change amdgpu_devcoredump_free() to drop a reference or you will need to use it statically, which defeats the purpose of this patch. Anyway, I'll add it as you requested. > > - Shashank > >> >>> - Shashank >>> >>>> >>>>> >>>>> #endif >>>>> >>>>> } >>>>> >>>>> >>>>> This will make sure that all the relevant information is at the >>>>> same place. >>>>> >>>>> - Shashank >>>>> >>>>        amdgpu_inc_vram_lost(tmp_adev);