From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E6EF3BD647 for ; Mon, 9 Mar 2026 12:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773060354; cv=none; b=ljvkymwnRqvDpJPbClkKHByPOPj7aIuzOzdKZUWKWKVw4QCMLUIRprP3jebg6lCyLuvJYxlaOCqoYk5Kc4plf1IJZUPGANRU4h4HqBuzZIfMnEe0x1UIzYOlgB+Lzf0ly0Ux/sSH9O3HKzXf98zhl+TG3AdDTN7z0hDgJHLrZD8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773060354; c=relaxed/simple; bh=ciKizxF4/peB6QoqMp/YaP6KjgNb3jK8WIpiBHrzYMs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KyPNWYBRX92OQdpHSIJImj9I3TYX1HgDfxqI7FuK4fKiL1w1b0iIDbIrbb7M01aeDhFoxFGq8jbUK0r7Xo4SQOB22YaN+tZbwQnkYg+l47XWxi7EoMw/yIuEfHBtJqLO8gWftEy+WOmIVLvZfSN3IVApTh44FDZlsXaZzuKZeRM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RJxHGez8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=arCxwMxM; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RJxHGez8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="arCxwMxM" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 629BnmmM1888903 for ; Mon, 9 Mar 2026 12:45:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7htRU030UkbwgiiMTsv8tqmBCQS1hKqLxCtSkMtmYYg=; b=RJxHGez8Ty/0vQ0Y pPBlFcR5683mwROj6D7MZPXjDseTZNdeIF2XGSdC8FHj2m1sAf9wZnLrXagAKH5b 0XUrYIkb/SZGlHch7y/pLrH1behCPEWkzTZ8+AAzrEsEyqyYkCqvkkGVM8wbfEUL L9uEvWl1mQuIS2NmTc9ADwjv/VARGhpwpS1KQA6jJyEJduydlEc+ZQ7bXy4kM9Ng tVybUB0gv2A/aqrIbLzrPU5PkuNS219FPqRZyujRtFtLZmxm1jF8U73PYCaRxYkh gt5eneHPilAb7/s1TYM9Zy84wv+aGZ6tznYwIBzrFgNvmYwp8J5Zx6QXE62GxdiV 9zDl9Q== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4crc83dd42-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 12:45:52 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cd8198fe16so93074685a.2 for ; Mon, 09 Mar 2026 05:45:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773060352; x=1773665152; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7htRU030UkbwgiiMTsv8tqmBCQS1hKqLxCtSkMtmYYg=; b=arCxwMxMc/m5oicyZnLQruJ8rH9Pd3i9uCWKk6SRyFDNjM5yIdvsLkD3sNn+dNgWnO Sr1hROO7b+JlxGNJo2k9etGgucKRBeja5GHByPsglYmmhuwwwCsg9LhWQ93RCPp55web xndGcWhEY3bkuBP6+2Uczh1obQwqR3Dy8hV1tH6XJyNwtSV5cQsAHzpJNVWQuKSk2W+X NqGhxQ0ez9zu6g8il+D1a0LKmVwhw0CMYOv/S0Q0C0LXV8albRwN2yzON0QwF4rLUCR3 7c51NNfB/ayPT9ArLQvgW7cZ7FJvpA+rkWj64kuv5hQxobGpt6Jbxf8qrUy41WxDPgJi 23pQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773060352; x=1773665152; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7htRU030UkbwgiiMTsv8tqmBCQS1hKqLxCtSkMtmYYg=; b=fn5dKyyr4ro4Xd8DLvroeo4uFzf2MySrvA9/ZCRu9LxxE0A0B1oizrufcYFXJXzCXp Vq2w2wmGtemxnPR7GdBqZXv7iltn460HmiYU1s3uCsbaJHYyrrN5SR+zq/wb4TkFRipo E2SpzabATIl6LIq1Z3p/F1EhyijgAx/HraVJ5ixFzLvZLizjXRahrPtEqRlme4OvSDnK NLIIMXf9YZ4/rU8rc+Pc9eSHZ4wbHDzZyKuPw6ExA3n9oSdptZvcXLrBuEO7Fs0inaYd 6JyKm0PN7vNPWQvfjcsLtTYsAzmqxLABKvKMjU9byKcVGEnkwZWj6Nht2F64ioEYga4x SnHA== X-Forwarded-Encrypted: i=1; AJvYcCXzfgxPLthPJDilGgMmhU8gML/ULgNXPNOzTmF+Ebcv6wAAm0WtLyT+67vd2s+9C+mOsspFekZ83NhEDhw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Bqi3QAx35bC4VKfoMSLRk8kKM+Ew+uX+qbHFBzAsxOQAVDwp CGVXE+iDn4b/odaTR6dkkkk1z6fw8BrG7OphVVqGGg5fs8YJFmsfbynooPsoRa/cg8+0OMMoCdS 8Ezzf61TwvWjMdNwxu5pOIL6JvkJj6l8tsqOVdS++pGW0UV8vPxQOc9IcM21pYccrcUg= X-Gm-Gg: ATEYQzyP/JPpKJgMY4sUxy+ROwloioOFYF+ogW8bhAQtLpi/6+ThFK6t+bWQW+WINQW CHgBi2A7sMGrs1/H2P13dMd00RXEBn68mQuF25hxZK6a9fGICasrCn9dK4zr5S+zN0AkwT09S0z SYl2ifdHhIpuq5lm1G5RLLT1nX7IYo84EaiJMa5UIVbEu43M5deGHRvJPV+lNSSR/sdTU0QUsDy YcM81biq8LTjmazaUdF9ZHa8uW+4hG+UXFU8e3DH5LPn5jQOlna9f3r/HUa6EBZ+E+f2VntN8BX Gb+njvPLmTmsI5O37Uujl3jUD/8QgZIBbthFBYMm9QvnFypKTU0QPycQ2TjU/6sUMre2h9/KdOw YYIc25CrCBqShuyd9vyoVOd+5e3hH5WpgWkmqfK6pJxYCQhVIiYm3ZpzGene+37FWx+T9zsafQv smrck= X-Received: by 2002:a05:620a:209d:b0:8cd:8bfb:a4a with SMTP id af79cd13be357-8cd8bfb0eb3mr161910985a.0.1773060351938; Mon, 09 Mar 2026 05:45:51 -0700 (PDT) X-Received: by 2002:a05:620a:209d:b0:8cd:8bfb:a4a with SMTP id af79cd13be357-8cd8bfb0eb3mr161908385a.0.1773060351520; Mon, 09 Mar 2026 05:45:51 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-661a55a660csm3141140a12.33.2026.03.09.05.45.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 09 Mar 2026 05:45:50 -0700 (PDT) Message-ID: <48c9e2ab-ab0a-4148-83d7-9aeb3de274cf@oss.qualcomm.com> Date: Mon, 9 Mar 2026 13:45:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/9] drm/msm/dp: fix HPD state status bit shift value To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh , Yongxing Mou Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang References: <20260305-hpd-refactor-v4-0-39c9d1fef321@oss.qualcomm.com> <20260305-hpd-refactor-v4-1-39c9d1fef321@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260305-hpd-refactor-v4-1-39c9d1fef321@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=R9UO2NRX c=1 sm=1 tr=0 ts=69aec100 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=5rTfuJP6cXs4uNvNC2oA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDExNiBTYWx0ZWRfX/eDLH2TzOY2Z Q7JK7501Coemdp2tHKraYMsOrUvXI0bm8h16SyP+KAlSXs3RjVYWp32/CURscw/B2E9oFx9l9q+ wUOpfYxxeb2fcjoQpJOMD4NJ8JjNht92F4Dcm9DPcpJRtyB3uU6tvsIVnvlqYDqe5DAUxzQRY8H kRDcUDmIWR9baZEePznrvDy+1xjjMwJdCQuV3UJ9wTU+1EEfhMWCtOZOQdn1we7nAqJ4a4ntF3G XyH3DRfDsh8GvZgL88Lt9QZrZi5xbJftRG+XYb+UwHqIOUO6NTlJNFKVR6k4/EDl18gt+seJ+PK KQpQ7L2aAX7rXPfCbPs+z1U58RjR3pmiox6keJ0q4yOlArmYaMfMsqzmuN6Ny5Byrb8iJ9fbwi0 MwZTvmff7br2MUI8zLESi2OkNCfnH2loBw5KKnqodNO9rr3fKJpLsCM8Tt2DZC67fs40HgHC1mL EXnhK0GHtogihK2QnjA== X-Proofpoint-ORIG-GUID: _IEQH563unVCcRIFA2yDAEAWgthoMzPM X-Proofpoint-GUID: _IEQH563unVCcRIFA2yDAEAWgthoMzPM X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 spamscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090116 On 3/5/26 3:30 PM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > The HPD state status is the 3 most significant bits, not 4 bits of the > HPD_INT_STATUS register. > > Fix the bit shift macro so that the correct bits are returned in > msm_dp_aux_is_link_connected(). > > Fixes: 19e52bcb27c2 ("drm/msm/dp: return correct connection status after suspend") > Signed-off-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- Reviewed-by: Konrad Dybcio Konrad