From: Dmitry Safonov <dima@arista.com>
To: Eric Dumazet <edumazet@google.com>
Cc: David Ahern <dsahern@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
linux-kernel@vger.kernel.org,
Andy Lutomirski <luto@amacapital.net>,
Ard Biesheuvel <ardb@kernel.org>,
Bob Gilligan <gilligan@arista.com>,
Dan Carpenter <error27@gmail.com>,
David Laight <David.Laight@aculab.com>,
Dmitry Safonov <0x7f454c46@gmail.com>,
Donald Cassidy <dcassidy@redhat.com>,
Eric Biggers <ebiggers@kernel.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Francesco Ruggeri <fruggeri05@gmail.com>,
"Gaillardetz, Dominik" <dgaillar@ciena.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Ivan Delalande <colona@arista.com>,
Leonard Crestez <cdleonard@gmail.com>,
Salam Noureddine <noureddine@arista.com>,
"Tetreault, Francois" <ftetreau@ciena.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections
Date: Thu, 10 Aug 2023 17:40:36 +0100 [thread overview]
Message-ID: <48e4d7b6-d02b-f1c5-26d0-92ff3ca4df2e@arista.com> (raw)
In-Reply-To: <CANn89i+eUrn6tzQBNQjywyS-rsqm_uamJRdfP0-o_Pz2Dv1t8A@mail.gmail.com>
On 8/10/23 17:36, Eric Dumazet wrote:
> On Thu, Aug 10, 2023 at 6:27 PM Dmitry Safonov <dima@arista.com> wrote:
>>
>> On 8/8/23 14:43, Eric Dumazet wrote:
>>> On Wed, Aug 2, 2023 at 7:27 PM Dmitry Safonov <dima@arista.com> wrote:
>> [..]
>>>>
>>>> +bool tcp_ao_ignore_icmp(struct sock *sk, int type, int code)
>>>
>>> const struct sock *sk ?
>>
>> Well, I can't really: atomic64_inc(&ao->counters.dropped_icmp)
>
> I think we could, because this would still work.
>
> struct tcp_ao_info *ao; // This is rw object
Yeah, right, had not enough coffee today.
> ao = rcu_dereference(tcp_sk(sk)->ao_info);
>
> This helper looks to accept unlocked sockets, so marking them const
> would avoid mistakes in the future.
I see, will make it `const', thanks!
--
Dmitry
next prev parent reply other threads:[~2023-08-10 16:41 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 17:26 [PATCH v9 net-next 00/23] net/tcp: Add TCP-AO support Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 01/23] net/tcp: Prepare tcp_md5sig_pool for TCP-AO Dmitry Safonov
2023-08-08 9:58 ` Eric Dumazet
2023-08-11 21:02 ` Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 02/23] net/tcp: Add TCP-AO config and structures Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 03/23] net/tcp: Introduce TCP_AO setsockopt()s Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 04/23] net/tcp: Prevent TCP-MD5 with TCP-AO being set Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 05/23] net/tcp: Calculate TCP-AO traffic keys Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 06/23] net/tcp: Add TCP-AO sign to outgoing packets Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 07/23] net/tcp: Add tcp_parse_auth_options() Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 08/23] net/tcp: Add AO sign to RST packets Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 09/23] net/tcp: Add TCP-AO sign to twsk Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 10/23] net/tcp: Wire TCP-AO to request sockets Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 11/23] net/tcp: Sign SYN-ACK segments with TCP-AO Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 12/23] net/tcp: Verify inbound TCP-AO signed segments Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 13/23] net/tcp: Add TCP-AO segments counters Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 14/23] net/tcp: Add TCP-AO SNE support Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 15/23] net/tcp: Add tcp_hash_fail() ratelimited logs Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 16/23] net/tcp: Ignore specific ICMPs for TCP-AO connections Dmitry Safonov
2023-08-08 13:43 ` Eric Dumazet
2023-08-10 16:26 ` Dmitry Safonov
2023-08-10 16:36 ` Eric Dumazet
2023-08-10 16:40 ` Dmitry Safonov [this message]
2023-08-02 17:26 ` [PATCH v9 net-next 17/23] net/tcp: Add option for TCP-AO to (not) hash header Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 18/23] net/tcp: Add TCP-AO getsockopt()s Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 19/23] net/tcp: Allow asynchronous delete for TCP-AO keys (MKTs) Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 20/23] net/tcp: Add static_key for TCP-AO Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 21/23] net/tcp: Wire up l3index to TCP-AO Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 22/23] net/tcp: Add TCP_AO_REPAIR Dmitry Safonov
2023-08-02 17:26 ` [PATCH v9 net-next 23/23] Documentation/tcp: Add TCP-AO documentation Dmitry Safonov
2023-08-02 19:37 ` [PATCH v9 net-next 00/23] net/tcp: Add TCP-AO support Dmitry Safonov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e4d7b6-d02b-f1c5-26d0-92ff3ca4df2e@arista.com \
--to=dima@arista.com \
--cc=0x7f454c46@gmail.com \
--cc=David.Laight@aculab.com \
--cc=ardb@kernel.org \
--cc=cdleonard@gmail.com \
--cc=colona@arista.com \
--cc=davem@davemloft.net \
--cc=dcassidy@redhat.com \
--cc=dgaillar@ciena.com \
--cc=dsahern@kernel.org \
--cc=ebiederm@xmission.com \
--cc=ebiggers@kernel.org \
--cc=edumazet@google.com \
--cc=error27@gmail.com \
--cc=fruggeri05@gmail.com \
--cc=ftetreau@ciena.com \
--cc=gilligan@arista.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=netdev@vger.kernel.org \
--cc=noureddine@arista.com \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®